qcow2-bitmaps: rewrite reopening logic
Status from this message: Thanks, applied to my bitmaps tree:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest9 patches 4 repliesApplied
- v410 patches 23 repliesSuperseded
- v39 patches 7 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 9 patches | 9 replies | Superseded | |
| v1 | 3 patches | 13 replies | Superseded |
Changes in v5 from the cover letter
01: - add Max's r-b
- fix s/QSIMPLE_INIT/QTAILQ_INIT/ in a comment
02: - add Max's and John's a-b
03: - improve test to check bitmap hashes in more safe way 07: - drop wrong statement from commit message
- log events by hand
08: - drop 'the' from comment
- add Corruption in case of existent IN_USE on RO->RW reopen
09: - add Max's a-b and John's r-b
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | block: switch reopen queue from QSIMPLEQ to QTAILQblock.c include/ | +13 | 0 replies | |
| 2/9 | block: reverse order for reopen commitsblock.c | +9 | 0 replies | |
| 3/9 | iotests: add test-case to 165 to test reopening qcow2 bitmaps to RWtests/ tests/ | +57 | 1 reply | |
| 4/9 | block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmapsblock/ block/ include/ | +13 | 0 replies | |
| 5/9 | block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint()block/ block/ | +1 | 0 replies | |
| 6/9 | block/qcow2-bitmap: do not remove bitmaps on reopen-roblock/ block/ block/ | +37 | 0 replies | |
| 7/9 | iotests: add test 260 to check bitmap life after snapshot + committests/ tests/ tests/ | +142 | 0 replies | |
| 8/9 | block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rwblock/ | +58 | 0 replies | |
| 9/9 | qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_commitblock.c block/ include/ | +14 | 0 replies |
Reviews trailers per patch
7 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Max Reitz | John Snow |
|---|---|---|
| Series | R-b | |
| 1/9 | R-b | |
| 2/9 | A-b | A-b |
| 3/9 | R-b | |
| 4/9 | R-b | |
| 5/9 | R-b | |
| 6/9 | R-b | |
| 7/9 | ||
| 8/9 | ||
| 9/9 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/9] qcow2-bitmaps: rewrite reopening logic
Hi all!
Bitmaps reopening is buggy, reopening-rw just not working at all and reopening-ro may lead to producing broken incremental backup if we do temporary snapshot in a meantime.
v5:
01: - add Max's r-b
- fix s/QSIMPLE_INIT/QTAILQ_INIT/ in a comment
02: - add Max's and John's a-b
03: - improve test to check bitmap hashes in more safe way 07: - drop wrong statement from commit message
- log events by hand
08: - drop 'the' from comment
- add Corruption in case of existent IN_USE on RO->RW reopen
09: - add Max's a-b and John's r-b
v4: Drop complicated solution around reopening logic [Kevin], fix
the existing bug in a simplest way
Vladimir Sementsov-Ogievskiy (9):
block: switch reopen queue from QSIMPLEQ to QTAILQ
block: reverse order for reopen commits
iotests: add test-case to 165 to test reopening qcow2 bitmaps to RW block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint() block/qcow2-bitmap: do not remove bitmaps on reopen-ro
iotests: add test 260 to check bitmap life after snapshot + commit block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw
qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_commit
block/qcow2.h | 5 +- include/block/block.h | 2 +- include/block/block_int.h | 6 -- include/block/dirty-bitmap.h | 1 - block.c | 53 +++++------ block/dirty-bitmap.c | 12 --- block/qcow2-bitmap.c | 164 ++++++++++++++++++++++------------- block/qcow2.c | 17 +++- tests/qemu-iotests/165 | 57 +++++++++++- tests/qemu-iotests/165.out | 4 +- tests/qemu-iotests/260 | 89 +++++++++++++++++++ tests/qemu-iotests/260.out | 52 +++++++++++ tests/qemu-iotests/group | 1 + 13 files changed, 343 insertions(+), 120 deletions(-) create mode 100755 tests/qemu-iotests/260 create mode 100644 tests/qemu-iotests/260.out
Signature · 1 line
2.21.0