Skip to content

ARM SMMUv3: Fix spurious notification errors and fail with VFIO

Eric Auger qemu-arm qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 3 repliesIn review
  2. v35 patches 7 repliesSuperseded
  3. v26 patches 10 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches6 repliesSuperseded

Changes in v4 from the cover letter

- see individual patches

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5memory: Remove unused memory_region_iommu_replay_all()include/exec/memory.h memory.c+0 -190 replies
2/5memory: Add IOMMU_ATTR_HW_NESTED_PAGING IOMMU memory region attributehw/arm/smmuv3.c include/exec/memory.h+19 -12 replies
3/5hw/vfio/common: Fail on VFIO/HW nested paging detectionhw/vfio/common.c+10 -00 replies
4/5hw/arm/smmuv3: Log a guest error when decoding an invalid STEhw/arm/smmuv3.c+1 -00 replies
5/5hw/arm/smmuv3: Remove spurious error messages on IOVA invalidationshw/arm/smmuv3-internal.h hw/arm/smmuv3.c+12 -80 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéPeter Xu
1/5R-b R-b
2/5
3/5
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-arm] [PATCH v4 0/5] ARM SMMUv3: Fix spurious notification errors and fail with VFIO

As of today when a guest is assigned with a host PCI device and an SMMUv3, VFIO calls memory_region_iommu_replay() default implementation. This translates the whole address range and completely stalls the execution. As VFIO/SMMUv3 integration is not supported yet (it requires SMMUv3 HW nested paging), let's recognize this situation and fail.

Also the series silences some spurious translation configuration decoding errors (STE out of span or invalid STE) that may happen on guest IOVA invalidation notifications.

Best Regards

Eric

This series can be found at:
https://github.com/eauger/qemu/tree/v4.1.0_smmu_vfio_fail_v4

History:

v3 -> v4:
- see individual patches

v2 -> v3:
- squash IOMMU_ATTR_VFIO_NESTED introduction and SMMUv3 usage
- assert when recognizing VFIO/NESTED case
- collect R-bs

v1 -> v2:
- Added "memory: Remove unused memory_region_iommu_replay_all()" & "hw/arm/smmuv3: Log a guest error when decoding an invalid STE"
- do not attempt to implement replay Cb but rather remove the call in case it is not needed
- explain why we do not remove other log messages on config decoding

Eric Auger (5):
memory: Remove unused memory_region_iommu_replay_all()
memory: Add IOMMU_ATTR_HW_NESTED_PAGING IOMMU memory region attribute hw/vfio/common: Fail on VFIO/HW nested paging detection hw/arm/smmuv3: Log a guest error when decoding an invalid STE hw/arm/smmuv3: Remove spurious error messages on IOVA invalidations

 hw/arm/smmuv3-internal.h |  1 +
 hw/arm/smmuv3.c          | 30 +++++++++++++++++++++++-------
 hw/vfio/common.c         | 10 ++++++++++
 include/exec/memory.h    | 18 +++++++-----------
 memory.c                 |  9 ---------
 5 files changed, 41 insertions(+), 27 deletions(-)
Signature · 1 line
2.20.1