backlight: gpio: simplify the driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest9 patches 12 repliesIn review
- v69 patches 4 repliesSuperseded
- v5 posting 2/27 patches 8 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 posting 1/2 | 0 of 7 patches | 0 replies | Superseded | |
| v4 | 7 patches | 7 replies | Superseded | |
| v3 posting 2/2 | 7 patches | 0 replies | Superseded | |
| v3 posting 1/2 | 7 patches | 17 replies | Superseded | |
| v2 | 7 patches | 16 replies | Superseded | |
| v1 | 4 patches | 2 replies | Superseded |
Changes in v7 from the cover letter
- renamed the function calculating the new GPIO value for status update
- collected more tags
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | backlight: gpio: remove unneeded includedrivers/ | +0 | 0 replies | |
| 2/9 | backlight: gpio: remove stray newlinedrivers/ | +0 | 0 replies | |
| 3/9 | backlight: gpio: explicitly set the direction of the GPIOdrivers/ | +18 | 1 reply | |
| 4/9 | sh: ecovec24: add additional properties to the backlight devicearch/ | +25 | 0 replies | |
| 5/9 | backlight: gpio: simplify the platform data handlingdrivers/ | +11 | 0 replies | |
| 6/9 | sh: ecovec24: don't set unused fields in platform dataarch/ | +0 | 0 replies | |
| 7/9 | backlight: gpio: remove unused fields from platform datainclude/ | +0 | 0 replies | |
| 8/9 | backlight: gpio: use a helper variable for &pdev->devdrivers/ | +11 | 0 replies | |
| 9/9 | backlight: gpio: pull gpio_backlight_initial_power_state() into probedrivers/ | +14 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Linus Walleij | Daniel Thompson | Andy Shevchenko | Jacopo Mondi |
|---|---|---|---|---|
| Series | T-b | |||
| 1/9 | R-b | R-b | R-b | |
| 2/9 | R-b | R-b | ||
| 3/9 | R-b | |||
| 4/9 | R-b | R-b | ||
| 5/9 | R-b | R-b | R-b | |
| 6/9 | R-b | R-b | ||
| 7/9 | R-b | R-b | R-b | |
| 8/9 | R-b | R-b | R-b | |
| 9/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v7 0/9] backlight: gpio: simplify the driver
From: Bartosz Golaszewski <[email protected]>
While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that.
First two patches contain minor fixes. Third patch makes the driver explicitly drive the GPIO line. Fourth patch adds all necessary data structures to ecovec24. Patch 5/9 unifies much of the code for both pdata and non-pdata cases. Patches 6-7/9 remove unused platform data fields. Last two patches contain additional improvements for the GPIO backlight driver while we're already modifying it.
I don't have access to this HW but hopefully this works. Only compile tested.
[1] https://lkml.org/lkml/2019/6/25/900
v1 -> v2:
- rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
- added additional two patches with minor improvements
v2 -> v3:
- in patch 7/7: used initializers to set values for pdata and dev local vars
v3 -> v4:
- rebased on top of v5.4-rc1
- removed changes that are no longer relevant after commit ec665b756e6f ("backlight: gpio-backlight: Correct initial power state handling")
- added patch 7/7
v4 -> v5:
- in patch 7/7: added a comment replacing the name of the function being pulled into probe()
v5 -> v6:
- added a patch making the driver explicitly set the direction of the GPIO to output
- added a patch removing a redundant newline
v6 -> v7:
- renamed the function calculating the new GPIO value for status update
- collected more tags
Bartosz Golaszewski (9):
backlight: gpio: remove unneeded include
backlight: gpio: remove stray newline
backlight: gpio: explicitly set the direction of the GPIO
sh: ecovec24: add additional properties to the backlight device
backlight: gpio: simplify the platform data handling
sh: ecovec24: don't set unused fields in platform data
backlight: gpio: remove unused fields from platform data
backlight: gpio: use a helper variable for &pdev->dev
backlight: gpio: pull gpio_backlight_initial_power_state() into probe
arch/sh/boards/mach-ecovec24/setup.c | 33 +++-- drivers/video/backlight/gpio_backlight.c | 128 +++++++------------ include/linux/platform_data/gpio_backlight.h | 3 - 3 files changed, 69 insertions(+), 95 deletions(-)
Signature · 1 line
2.23.0