Skip to content

backlight: gpio: simplify the driver

Bartosz Golaszewski dri-devel linux-fbdev linux-sh lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest9 patches 12 repliesIn review
  2. v69 patches 4 repliesSuperseded
  3. v5 posting 2/27 patches 8 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v5 posting 1/20 of 7 patches0 repliesSuperseded
v47 patches7 repliesSuperseded
v3 posting 2/27 patches0 repliesSuperseded
v3 posting 1/27 patches17 repliesSuperseded
v27 patches16 repliesSuperseded
v14 patches2 repliesSuperseded

Changes in v7 from the cover letter

- renamed the function calculating the new GPIO value for status update
- collected more tags

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9backlight: gpio: remove unneeded includedrivers/video/backlight/gpio_backlight.c+0 -10 replies
2/9backlight: gpio: remove stray newlinedrivers/video/backlight/gpio_backlight.c+0 -10 replies
3/9backlight: gpio: explicitly set the direction of the GPIOdrivers/video/backlight/gpio_backlight.c+18 -51 reply
4/9sh: ecovec24: add additional properties to the backlight devicearch/sh/boards/mach-ecovec24/setup.c+25 -50 replies
5/9backlight: gpio: simplify the platform data handlingdrivers/video/backlight/gpio_backlight.c+11 -510 replies
6/9sh: ecovec24: don't set unused fields in platform dataarch/sh/boards/mach-ecovec24/setup.c+0 -30 replies
7/9backlight: gpio: remove unused fields from platform datainclude/linux/platform_data/gpio_backlight.h+0 -30 replies
8/9backlight: gpio: use a helper variable for &pdev->devdrivers/video/backlight/gpio_backlight.c+11 -120 replies
9/9backlight: gpio: pull gpio_backlight_initial_power_state() into probedrivers/video/backlight/gpio_backlight.c+14 -240 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijDaniel ThompsonAndy ShevchenkoJacopo Mondi
SeriesT-b
1/9R-b R-b R-b
2/9R-b R-b
3/9R-b
4/9R-b R-b
5/9R-b R-b R-b
6/9R-b R-b
7/9R-b R-b R-b
8/9R-b R-b R-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/9] backlight: gpio: simplify the driver

From: Bartosz Golaszewski <[email protected]>

While working on my other series related to gpio-backlight[1] I noticed that we could simplify the driver if we made the only user of platform data use GPIO lookups and device properties. This series tries to do that.

First two patches contain minor fixes. Third patch makes the driver explicitly drive the GPIO line. Fourth patch adds all necessary data structures to ecovec24. Patch 5/9 unifies much of the code for both pdata and non-pdata cases. Patches 6-7/9 remove unused platform data fields. Last two patches contain additional improvements for the GPIO backlight driver while we're already modifying it.

I don't have access to this HW but hopefully this works. Only compile tested.

[1] https://lkml.org/lkml/2019/6/25/900

v1 -> v2:
- rebased on top of v5.3-rc1 and adjusted to the recent changes from Andy
- added additional two patches with minor improvements

v2 -> v3:
- in patch 7/7: used initializers to set values for pdata and dev local vars

v3 -> v4:
- rebased on top of v5.4-rc1
- removed changes that are no longer relevant after commit ec665b756e6f ("backlight: gpio-backlight: Correct initial power state handling")
- added patch 7/7

v4 -> v5:
- in patch 7/7: added a comment replacing the name of the function being pulled into probe()

v5 -> v6:
- added a patch making the driver explicitly set the direction of the GPIO to output
- added a patch removing a redundant newline

v6 -> v7:
- renamed the function calculating the new GPIO value for status update
- collected more tags

Bartosz Golaszewski (9):
backlight: gpio: remove unneeded include
backlight: gpio: remove stray newline
backlight: gpio: explicitly set the direction of the GPIO
sh: ecovec24: add additional properties to the backlight device
backlight: gpio: simplify the platform data handling
sh: ecovec24: don't set unused fields in platform data
backlight: gpio: remove unused fields from platform data
backlight: gpio: use a helper variable for &pdev->dev
backlight: gpio: pull gpio_backlight_initial_power_state() into probe

 arch/sh/boards/mach-ecovec24/setup.c         |  33 +++--
 drivers/video/backlight/gpio_backlight.c     | 128 +++++++------------
 include/linux/platform_data/gpio_backlight.h |   3 -
 3 files changed, 69 insertions(+), 95 deletions(-)
Signature · 1 line
2.23.0