Skip to content

spi: add NPCM FIU controller driver

Tomer Maimon linux-devicetree linux-spi lkml openbmc 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 13 repliesSuperseded
  3. v12 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-binding: spi: add NPCM FIU controllerDocumentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt+47 -01 reply
2/2spi: npcm-fiu: add NPCM FIU controller driverdrivers/spi/Kconfig drivers/spi/Makefile drivers/spi/spi-npcm-fiu.c+782 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] spi: add NPCM FIU controller driver

This patch set adds Flash Interface Unit(FIU) SPI master support for the Nuvoton NPCM Baseboard Management Controller (BMC).

The FIU supports single, dual or quad communication interface.

the FIU controller can operate in following modes:
- User Mode Access(UMA): provides flash access by using an indirect address/data mechanism.
- direct rd/wr mode: maps the flash memory into the core address space.
- SPI-X mode: used for an expansion bus to an ASIC or CPLD.

The NPCM750/730/715/710 supports up to three FIU devices:
- FIU0 supports two chip select.
- FIU3 supports four chip select.
- FIUX supports two chip select.

The NPCM FIU driver tested on NPCM750 evaluation board.

The FIU controller driver using direct map API SPI-MEM interface and tested with the latest m25p80 driver patch
https://www.spinics.net/lists/linux-mtd/msg07358.html

According a conversion about direct SPI-MEM API
https://www.spinics.net/lists/linux-mtd/msg08225.html

The m25p80 driver will merge to the spi-nor driver we need to make sure the m25p80 direct SPI-MEM will merge as well.

The FIU controller driver tested with the latest spi-nor driver patch
https://www.spinics.net/lists/linux-mtd/msg08472.html

Addressed comments from:
- Mark Brown: https://www.spinics.net/lists/linux-spi/msg18166.html
- Boris Brezillon: https://www.spinics.net/lists/linux-spi/msg18176.html
- Rob Herring: https://www.spinics.net/lists/linux-spi/msg18289.html

Changes since version 2:
- Remove unnecessary dev_info probe print.
- Support address SPI memory operation.
- Limit address size support.
- Add vendor prefix to spi-mode property dt-binding documentation.

Changes since version 1:
- Support spi-mem no data transferred option (SPI_MEM_NO_DATA)

Tomer Maimon (2):
dt-binding: spi: add NPCM FIU controller
spi: npcm-fiu: add NPCM FIU controller driver

 .../bindings/spi/nuvoton,npcm-fiu.txt         |  47 ++
 drivers/spi/Kconfig                           |  10 +
 drivers/spi/Makefile                          |   1 +
 drivers/spi/spi-npcm-fiu.c                    | 771 ++++++++++++++++++
 4 files changed, 829 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/spi/nuvoton,npcm-fiu.txt
 create mode 100644 drivers/spi/spi-npcm-fiu.c
Signature · 1 line
2.18.0