Skip to content

drm/bridge: dw-hdmi: implement bus-format negotiation and YUV420 support

Neil Armstrong dri-devel linux-amlogic lkml 5 versions – Applied

Status from this message: Pushed to drm-misc-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest11 patches 1 replyApplied
  2. v411 patches 29 repliesSuperseded
  3. v310 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC8 patches4 repliesSuperseded
v1 RFC11 patches2 repliesSuperseded

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/11drm/bridge: dw-hdmi: set mtmdsclock for deep colordrivers/gpu/drm/bridge/synopsys/dw-hdmi.c+20 -10 replies
2/11drm/bridge: dw-hdmi: add max bpc connector propertydrivers/gpu/drm/bridge/synopsys/dw-hdmi.c+8 -00 replies
3/11drm/bridge: dw-hdmi: Plug atomic state hooks to the default implementationdrivers/gpu/drm/bridge/synopsys/dw-hdmi.c+3 -00 replies
4/11drm/bridge: synopsys: dw-hdmi: add bus format negociationdrivers/gpu/drm/bridge/synopsys/dw-hdmi.c+277 -40 replies
5/11drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200adrivers/gpu/drm/bridge/synopsys/dw-hdmi.c include/drm/bridge/dw_hdmi.h+7 -00 replies
6/11drm/meson: venc: make drm_display_mode constdrivers/gpu/drm/meson/meson_venc.c drivers/gpu/drm/meson/meson_venc.h+2 -20 replies
7/11drm/meson: meson_dw_hdmi: add bridge and switch to drm_bridge_funcsdrivers/gpu/drm/meson/meson_dw_hdmi.c+65 -200 replies
8/11drm/meson: dw-hdmi: stop enforcing input_bus_formatdrivers/gpu/drm/meson/meson_dw_hdmi.c+0 -10 replies
9/11drm/meson: venc: add support for YUV420 setupdrivers/gpu/drm/meson/meson_dw_hdmi.c drivers/gpu/drm/meson/meson_venc.c drivers/gpu/drm/meson/meson_venc.h+9 -40 replies
10/11drm/meson: vclk: add support for YUV420 setupdrivers/gpu/drm/meson/meson_dw_hdmi.c drivers/gpu/drm/meson/meson_vclk.c drivers/gpu/drm/meson/meson_vclk.h +1 more+95 -350 replies
11/11drm/meson: Add YUV420 output supportdrivers/gpu/drm/meson/meson_dw_hdmi.c+70 -210 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchJernej ŠkrabecLaurent PinchartBoris BrezillonAndrzej Hajda
1/11R-b
2/11R-b R-b
3/11R-b R-b R-b
4/11R-b R-b
5/11R-b R-b R-b
6/11R-b A-b R-b
7/11R-b
8/11R-b R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 00/11] drm/bridge: dw-hdmi: implement bus-format negotiation and YUV420 support

Hi Philippe, Heiko, Maxime, Laurent,

A bad negociation was detected on platforms not implementing a bridge on the encoder side, which has been fixed in this version.

Could you check it doesn't break your platforms using dw-hdmi ? Especially patches 1-5.

Thanks,
Neil

This patchset is based on Boris's merged "drm: Add support for bus-format negotiation" patchset to implement full bus-format negotiation for DW-HDMI, including YUV420 support and 10/12/16bit YUV444, YUV422 and RGB. The Color Space Converter support is already implemented.

And the counterpart implementation in the Amlogic Meson VPU dw-hdmi glue :
- basic bus-format negotiation to select YUV444 bus-format as DW-HDMI input
- YUV420 support when HDMI2.0 YUV420 modeset

This is a follow-up from the previous attempts :
- "drm/meson: Add support for HDMI2.0 YUV420 4k60" at [2]
- "drm/meson: Add support for HDMI2.0 4k60" at [3]

Changes since v4 at [7]:
- Cleaned up patch 1
- Added comment on patch 2
- Added commit message on patch 3
- Fixed invalid negociation when encoder is not yet a bridge (seen on allwinner & rockchip platforms) on patch 4
- Fixed invalid defines, handled MEDIA_BUS_FMT_FIXED and cleaned negociation debug on patch 4
- Added tags on patch 5, 6
- Removed meson_venc_hdmi_encoder_get_out_bus_fmts on patch 7
- Add off-list r-b from Jernej

Changes since v3 at [6]:
- Added "Plug atomic state hooks to the default implementation" on drm/bridge: dw-hdmi
- Also added these atomic state hooks in meson-dw-hdmi in patch 7
- Rebased on latest drm-misc-next including patches 1-7 of [1]

Changes since RFC v2 at [5]:
- Added fixes from Jonas, who tested and integrated it for Rockchip SoCs
- Added support for 10/12/16bit tmds clock calculation
- Added support for max_bcp connector property
- Adapted to Boris's v4 patchset
- Fixed typos reported by boris

Changes since RFC v1 at [4]:
- Rewrote negociation using the v2 patchset, including full DW-HDMI fmt negociation

[2] https://patchwork.freedesktop.org/patch/msgid/[email protected]
[3] https://patchwork.freedesktop.org/patch/msgid/[email protected]
[4] https://patchwork.freedesktop.org/patch/msgid/[email protected]
[5] https://patchwork.freedesktop.org/patch/msgid/[email protected]
[6] https://patchwork.freedesktop.org/patch/msgid/[email protected]
[7] https://patchwork.freedesktop.org/patch/msgid/[email protected]

Jonas Karlman (2):
drm/bridge: dw-hdmi: set mtmdsclock for deep color drm/bridge: dw-hdmi: add max bpc connector property

Neil Armstrong (9):
drm/bridge: dw-hdmi: Plug atomic state hooks to the default
implementation
drm/bridge: synopsys: dw-hdmi: add bus format negociation drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a drm/meson: venc: make drm_display_mode const
drm/meson: meson_dw_hdmi: add bridge and switch to drm_bridge_funcs drm/meson: dw-hdmi: stop enforcing input_bus_format drm/meson: venc: add support for YUV420 setup
drm/meson: vclk: add support for YUV420 setup
drm/meson: Add YUV420 output support

 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 319 +++++++++++++++++++++-
 drivers/gpu/drm/meson/meson_dw_hdmi.c     | 180 +++++++++---
 drivers/gpu/drm/meson/meson_vclk.c        |  93 +++++--
 drivers/gpu/drm/meson/meson_vclk.h        |   7 +-
 drivers/gpu/drm/meson/meson_venc.c        |  10 +-
 drivers/gpu/drm/meson/meson_venc.h        |   4 +-
 drivers/gpu/drm/meson/meson_venc_cvbs.c   |   6 +-
 include/drm/bridge/dw_hdmi.h              |   1 +
 8 files changed, 544 insertions(+), 76 deletions(-)
Signature · 6 lines
2.22.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel