RFC Fix PHYLINK handling of ethtool ksettings with no PHY
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest1 patch 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | phylink: Set speed to SPEED_UNKNOWN when there is no PHY connecteddrivers/ | +1 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/1] Fix PHYLINK handling of ethtool ksettings with no PHY
Logically speaking, this patch pertains to the "Fix issues in tc-taprio and tc-cbs" series at:
https://patchwork.ozlabs.org/project/netdev/list/?series=127821&state=*
The reason why I did not submit this patch together with those is that I don't know whether the error condition can happen in current mainline Linux at the moment. I am running Arseny's RFC patch "gianfar: convert to phylink" and have found that __ethtool_get_link_ksettings returns a speed of 0 instead of SPEED_UNKNOWN when there is no PHY connected.
Gianfar has carried this oddity over from its PHYLIB days, where it connects "late" to the PHY. I am not sure whether PHYLINK, gianfar, or both, need to be changed. Comments welcome.
Vladimir Oltean (1):
phylink: Set speed to SPEED_UNKNOWN when there is no PHY connected
drivers/net/phy/phylink.c | 1 + 1 file changed, 1 insertion(+)
Signature · 1 line
2.17.1