Skip to content

Non-urgent fixes and improvments for omap3-rom-rng

Tony Lindgren linux-crypto linux-devicetree linux-omap lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 5 repliesIn review
  2. v16 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Use clk_prepare_enable() as pointed out by Sebastian
- Simplify runtime PM changes patch
- Add a new patch for devm changes as suggested by Sebastian

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS devicearch/arm/mach-omap2/pdata-quirks.c+1 -10 replies
2/7hwrng: omap3-rom - Fix missing clock by probing with device treeDocumentation/devicetree/bindings/rng/omap3_rom_rng.txt arch/arm/boot/dts/omap3-n900.dts arch/arm/mach-omap2/pdata-quirks.c +1 more+49 -131 reply
3/7hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not idleddrivers/char/hw_random/omap3-rom-rng.c+2 -10 replies
4/7hwrng: omap3-rom - Initialize default quality to get datadrivers/char/hw_random/omap3-rom-rng.c+1 -00 replies
5/7hwrng: omap3-rom - Update to use standard driver datadrivers/char/hw_random/omap3-rom-rng.c+30 -150 replies
6/7hwrng: omap3-rom - Use runtime PM instead of custom functionsdrivers/char/hw_random/omap3-rom-rng.c+73 -530 replies
7/7hwrng: omap3-rom - Use devm hwrng and runtime PMdrivers/char/hw_random/omap3-rom-rng.c+16 -260 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTero KristoSebastian ReichelAaro KoskinenRob Herring
SeriesR-b R-b T-b
1/7
2/7A-b
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCHv2 0/7] Non-urgent fixes and improvments for omap3-rom-rng

Hi all,

Here are fixes and improvments for omap3-rom-rng that's been broken for a while.

The first four patches get it working, and then the last two patches add support for runtime PM.

I did not add Sebastian's acks from v1 set as many of the patches changed. Please review again :)

Regards,

Tony

Changes since v1:
- Use clk_prepare_enable() as pointed out by Sebastian
- Simplify runtime PM changes patch
- Add a new patch for devm changes as suggested by Sebastian

Tony Lindgren (7):
ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device
hwrng: omap3-rom - Fix missing clock by probing with device tree
hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not
idled
hwrng: omap3-rom - Initialize default quality to get data
hwrng: omap3-rom - Update to use standard driver data
hwrng: omap3-rom - Use runtime PM instead of custom functions
hwrng: omap3-rom - Use devm hwrng and runtime PM

 .../devicetree/bindings/rng/omap3_rom_rng.txt |  27 +++
 arch/arm/boot/dts/omap3-n900.dts              |   6 +
 arch/arm/mach-omap2/pdata-quirks.c            |  14 +-
 drivers/char/hw_random/omap3-rom-rng.c        | 168 +++++++++++-------
 4 files changed, 139 insertions(+), 76 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/rng/omap3_rom_rng.txt
Signature · 1 line
2.23.0