Skip to content

hw: Convert various reset() handler to DeviceReset

Philippe Mathieu-Daudé qemu-arm qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 2 repliesIn review
  2. v28 patches 15 repliesSuperseded
  3. v111 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Fixed PIIX_IDE conversion (Li)
- Added more R-b tag.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8hw/acpi/piix4: Convert reset handler to DeviceResethw/acpi/piix4.c+3 -40 replies
2/8hw/isa/piix4: Convert reset handler to DeviceResethw/isa/piix4.c+3 -40 replies
3/8hw/ide/piix: Convert reset handler to DeviceResethw/ide/piix.c+4 -51 reply
4/8hw/ide/sii3112: Convert reset handler to DeviceResethw/ide/sii3112.c+3 -40 replies
5/8hw/ide/via82c: Convert reset handler to DeviceResethw/ide/via.c+4 -60 replies
6/8hw/isa/vt82c686: Convert reset handler to DeviceResethw/isa/vt82c686.c+4 -70 replies
7/8hw/input/lm832x: Convert reset handler to DeviceResethw/input/lm832x.c+5 -70 replies
8/8hw/misc/vmcoreinfo: Add comment about reset handlerhw/misc/vmcoreinfo.c+4 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchIgor MammedovLi QiangMichael S. TsirkinMarc-André Lureau
1/8R-b R-b R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] hw: Convert various reset() handler to DeviceReset

Only patch 3/8 is missing review:
- hw/ide/piix: Convert reset handler to DeviceReset

Since v2:
- Fixed PIIX_IDE conversion (Li)
- Added more R-b tag.

Since v1:
- Removed the pci-host devices
- Removed the vmcoreinfo conversion (elmarco) but add a comment.
- Added Igor's R-b tag.

Following the thread discussion between Peter/Markus/Damien about reset handlers:
https://www.mail-archive.com/[email protected]/msg617103.html
I started to remove qemu_register_reset() calls from few qdevified devices (the trivial ones).

Regards,

Phil.

v2: https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg01677.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg06367.html

Philippe Mathieu-Daudé (8):
hw/acpi/piix4: Convert reset handler to DeviceReset hw/isa/piix4: Convert reset handler to DeviceReset hw/ide/piix: Convert reset handler to DeviceReset hw/ide/sii3112: Convert reset handler to DeviceReset hw/ide/via82c: Convert reset handler to DeviceReset hw/isa/vt82c686: Convert reset handler to DeviceReset hw/input/lm832x: Convert reset handler to DeviceReset hw/misc/vmcoreinfo: Add comment about reset handler

 hw/acpi/piix4.c      |  7 +++----
 hw/ide/piix.c        |  9 ++++-----
 hw/ide/sii3112.c     |  7 +++----
 hw/ide/via.c         | 10 ++++------
 hw/input/lm832x.c    | 12 +++++-------
 hw/isa/piix4.c       |  7 +++----
 hw/isa/vt82c686.c    | 11 ++++-------
 hw/misc/vmcoreinfo.c |  4 ++++
 8 files changed, 30 insertions(+), 37 deletions(-)
Signature · 1 line
2.21.0