Skip to content

scsi: remove legacy cmd_list implementation

Hannes Reinecke linux-scsi 8 versions – Applied

Status from this message: Applied to 5.7/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest13 patches 1 replyApplied
  2. v713 patches 14 repliesSuperseded
  3. v613 patches 7 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v511 patches18 repliesSuperseded
v49 patches9 repliesSuperseded
v35 patches3 repliesSuperseded
v24 patches5 repliesSuperseded
v14 patches3 repliesSuperseded

Changes to v1 from the cover letter

- Fixup kbuild warning

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/13dpt_i2o: rename adpt_i2o_to_scsi() to adpt_i2o_scsi_complete()drivers/scsi/dpt_i2o.c drivers/scsi/dpti.h+3 -40 replies
2/13scsi: add scsi_host_complete_all_commands() helperdrivers/scsi/hosts.c include/scsi/scsi_host.h+30 -00 replies
3/13dpt_i2o: use scsi_host_complete_all_commands() to abort outstanding commandsdrivers/scsi/dpt_i2o.c drivers/scsi/dpti.h+1 -200 replies
4/13aacraid: Do not wait for outstanding write commands on synchronize_cachedrivers/scsi/aacraid/aachba.c+2 -740 replies
5/13aacraid: use scsi_host_complete_all_commands() to terminate outstanding commandsdrivers/scsi/aacraid/commsup.c+2 -220 replies
6/13aacraid: replace aac_flush_ios() with midlayer helperdrivers/scsi/aacraid/linit.c+2 -220 replies
7/13aacraid: move scsi_(block,unblock)_requests out of _aac_reset_adapter()drivers/scsi/aacraid/commsup.c+4 -60 replies
8/13scsi: add scsi_host_(block,unblock) helper functiondrivers/scsi/scsi_lib.c include/scsi/scsi_host.h+32 -00 replies
9/13aacraid: use scsi_host_(block,unblock) to block I/Odrivers/scsi/aacraid/commsup.c drivers/scsi/aacraid/linit.c+8 -210 replies
10/13scsi: add scsi_host_busy_iter()drivers/scsi/hosts.c include/scsi/scsi_host.h+40 -00 replies
11/13aacraid: use scsi_host_busy_iter() to wait for outstanding commandsdrivers/scsi/aacraid/comminit.c+17 -180 replies
12/13aacraid: use scsi_host_busy_iter() in get_num_of_incomplete_fibs()drivers/scsi/aacraid/linit.c+41 -400 replies
13/13scsi: Remove cmd_list functionalitydrivers/scsi/scsi.c drivers/scsi/scsi_error.c drivers/scsi/scsi_lib.c +5 more+0 -530 replies

Reviews trailers per patch

11 of 13 patches have a Reviewed-by or Acked-by.

PatchBart Van AsscheChristoph HellwigBalsundar P
1/13R-b R-b
2/13
3/13R-b R-b
4/13R-b A-b
5/13R-b R-b A-b
6/13R-b R-b A-b
7/13R-b A-b
8/13R-b R-b
9/13R-b A-b
10/13
11/13R-b A-b
12/13R-b A-b
13/13R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCHv8 00/13] scsi: remove legacy cmd_list implementation

Hi all,

with the switch to blk-mq we have an efficient way of looking up outstanding commands via blk_mq_rq_busy_iter().
In this patchset the dpt_i2o and aacraid drivers are switched over to using that function, and the now obsolete cmd_list implemantation in the SCSI midlayer is removed.

As usual, comments and reviews are welcome.

Changes to v1:
- Fixup kbuild warning

Changes to v2:
- Add scsi_host_busy_iter()
- Include reviews from Christoph

Changes to v3:
- Include reviews from Christoph
- Add midlayer helper to terminate outstanding commands
- Split off aacraid modifcations into several patches

Changes to v4:
- Include reviews from Bart
- Add new midlayer helper scsi_host_quiesce()/scsi_host_resume()
- Improve comments

Changes to v5:
- Add reviews from Balsundar P.
- Rename scsi_host_flush_commands()
- Replace patch using scsi_host_quiesce() by using busy iterator

Changes to v6:
- Add reviews from Balsundar P.

Changes to v7:
- Add reviews from Christoph

Hannes Reinecke (13):
dpt_i2o: rename adpt_i2o_to_scsi() to adpt_i2o_scsi_complete()
scsi: add scsi_host_complete_all_commands() helper
dpt_i2o: use scsi_host_complete_all_commands() to abort outstanding
commands
aacraid: Do not wait for outstanding write commands on
synchronize_cache
aacraid: use scsi_host_complete_all_commands() to terminate
outstanding commands
aacraid: replace aac_flush_ios() with midlayer helper
aacraid: move scsi_(block,unblock)_requests out of
_aac_reset_adapter()
scsi: add scsi_host_(block,unblock) helper function
aacraid: use scsi_host_(block,unblock) to block I/O
scsi: add scsi_host_busy_iter()
aacraid: use scsi_host_busy_iter() to wait for outstanding commands
aacraid: use scsi_host_busy_iter() in get_num_of_incomplete_fibs()
scsi: Remove cmd_list functionality

 drivers/scsi/aacraid/aachba.c   |  76 +------------------------
 drivers/scsi/aacraid/comminit.c |  35 ++++++------
 drivers/scsi/aacraid/commsup.c  |  46 +++------------
 drivers/scsi/aacraid/linit.c    | 120 ++++++++++++++++------------------------
 drivers/scsi/dpt_i2o.c          |  25 +--------
 drivers/scsi/dpti.h             |   3 +-
 drivers/scsi/hosts.c            |  65 ++++++++++++++++++++++
 drivers/scsi/scsi.c             |  14 -----
 drivers/scsi/scsi_error.c       |   1 -
 drivers/scsi/scsi_lib.c         |  61 ++++++++++----------
 drivers/scsi/scsi_priv.h        |   2 -
 drivers/scsi/scsi_scan.c        |   1 -
 include/scsi/scsi_cmnd.h        |   1 -
 include/scsi/scsi_device.h      |   1 -
 include/scsi/scsi_host.h        |   9 ++-
 15 files changed, 181 insertions(+), 279 deletions(-)
Signature · 1 line
2.16.4