Skip to content

KVM: arm64: PMUv3 Event Counter Tests

Eric Auger kvm kvmarm qemu-arm qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 6 repliesIn review
  2. v312 patches 0 repliesSuperseded
  3. v29 patches 28 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches8 repliesSuperseded

Changes in v4 from the cover letter

- Drew reported that some report messages were repeated. This version makes sure all messages are different.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12arm64: Provide read/write_sysreg_slib/arm64/asm/sysreg.h+11 -00 replies
2/12arm: pmu: Let pmu tests take a sub-test parameterarm/pmu.c arm/unittests.cfg+20 -120 replies
3/12arm: pmu: Don't check PMCR.IMP anymorearm/pmu.c+14 -250 replies
4/12arm: pmu: Add a pmu structarm/pmu.c+21 -80 replies
5/12arm: pmu: Introduce defines for PMU versionsarm/pmu.c+21 -50 replies
6/12arm: pmu: Check Required Event Supportarm/pmu.c arm/unittests.cfg lib/bitops.h+86 -00 replies
7/12arm: pmu: Basic event counter Testsarm/pmu.c arm/unittests.cfg lib/arm64/asm/sysreg.h+272 -04 replies
8/12arm: pmu: Test SW_INCR event countarm/pmu.c arm/unittests.cfg+53 -01 reply
9/12arm: pmu: Test chained countersarm/pmu.c arm/unittests.cfg+109 -10 replies
10/12arm: pmu: test 32-bit <-> 64-bit transitionsarm/pmu.c arm/unittests.cfg+144 -01 reply
11/12arm: gic: Introduce gic_irq_set_clr_enable() helperlib/arm/asm/gic.h lib/arm/gic.c+35 -00 replies
12/12arm: pmu: Test overflow interruptsarm/pmu.c arm/unittests.cfg+145 -00 replies

Reviews trailers per patch

4 of 12 patches have a Reviewed-by or Acked-by.

PatchAlexandru EliseiAndre Przywara
1/12R-b
2/12R-b
3/12
4/12R-b
5/12
6/12
7/12R-b
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [kvm-unit-tests PATCH v4 00/12] KVM: arm64: PMUv3 Event Counter Tests

This series implements tests exercising the PMUv3 event counters. It tests both the 32-bit and 64-bit versions. Overflow interrupts also are checked. Those tests only are written for arm64.

It allowed to reveal some issues related to SW_INCR implementation (esp. related to 64-bit implementation), some problems related to 32-bit <-> 64-bit transitions and consistency of enabled states of odd and event counters. Fixes now are upstream.

Drew kindly provided "arm64: Provide read/write_sysreg_s".

All PMU tests can be launched with:
./run_tests.sh -g pmu
Tests also can be launched individually. For example:
./arm-run arm/pmu.flat -append 'pmu-chained-sw-incr'

With KVM:
- On TX2, I have some random failures due to MEM_ACCESS event measured with a great disparity. This is not observed on other machines I have access to.

The series can be found at:
https://github.com/eauger/kut/tree/pmu_event_counters_v4

History:
v3 -> v4:
- Drew reported that some report messages were repeated. This version makes sure all messages are different.

v2 -> v3:
- Took into account numerous comments from Drew
- Applied Andre's R-b when code has not changed too much
- Don't check PMCR.IMP anymore
- better handling of version
- put simple SW_INCR tests for easier TCG testing

v1 -> v2:
- Took into account Andre's comments except I did not use cnbz in the mem_access_loop() and I did not use @loop directly. Those changes had side effects I cannot explain on the tests. Anyway I think this can be improved later on.
- removed [kvm-unit-tests PATCH 09/10] arm/arm64: gic:
Introduce setup_irq() helper

RFC -> v1:
- Use new report() proto
- Style cleanup
- do not warn about ARM spec recommendations
- add a comment about PMCEID0/1 splits

Andrew Jones (1):
arm64: Provide read/write_sysreg_s

Eric Auger (11):
arm: pmu: Let pmu tests take a sub-test parameter
arm: pmu: Don't check PMCR.IMP anymore
arm: pmu: Add a pmu struct
arm: pmu: Introduce defines for PMU versions
arm: pmu: Check Required Event Support
arm: pmu: Basic event counter Tests
arm: pmu: Test SW_INCR event count
arm: pmu: Test chained counters
arm: pmu: test 32-bit <-> 64-bit transitions
arm: gic: Introduce gic_irq_set_clr_enable() helper
arm: pmu: Test overflow interrupts

 arm/pmu.c              | 838 +++++++++++++++++++++++++++++++++++++++--
 arm/unittests.cfg      |  61 ++-
 lib/arm/asm/gic.h      |   4 +
 lib/arm/gic.c          |  31 ++
 lib/arm64/asm/sysreg.h |  17 +
 lib/bitops.h           |   3 +
 6 files changed, 917 insertions(+), 37 deletions(-)
Signature · 1 line
2.20.1