chardev: Use QEMUChrEvent enum in IOEventHandler typedef
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest14 patches 13 repliesIn review
- v114 patches 6 repliesSuperseded
Changes in v2 from the cover letter
- do blindly ignore all events using a 'default' case.
Patches in v2 No applies recorded yet
Reviews trailers per patch
9 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Corey Minyard | Dr. David Alan Gilbert | Richard Henderson | Cornelia Huck | Michael S. Tsirkin | Markus Armbruster | Marc-André Lureau |
|---|---|---|---|---|---|---|---|
| Series | R-b | ||||||
| 1/14 | A-b | ||||||
| 2/14 | A-b | R-b | |||||
| 3/14 | R-b | ||||||
| 4/14 | |||||||
| 5/14 | |||||||
| 6/14 | |||||||
| 7/14 | |||||||
| 8/14 | R-b | ||||||
| 9/14 | A-b | ||||||
| 10/14 | A-b | ||||||
| 11/14 | R-b | ||||||
| 12/14 | A-b | ||||||
| 13/14 | |||||||
| 14/14 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [PATCH v2 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef
Hi,
After this chat on #qemu IRC:
13:20 <stsquad> so what is the difference between a IOReadHandler and IOEventHandler? 13:25 <f4bug> stsquad: one is in-band and the other out-of-band?
13:26 <stsquad> f4bug: ahh yes it seems so - connect/disconnect etc... 13:27 <f4bug> see QEMUChrEvent for IOEventHandler
I thought it might be a good opportunity to make the IOEventHandler typedef meaning more obvious, by using the QEMUChrEvent enum.
To be able to build I had to explicit all enums ignored in the switch(event) statement by these frontends.
Then I used a coccinelle spatch to change the various IOEventHandler. I don't think the last patch can be split, but suggestions are welcome!
Regards,
Phil.
v2:
- do blindly ignore all events using a 'default' case.
Philippe Mathieu-Daudé (14):
hw/ipmi: Remove unnecessary declarations
hw/ipmi: Explicit we ignore some QEMUChrEvent in IOEventHandler hw/char/terminal3270: Explicit ignored QEMUChrEvent in IOEventHandler hw/usb/dev-serial: Explicit we ignore few QEMUChrEvent in IOEventHandler hw/usb/redirect: Explicit we ignore few QEMUChrEvent in IOEventHandler
ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler
vhost-user-crypto: Explicit we ignore some QEMUChrEvent in IOEventHandler
vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler
vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler
virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler
chardev: Use QEMUChrEvent enum in IOEventHandler typedef
include/chardev/char-fe.h | 2 +- include/chardev/char-mux.h | 2 +- include/chardev/char.h | 4 ++-- backends/cryptodev-vhost-user.c | 7 ++++++- chardev/char-mux.c | 8 ++++---- chardev/char.c | 9 +++++++-- gdbstub.c | 2 +- hw/arm/pxa2xx.c | 2 +- hw/arm/strongarm.c | 2 +- hw/block/vhost-user-blk.c | 7 ++++++- hw/char/cadence_uart.c | 2 +- hw/char/digic-uart.c | 2 +- hw/char/escc.c | 2 +- hw/char/etraxfs_ser.c | 2 +- hw/char/exynos4210_uart.c | 2 +- hw/char/grlib_apbuart.c | 2 +- hw/char/imx_serial.c | 2 +- hw/char/ipoctal232.c | 2 +- hw/char/lm32_juart.c | 2 +- hw/char/lm32_uart.c | 2 +- hw/char/mcf_uart.c | 2 +- hw/char/milkymist-uart.c | 2 +- hw/char/nrf51_uart.c | 2 +- hw/char/pl011.c | 2 +- hw/char/serial.c | 2 +- hw/char/sh_serial.c | 2 +- hw/char/terminal3270.c | 7 ++++++- hw/char/virtio-console.c | 7 ++++++- hw/char/xilinx_uartlite.c | 2 +- hw/ipmi/ipmi_bmc_extern.c | 12 +++++++----- hw/mips/boston.c | 2 +- hw/mips/mips_malta.c | 2 +- hw/riscv/riscv_htif.c | 2 +- hw/riscv/sifive_uart.c | 2 +- hw/usb/ccid-card-passthru.c | 7 ++++++- hw/usb/dev-serial.c | 6 +++++- hw/usb/redirect.c | 7 ++++++- monitor/hmp.c | 6 +++++- monitor/qmp.c | 7 ++++++- net/filter-mirror.c | 2 +- net/vhost-user.c | 9 +++++++-- qtest.c | 2 +- tests/test-char.c | 6 +++--- tests/vhost-user-test.c | 2 +- 44 files changed, 111 insertions(+), 56 deletions(-)
Signature · 1 line
2.21.0