Skip to content

monitor: Refactoring in preparation for qemu-storage-daemon

Kevin Wolf qemu-devel 3 versions – Applied

Status from this message: Queued, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesApplied
  2. v24 patches 7 repliesSuperseded
  3. v14 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Cleaned up #include [Markus]
- Changed schema documenttion headline [Markus]
- Changes comments according to review [Markus]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4monitor: Move monitor option parsing to monitor/monitor.cinclude/monitor/monitor.h include/sysemu/sysemu.h monitor/monitor.c +1 more+52 -450 replies
2/4qapi: Create module 'control'monitor/hmp-cmds.c monitor/misc.c monitor/monitor-internal.h +8 more+229 -2173 replies
3/4monitor: Create monitor/qmp-cmds-control.cmonitor/Makefile.objs monitor/misc.c monitor/qmp-cmds-control.c +1 more+155 -1250 replies
4/4monitor: Move qmp_query_qmp_schema to qmp-cmds-control.cmonitor/misc.c monitor/monitor-internal.h monitor/qmp-cmds-control.c+19 -160 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMarkus Armbruster
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] monitor: Refactoring in preparation for qemu-storage-daemon

This series creates a QAPI module 'control' that can be used from tools outside the system emulator and moves some monitor initialisation code from vl.c to monitor code.

It is split from the series to introduce qemu-storage-daemon because these refactorings make sense on their own as cleanups.

v3:
- Cleaned up #include [Markus]
- Changed schema documenttion headline [Markus]
- Changes comments according to review [Markus]

v2:
- Removed allow_hmp parameter from monitor_init_opts() [Markus]
- Renamed monitor.json to control.json [Markus]

Kevin Wolf (4):
monitor: Move monitor option parsing to monitor/monitor.c
qapi: Create module 'control'
monitor: Create monitor/qmp-cmds-control.c
monitor: Move qmp_query_qmp_schema to qmp-cmds-control.c

 qapi/control.json          | 218 +++++++++++++++++++++++++++++++++++++
 qapi/misc.json             | 212 ------------------------------------
 qapi/qapi-schema.json      |   1 +
 include/monitor/monitor.h  |   3 +
 include/sysemu/sysemu.h    |   1 -
 monitor/monitor-internal.h |   4 +
 monitor/hmp-cmds.c         |   1 +
 monitor/misc.c             | 127 +--------------------
 monitor/monitor.c          |  48 ++++++++
 monitor/qmp-cmds-control.c | 169 ++++++++++++++++++++++++++++
 monitor/qmp-cmds.c         |  15 +--
 monitor/qmp.c              |   2 +-
 tests/qtest/qmp-test.c     |   2 +-
 ui/gtk.c                   |   1 +
 vl.c                       |  45 +-------
 monitor/Makefile.objs      |   3 +-
 qapi/Makefile.objs         |   6 +-
 17 files changed, 455 insertions(+), 403 deletions(-)
 create mode 100644 qapi/control.json
 create mode 100644 monitor/qmp-cmds-control.c
Signature · 1 line
2.20.1