Skip to content

perf tools: add support for libpfm4

Ian Rogers bpf linux-perf-users lkml netdev 16 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v14 Latest1 patch 5 repliesIn review
  2. v134 patches 0 repliesSuperseded
  3. v124 patches 3 repliesApplied
Earlier versions · 13
VersionPostedPatchesRepliesStatus
v114 patches1 replySuperseded
v104 patches1 replyApplied
v9 posting 3/34 patches6 repliesSuperseded
v9 posting 2/34 patches0 repliesSuperseded
v9 posting 1/34 patches0 repliesSuperseded
v84 patches3 repliesSuperseded
v71 patch3 repliesSuperseded
v61 patch2 repliesSuperseded
v51 patch9 repliesSuperseded
v41 patch2 repliesSuperseded
v31 patch2 repliesSuperseded
v21 patch0 repliesSuperseded
v11 patch6 repliesSuperseded

Patches in v14 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1perf tools: add support for libpfm4tools/perf/Documentation/perf-record.txt tools/perf/Documentation/perf-stat.txt tools/perf/Documentation/perf-top.txt +16 more+630 -85 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchIan Rogers
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v14 thread

Cover letter [PATCH v14 0/1] perf tools: add support for libpfm4

This patch links perf with the libpfm4 library if it is available and LIBPFM4 is passed to the build. The libpfm4 library contains hardware event tables for all processors supported by perf_events. It is a helper library that helps convert from a symbolic event name to the event encoding required by the underlying kernel interface. This library is open-source and available from: http://perfmon2.sf.net.

With this patch, it is possible to specify full hardware events by name. Hardware filters are also supported. Events must be specified via the --pfm-events and not -e option. Both options are active at the same time and it is possible to mix and match:

$ perf stat --pfm-events inst_retired:any_p:c=1:i -e cycles ....

v14 rebases now patches 1 to 3 are merged.
v13 moves libpfm_initialize purely into pfm.c as suggested by
[email protected].
v12 changes NO_LIBPFM4 as a make option to LIBPFM4, ie opt-in rather
than opt-out of feature detection and build support. Suggested by [email protected]. It also moves passing the ASCIIDOC_EXTRA argument into its own commit.
v11 reformats the perf list output.
v10 addresses review comments from [email protected].
v9 removes some unnecessary #ifs.
v8 addresses review comments from [email protected].
Breaks the patch into 4, adds a test and moves the libpfm code into its own file. perf list encoding tries to be closer to existing.
v7 rebases and adds fallback code for libpfm4 events.
The fallback code is to force user only priv level in case the perf_event_open() syscall failed for permissions reason. the fallback forces a user privilege level restriction on the event string, so depending on the syntax either u or :u is needed.

But libpfm4 can use a : or . as the separator, so simply searching for ':' vs. '/' is not good enough to determine the syntax needed. Therefore, this patch introduces a new evsel boolean field to mark events coming from libpfm4. The field is then used to adjust the fallback string.
v6 was a rebase.
v5 was a rebase.
v4 was a rebase on
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
branch perf/core and re-adds the tools/build/feature/test-libpfm4.c missed in v3.
v3 is against acme/perf/core and removes a diagnostic warning. v2 of this patch makes the --pfm-events man page documentation
conditional on libpfm4 behing configured. It tidies some of the documentation and adds the feature test missed in the v1 patch.

Stephane Eranian (1):
perf tools: add support for libpfm4

 tools/perf/Documentation/perf-record.txt |  11 +
 tools/perf/Documentation/perf-stat.txt   |  10 +
 tools/perf/Documentation/perf-top.txt    |  11 +
 tools/perf/Makefile.config               |  13 ++
 tools/perf/Makefile.perf                 |   2 +
 tools/perf/builtin-record.c              |   6 +
 tools/perf/builtin-stat.c                |   6 +
 tools/perf/builtin-top.c                 |   6 +
 tools/perf/tests/Build                   |   1 +
 tools/perf/tests/builtin-test.c          |   9 +
 tools/perf/tests/pfm.c                   | 203 ++++++++++++++++
 tools/perf/tests/tests.h                 |   3 +
 tools/perf/util/Build                    |   2 +
 tools/perf/util/evsel.c                  |   2 +-
 tools/perf/util/evsel.h                  |   1 +
 tools/perf/util/parse-events.c           |  30 ++-
 tools/perf/util/parse-events.h           |   4 +
 tools/perf/util/pfm.c                    | 281 +++++++++++++++++++++++
 tools/perf/util/pfm.h                    |  37 +++
 19 files changed, 630 insertions(+), 8 deletions(-)
 create mode 100644 tools/perf/tests/pfm.c
 create mode 100644 tools/perf/util/pfm.c
 create mode 100644 tools/perf/util/pfm.h
Signature · 1 line
2.26.2.526.g744177e7f7-goog