Add battery charger driver support for MP2629
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v12 Latest6 patches 4 repliesIn review
- v116 patches 7 repliesSuperseded
- v106 patches 11 repliesSuperseded
Earlier versions · 9
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v9 | 6 patches | 18 replies | Superseded | |
| v8 | 6 patches | 6 replies | Superseded | |
| v7 | 5 patches | 5 replies | Superseded | |
| v6 | 5 patches | 2 replies | Superseded | |
| v5 | 5 patches | 11 replies | Superseded | |
| v4 | 5 patches | 22 replies | Superseded | |
| v3 | 5 patches | 0 replies | Superseded | |
| v2 | 5 patches | 7 replies | Superseded | |
| v1 | 5 patches | 4 replies | Superseded |
Changes in v12 from the cover letter
- added SOB Acked-for-MFD-by: Lee Jones <[email protected]>
Patches in v12 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | dt-bindings: mfd: add document bindings for mp2629Documentation/ | +62 | 0 replies | |
| 2/6 | mfd: mp2629: Add support for mps battery chargerdrivers/ drivers/ drivers/ +1 more | +107 | 0 replies | |
| 3/6 | iio: adc: mp2629: Add support for mp2629 ADC driverdrivers/ drivers/ drivers/ +1 more | +228 | 0 replies | |
| 4/6 | power: supply: Add support for mps mp2629 battery chargerdrivers/ drivers/ drivers/ | +680 | 0 replies | |
| 5/6 | power: supply: mp2629: Add impedance compensation configDocumentation/ | +8 | 0 replies | |
| 6/6 | MAINTAINERS: Add entry for mp2629 Battery Charger driverMAINTAINERS | +5 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Andy Shevchenko | Rob Herring | Lee Jones | Jonathan Cameron | Sebastian Reichel |
|---|---|---|---|---|---|
| Series | R-b | ||||
| 1/6 | R-b | R-b | Acked-for-MFD-by | ||
| 2/6 | R-b | Acked-for-MFD-by | R-b | ||
| 3/6 | R-b | Acked-for-MFD-by | R-b | ||
| 4/6 | R-b | Acked-for-MFD-by | R-b | ||
| 5/6 | R-b | Acked-for-MFD-by | R-b | ||
| 6/6 | R-b | Acked-for-MFD-by | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v12 0/6] Add battery charger driver support for MP2629
changes in v12:
- added SOB Acked-for-MFD-by: Lee Jones <[email protected]>
changes in v11:
- module_remove part replaced by devm_add_action_or_reset in charger patch
- minor review comments solved in mfd and adc patch
I expect, that Lee will provide an immutable branch for me and Jonathan once the MFD bits have been reviewed. Please tell me, if I should prepare one instead.
-- Sebastian
changes in v10:
- fixed typo, \n in dev_err
- dt bindings Warning (unit_address_vs_reg) reported by bot
changes in v9:
- fixed review comments in mp2629 power supply such as resource based iio channel, replace workqueue by threaded irq, irq get with "_optional"
changes in v8:
- fixed order of call in probe/remove in iio adc
- add ABI documentation for mp2629 power supply
changes in v7:
- fixed probe/remove order, managed and unmanaged call mix use in adc.
- Documentation dual license, i2c node with controller address
Overall looks good to me, FWIW,
One question though in reply to patch 4.
changes in v6:
- removed includes types.h in mfd, of_device.h in adc.
- fixed review comments parentheses, err check, kstrtouint
changes in v5:
- removed platfrom data stored in mfd and directly accessed mfd struct in child
- fixed spell check and capitalization in mfd and documentation
changes in v4:
- fixed capitalization in mfg Kconfig and documentation
changes in v3:
- regmap for children passed using platform data and remove mfd driver info access directly from children
changes in v2:
- removed EXPORT_SYMBOL of register set/get helper
- regmap bit filed used, fixed other review comments
This patch series add support for Battery charger control driver for Monolithic Power System's MP2629 chipset, includes MFD driver for ADC battery & input power supply measurement and battery charger control driver.
Thanks,
Saravanan
Saravanan Sekar (6):
dt-bindings: mfd: add document bindings for mp2629
mfd: mp2629: Add support for mps battery charger
iio: adc: mp2629: Add support for mp2629 ADC driver
power: supply: Add support for mps mp2629 battery charger
power: supply: mp2629: Add impedance compensation config
MAINTAINERS: Add entry for mp2629 Battery Charger driver
.../ABI/testing/sysfs-class-power-mp2629 | 8 + .../devicetree/bindings/mfd/mps,mp2629.yaml | 62 ++ MAINTAINERS | 5 + drivers/iio/adc/Kconfig | 10 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/mp2629_adc.c | 208 ++++++ drivers/mfd/Kconfig | 9 + drivers/mfd/Makefile | 2 + drivers/mfd/mp2629.c | 79 +++ drivers/power/supply/Kconfig | 10 + drivers/power/supply/Makefile | 1 + drivers/power/supply/mp2629_charger.c | 669 ++++++++++++++++++ include/linux/mfd/mp2629.h | 26 + 13 files changed, 1090 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-power-mp2629 create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml create mode 100644 drivers/iio/adc/mp2629_adc.c create mode 100644 drivers/mfd/mp2629.c create mode 100644 drivers/power/supply/mp2629_charger.c create mode 100644 include/linux/mfd/mp2629.h
Signature · 1 line
2.17.1