Skip to content

user-mode: Prune build dependencies (part 2)

Philippe Mathieu-Daudé qemu-devel 11 versions – Applied

Status from this message: Queued, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 posting 3/31 patch 2 repliesIn review
  2. v3 posting 3/311 patches 12 repliesSuperseded
  3. v5 Latest8 patches 12 repliesApplied
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v4 posting 2/39 patches5 repliesSuperseded
v3 posting 2/39 patches20 repliesSuperseded
v4 posting 1/313 patches3 repliesSuperseded
v3 posting 1/312 patches6 repliesSuperseded
v2 posting 3/39 patches3 repliesSuperseded
v2 posting 2/38 patches17 repliesSuperseded
v2 posting 1/312 patches5 repliesSuperseded
v19 patches13 repliesSuperseded

Changes in v5 from the cover letter

- Rebased on "QOM boilerplate cleanup"
- Dropped patch #1 "target/i386: Restrict X86CPUFeatureWord"
- Added Paolo's A-b tag

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/8qapi: Restrict LostTickPolicy enum to machine codehw/core/qdev-properties.c hw/i386/kvm/i8254.c include/hw/rtc/mc146818rtc.h +2 more+35 -343 replies
2/8qapi: Correct balloon documentationqapi/misc.json+10 -30 replies
3/8qapi: Restrict balloon-related commands to machine codehw/virtio/virtio-balloon.c include/sysemu/balloon.h monitor/hmp-cmds.c +3 more+94 -936 replies
4/8qapi: Restrict query-vm-generation-id command to machine codehw/acpi/vmgenid.c qapi/machine.json qapi/misc.json +1 more+22 -230 replies
5/8qapi: Restrict query-uuid command to machine codeblock/iscsi.c qapi/machine.json qapi/misc.json +1 more+32 -320 replies
6/8qapi: Restrict device memory commands to machine codehw/acpi/memory_hotplug.c hw/virtio/virtio-mem-pci.c include/hw/mem/memory-device.h +3 more+220 -2190 replies
7/8qapi: Extract ACPI commands to 'acpi.json'MAINTAINERS hw/acpi/core.c hw/acpi/cpu.c +7 more+149 -1350 replies
8/8qapi: Extract PCI commands to 'pci.json'MAINTAINERS hw/pci/pci-stub.c hw/pci/pci.c +5 more+322 -3080 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarkus ArmbrusterPaolo BonziniDavid HildenbrandIgor Mammedov
SeriesA-b
1/8A-b A-b
2/8A-b R-b
3/8A-b A-b R-b
4/8A-b A-b A-b
5/8A-b A-b
6/8A-b A-b
7/8A-b A-b A-b
8/8A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/8] user-mode: Prune build dependencies (part 2)

This is the second part of a series reducing user-mode dependencies. By stripping out unused code, the build and testing time is reduced (as is space used by objects).

Series is fully Acked.

Part 2:
- Extract code not related to user-mode from qapi/misc.json

Since v4:
- Rebased on "QOM boilerplate cleanup"
- Dropped patch #1 "target/i386: Restrict X86CPUFeatureWord"
- Added Paolo's A-b tag

Since v3:
- Rebased (Meson)
- Addressed Markus comments:
- Use g_assert_not_reached() in stub
- Add commit descriptions
- Extract ACPI / PCI
- MEMORY not extracted as no feedback from Igor/MST

Since v2:
- Addressed Igor review comments (move query-uuid to machine)
- Addressed David review comments (fix balloon documentation)

Since v1:
- Do not extract the 'add_client' command (elmarco)

CI:
https://gitlab.com/philmd/qemu/-/pipelines/189374631

Philippe Mathieu-Daudé (8):
qapi: Restrict LostTickPolicy enum to machine code
qapi: Correct balloon documentation
qapi: Restrict balloon-related commands to machine code
qapi: Restrict query-vm-generation-id command to machine code
qapi: Restrict query-uuid command to machine code
qapi: Restrict device memory commands to machine code
qapi: Extract ACPI commands to 'acpi.json'
qapi: Extract PCI commands to 'pci.json'

 qapi/acpi.json                       | 141 +++++
 qapi/machine.json                    | 388 +++++++++++++
 qapi/misc.json                       | 820 ---------------------------
 qapi/pci.json                        | 316 +++++++++++
 qapi/qapi-schema.json                |   2 +
 include/hw/acpi/acpi_dev_interface.h |   2 +-
 include/hw/mem/memory-device.h       |   2 +-
 include/hw/rtc/mc146818rtc.h         |   2 +-
 include/hw/virtio/virtio-pmem.h      |   2 +-
 include/sysemu/balloon.h             |   2 +-
 block/iscsi.c                        |   2 +-
 hw/acpi/core.c                       |   2 +-
 hw/acpi/cpu.c                        |   2 +-
 hw/acpi/memory_hotplug.c             |   3 +-
 hw/acpi/vmgenid.c                    |   2 +-
 hw/core/qdev-properties.c            |   1 +
 hw/i386/kvm/i8254.c                  |   2 +-
 hw/pci/pci-stub.c                    |   2 +-
 hw/pci/pci.c                         |   2 +-
 hw/virtio/virtio-balloon.c           |   2 +-
 hw/virtio/virtio-mem-pci.c           |   1 +
 monitor/hmp-cmds.c                   |   2 +
 monitor/qmp-cmds.c                   |   1 +
 softmmu/balloon.c                    |   2 +-
 stubs/uuid.c                         |   2 +-
 stubs/vmgenid.c                      |   2 +-
 MAINTAINERS                          |   2 +
 qapi/meson.build                     |   2 +
 28 files changed, 874 insertions(+), 837 deletions(-)
 create mode 100644 qapi/acpi.json
 create mode 100644 qapi/pci.json
Signature · 1 line
2.26.2