Fixes for GCC 10's -fcommon default
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf externlib/ lib/ | +5 | 1 reply | |
| 2/4 | lib/rendercopy_gen*: Make cc/viewport staticlib/ lib/ | +4 | 1 reply | |
| 3/4 | assembler/gen4asm.h: Make struct src_operand externassembler/ | +1 | 6 replies | |
| 4/4 | meson: Add -fcommon to cc_flagsmeson.build | +1 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Chris Wilson | Petri Latvala |
|---|---|---|
| 1/4 | R-b | |
| 2/4 | R-b | |
| 3/4 | R-b | |
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [igt-dev] [PATCH i-g-t 0/4] Fixes for GCC 10's -fcommon default
From: Lyude Paul <[email protected]>
It appears that since GCC 10, -fcommon has become the default over the previous -fno-common causing igt builds to fail by default. Likewise, we've also started setting -fcommon by default when building RPMs in Fedora (likewise, this has broken igt-gpu-tools builds for a while and I'm only just now getting to fixing it). So, let's fix the issues this introduced and make -fcommon the default in igt as well to prevent breakages from this in the future.
Lyude Paul (4):
lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern lib/rendercopy_gen*: Make cc/viewport static assembler/gen4asm.h: Make struct src_operand extern
meson: Add -fcommon to cc_flags
assembler/gen4asm.h | 2 +- lib/igt_core.c | 3 +++ lib/igt_core.h | 4 ++-- lib/rendercopy_gen8.c | 4 ++-- lib/rendercopy_gen9.c | 4 ++-- meson.build | 1 + 6 files changed, 11 insertions(+), 7 deletions(-)
Signature · 6 lines
2.24.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev