Skip to contentSkip to conversation

Fixes for GCC 10's -fcommon default

PATCH In review Lyude 4 participants 17 messages Mar 16, 2020 – Mar 20, 2020

Subsystems (2)
Library code Arm/Amlogic Meson SoC support
lore
Share & tools
lore

Lyude

author
#0 lore raw

cover Fixes for GCC 10's -fcommon default

From: Lyude Paul <[email protected]>

It appears that since GCC 10, -fcommon has become the default over the previous -fno-common causing igt builds to fail by default. Likewise, we've also started setting -fcommon by default when building RPMs in Fedora (likewise, this has broken igt-gpu-tools builds for a while and I'm only just now getting to fixing it). So, let's fix the issues this introduced and make -fcommon the default in igt as well to prevent breakages from this in the future.

Lyude Paul (4):
lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern lib/rendercopy_gen*: Make cc/viewport static assembler/gen4asm.h: Make struct src_operand extern
meson: Add -fcommon to cc_flags

 assembler/gen4asm.h   | 2 +-
 lib/igt_core.c        | 3 +++
 lib/igt_core.h        | 4 ++--
 lib/rendercopy_gen8.c | 4 ++--
 lib/rendercopy_gen9.c | 4 ++--
 meson.build           | 1 +
 6 files changed, 11 insertions(+), 7 deletions(-)
Signature · 6 lines
2.24.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#1 lore raw

PATCH 1/4 lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern

From: Lyude Paul <[email protected]>

Since gcc 10, -fno-common has become the default (vs. -fcommon). As a result, gcc is much stricter about missing extern and static keywords and causes our build to fail in anything including igt_core.h:

/usr/bin/ld:
lib/libigt-i915_gem_context_c.a(i915_gem_context.c.o):lib/igt_core.h:149:
multiple definition of `igt_dynamic_jmpbuf'; lib/libigt-drmtest_c.a(drmtest.c.o):lib/igt_core.h:149: first defined here
/usr/bin/ld:
lib/libigt-i915_gem_context_c.a(i915_gem_context.c.o):lib/igt_core.h:148:
multiple definition of `igt_subtest_jmpbuf'; lib/libigt-drmtest_c.a(drmtest.c.o):lib/igt_core.h:148: first defined here

So, fix this by marking these as extern and declaring them in lib/igt_core.c.

Signed-off-by Lyude Paul <[email protected]>
---
 lib/igt_core.c | 3 +++
 lib/igt_core.h | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)
lib/igt_core.c +3 -0
index 51041793..2b928f1a 100644
@@ -261,6 +261,9 @@
  * such as those related to Chamelium support.
  */
 
+jmp_buf igt_subtest_jmpbuf;
+jmp_buf igt_dynamic_jmpbuf;
+
 static unsigned int exit_handler_count;
 const char *igt_interactive_debug;
 bool igt_skip_crc_compare;
lib/igt_core.h +2 -2
index c17a7ba8..fae5f59e 100644
@@ -145,8 +145,8 @@ void __igt_fixture_end(void) __attribute__((noreturn));
 			 __igt_fixture_complete())
 
 /* subtest infrastructure */
-jmp_buf igt_subtest_jmpbuf;
-jmp_buf igt_dynamic_jmpbuf;
+extern jmp_buf igt_subtest_jmpbuf;
+extern jmp_buf igt_dynamic_jmpbuf;
 typedef int (*igt_opt_handler_t)(int opt, int opt_index, void *data);
 #define IGT_OPT_HANDLER_SUCCESS 0
 #define IGT_OPT_HANDLER_ERROR -2
Signature · 6 lines
2.24.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 1/4
#2 lore raw

Re: [igt-dev] [PATCH i-g-t 1/4] lib/igt_core: Make igt_subtest_jmpbuf/igt_dynamic_jmpbuf extern

Quoting Lyude (2020-03-16 16:11:29)

Quoted 17 lines

From: Lyude Paul <[email protected]>

Since gcc 10, -fno-common has become the default (vs. -fcommon). As a result, gcc is much stricter about missing extern and static keywords and causes our build to fail in anything including igt_core.h:

/usr/bin/ld:
lib/libigt-i915_gem_context_c.a(i915_gem_context.c.o):lib/igt_core.h:149:
multiple definition of `igt_dynamic_jmpbuf'; lib/libigt-drmtest_c.a(drmtest.c.o):lib/igt_core.h:149: first defined here
/usr/bin/ld:
lib/libigt-i915_gem_context_c.a(i915_gem_context.c.o):lib/igt_core.h:148:
multiple definition of `igt_subtest_jmpbuf'; lib/libigt-drmtest_c.a(drmtest.c.o):lib/igt_core.h:148: first defined here

Quoted 4 lines

So, fix this by marking these as extern and declaring them in lib/igt_core.c.

Signed-off-by Lyude Paul <[email protected]>
Reviewed-by Chris Wilson <[email protected]>

One might be tempted to start marking up library private symbols. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#3 lore raw

PATCH 2/4 lib/rendercopy_gen*: Make cc/viewport static

In reply to Lyude

From: Lyude Paul <[email protected]>

Since both rendercopy_gen8.c and rendercopy_gen9.c declare cc/viewport variables without marking them as static, -fcommon also causes these to make our builds fail:

/usr/bin/ld:
lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:46:
multiple definition of `cc'; lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:45:
first defined here
/usr/bin/ld:
lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:51:
multiple definition of `viewport'; lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:50:
first defined here

So, fix this by marking them as static.

Signed-off-by Lyude Paul <[email protected]>
---
 lib/rendercopy_gen8.c | 4 ++--
 lib/rendercopy_gen9.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
lib/rendercopy_gen8.c +2 -2
index 8e02d846..bace64a7 100644
@@ -39,12 +39,12 @@ static void dump_batch(struct intel_batchbuffer *batch) {
 #define dump_batch(x) do { } while(0)
 #endif
 
-struct {
+static struct {
 	uint32_t cc_state;
 	uint32_t blend_state;
 } cc;
 
-struct {
+static struct {
 	uint32_t cc_state;
 	uint32_t sf_clip_state;
 } viewport;
lib/rendercopy_gen9.c +2 -2
index 835c8d80..f364c2b9 100644
@@ -40,12 +40,12 @@ static void dump_batch(struct intel_batchbuffer *batch) {
 #define dump_batch(x) do { } while(0)
 #endif
 
-struct {
+static struct {
 	uint32_t cc_state;
 	uint32_t blend_state;
 } cc;
 
-struct {
+static struct {
 	uint32_t cc_state;
 	uint32_t sf_clip_state;
 } viewport;
Signature · 6 lines
2.24.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v1 2/4
#4 lore raw

Re: [igt-dev] [PATCH i-g-t 2/4] lib/rendercopy_gen*: Make cc/viewport static

Quoting Lyude (2020-03-16 16:11:30)

Quoted 17 lines

From: Lyude Paul <[email protected]>

Since both rendercopy_gen8.c and rendercopy_gen9.c declare cc/viewport variables without marking them as static, -fcommon also causes these to make our builds fail:

/usr/bin/ld:
lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:46:
multiple definition of `cc'; lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:45:
first defined here
/usr/bin/ld:
lib/libigt-rendercopy_gen9_c.a(rendercopy_gen9.c.o):lib/rendercopy_gen9.c:51:
multiple definition of `viewport'; lib/libigt-rendercopy_gen8_c.a(rendercopy_gen8.c.o):lib/rendercopy_gen8.c:50:
first defined here

Quoted 3 lines

So, fix this by marking them as static.

Signed-off-by Lyude Paul <[email protected]>
Reviewed-by Chris Wilson <[email protected]>

-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#5 lore raw

PATCH 3/4 assembler/gen4asm.h: Make struct src_operand extern

In reply to Lyude

From: Lyude Paul <[email protected]>

Another spot where we fail compilation with -fcommon, due to src_operand getting included in multiple translation units without being marked as extern:

/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here

So, fix this by marking struct src_operand as extern.

Signed-off-by Lyude Paul <[email protected]>
---
 assembler/gen4asm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
assembler/gen4asm.h +1 -1
index 6b957e28..7845060c 100644
@@ -111,7 +111,7 @@ struct regtype {
  * This structure is the internal representation of source operands in the
  * parser.
  */
-struct src_operand {
+extern struct src_operand {
 	struct brw_reg reg;
 	int default_region;
 	uint32_t imm32; /* set if src_operand is expressing a branch offset */
Signature · 6 lines
2.24.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#6 lore raw

Re: [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern

Quoting Lyude (2020-03-16 16:11:31)

Quoted 29 lines

From: Lyude Paul <[email protected]>

Another spot where we fail compilation with -fcommon, due to src_operand getting included in multiple translation units without being marked as extern:

/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here

So, fix this by marking struct src_operand as extern.

Signed-off-by Lyude Paul <[email protected]>
---
 assembler/gen4asm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
assembler/gen4asm.h +0 -0
index 6b957e28..7845060c 100644

assembler/gen4asm.h struct regtype { · line 117

Quoted 8 lines
assembler/gen4asm.h +1 -1
@@ -111,7 +111,7 @@ struct regtype {
  * This structure is the internal representation of source operands in the
  * parser.
  */
-struct src_operand {
+extern struct src_operand {
        struct brw_reg reg;
        int default_region;
        uint32_t imm32; /* set if src_operand is expressing a branch offset */

I suspect this was a typedef. I can't see any definition for the struct src_operand src_operand, and I think it can be deleted. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#7 lore raw

Re: [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern

Quoted 38 lines · Chris Wilson

Quoting Lyude (2020-03-16 16:11:31)

Quoted 37 lines

From: Lyude Paul <[email protected]>

Another spot where we fail compilation with -fcommon, due to src_operand getting included in multiple translation units without being marked as extern:

/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson- generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson- generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson- generated_lex.c.o:assembler/gen4asm.h:119:
first defined here

So, fix this by marking struct src_operand as extern.

Signed-off-by Lyude Paul <[email protected]>
---
 assembler/gen4asm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
assembler/gen4asm.h +0 -0
index 6b957e28..7845060c 100644
@@ -111,7 +111,7 @@ struct regtype {
  * This structure is the internal representation of source operands in

the
* parser.
*/
-struct src_operand {

Quoted 8 lines
Quoted 5 lines
+extern struct src_operand {
        struct brw_reg reg;
        int default_region;
        uint32_t imm32; /* set if src_operand is expressing a branch

offset */

I suspect this was a typedef. I can't see any definition for the struct src_operand src_operand, and I think it can be deleted.

You sure about this? It appears to be referenced in assembler/gram.y:

assembler/gram.y:57:static struct src_operand src_null_reg = assembler/gram.y:77:static struct src_operand ip_src =
assembler/gram.y:92: struct src_operand *src,
assembler/gram.y:95: struct src_operand *src,
(etc.)

Or are you suggesting we just move it into gram.y?

Quoted 2 lines

-Chris

Signature · 8 lines
Cheers,
	Lyude Paul (she/her)
	Associate Software Engineer at Red Hat

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#8 lore raw

Re: [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern

Quoted 50 lines · Lyude Paul
Quoted 38 lines · Chris Wilson

Quoting Lyude (2020-03-16 16:11:31)

Quoted 37 lines

From: Lyude Paul <[email protected]>

Another spot where we fail compilation with -fcommon, due to src_operand getting included in multiple translation units without being marked as extern:

/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson- generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson- generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson- generated_lex.c.o:assembler/gen4asm.h:119:
first defined here

So, fix this by marking struct src_operand as extern.

Signed-off-by Lyude Paul <[email protected]>
---
 assembler/gen4asm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
assembler/gen4asm.h +0 -0
index 6b957e28..7845060c 100644
@@ -111,7 +111,7 @@ struct regtype {
  * This structure is the internal representation of source operands in

the
* parser.
*/
-struct src_operand {

Quoted 8 lines
Quoted 5 lines
+extern struct src_operand {
        struct brw_reg reg;
        int default_region;
        uint32_t imm32; /* set if src_operand is expressing a branch

offset */

I suspect this was a typedef. I can't see any definition for the struct src_operand src_operand, and I think it can be deleted.

You sure about this? It appears to be referenced in assembler/gram.y:

Quoted 7 lines

assembler/gram.y:57:static struct src_operand src_null_reg = assembler/gram.y:77:static struct src_operand ip_src =
assembler/gram.y:92: struct src_operand *src,
assembler/gram.y:95: struct src_operand *src,
(etc.)

Or are you suggesting we just move it into gram.y?

ah-whoops, I just realized you were talking about the fact we defined it as a variable at all, oops. will send a respin with this changed

Quoted 2 lines
Quoted 2 lines

-Chris

Signature · 8 lines
Cheers,
	Lyude Paul (she/her)
	Associate Software Engineer at Red Hat

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#9 lore raw

Re: [igt-dev] [PATCH i-g-t 3/4] assembler/gen4asm.h: Make struct src_operand extern

In reply to Lyude

Quoting Lyude (2020-03-16 16:11:31)

Quoted 29 lines

From: Lyude Paul <[email protected]>

Another spot where we fail compilation with -fcommon, due to src_operand getting included in multiple translation units without being marked as extern:

/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here

So, fix this by marking struct src_operand as extern.

Signed-off-by Lyude Paul <[email protected]>
---
 assembler/gen4asm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
assembler/gen4asm.h +0 -0
index 6b957e28..7845060c 100644

assembler/gen4asm.h struct regtype { · line 117

Quoted 8 lines
assembler/gen4asm.h +1 -1
@@ -111,7 +111,7 @@ struct regtype {
  * This structure is the internal representation of source operands in the
  * parser.
  */
-struct src_operand {
+extern struct src_operand {
        struct brw_reg reg;
        int default_region;
        uint32_t imm32; /* set if src_operand is expressing a branch offset */

I think this was a typedef, and I can't see any definition for the src_operand so I think this declaration can be safely deleted. -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#10 lore raw

PATCH v2 1/1 assembler/gen4asm.h: Remove struct src_operand src_operand variable

In reply to Lyude

From: Lyude Paul <[email protected]>

Another spot where we fail compilation with -fcommon, due to src_operand getting included in multiple translation units without being marked as extern:

/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here

However, we never actually refer to this variable - only its type definition. So, just remove the declaration entirely.

Changes since v1:
* Don't make src_operand extern - just remove the variable declaration entirely, we only ever use the typedef - Chris Wilson

Signed-off-by Lyude Paul <[email protected]>
---
 assembler/gen4asm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
assembler/gen4asm.h +1 -1
index 6b957e28..9537d457 100644
@@ -116,7 +116,7 @@ struct src_operand {
 	int default_region;
 	uint32_t imm32; /* set if src_operand is expressing a branch offset */
 	char *reloc_target; /* bspec: branching instructions JIP and UIP are source operands */
-} src_operand;
+};
 
 typedef struct {
     enum {
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by on v2 1/1
#11 lore raw

Re: [igt-dev] [PATCH i-g-t v2] assembler/gen4asm.h: Remove struct src_operand src_operand variable

Quoted 17 lines · Lyude

From: Lyude Paul <[email protected]>

Another spot where we fail compilation with -fcommon, due to src_operand getting included in multiple translation units without being marked as extern:

/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_gram.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here
/usr/bin/ld:
assembler/1ca89e8@@intel-gen4asm@exe/main.c.o:assembler/gen4asm.h:119:
multiple definition of `src_operand'; assembler/1ca89e8@@intel-gen4asm@exe/meson-generated_lex.c.o:assembler/gen4asm.h:119:
first defined here

Quoted 8 lines

However, we never actually refer to this variable - only its type definition. So, just remove the declaration entirely.

Changes since v1:
* Don't make src_operand extern - just remove the variable declaration entirely, we only ever use the typedef - Chris Wilson

Signed-off-by Lyude Paul <[email protected]>
Reviewed-by Petri Latvala <[email protected]>
Quoted 24 lines
---
 assembler/gen4asm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
assembler/gen4asm.h +1 -1
index 6b957e28..9537d457 100644
@@ -116,7 +116,7 @@ struct src_operand {
 	int default_region;
 	uint32_t imm32; /* set if src_operand is expressing a branch offset */
 	char *reloc_target; /* bspec: branching instructions JIP and UIP are source operands */
-} src_operand;
+};
 
 typedef struct {
     enum {
Signature · 6 lines
2.25.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author
#12 lore raw

PATCH 4/4 meson: Add -fcommon to cc_flags

In reply to Lyude

From: Lyude Paul <[email protected]>

Now that we've fixed a bunch of build breakages on systems where -fcommon is the default (gcc 10+), let's start building with -fcommon by default so we can make sure things don't break with this in the future. Supposedly it's supposed to be able to generate better code anyway!

Signed-off-by Lyude Paul <[email protected]>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)
meson.build +1 -0
index bcb69e1c..0d7092bd 100644
@@ -70,6 +70,7 @@ cc_args = [
 # well with longjmp which is heavily used by IGT framework.
 	'-fno-builtin-malloc',
 	'-fno-builtin-calloc',
+	'-fcommon',
 ]
 
 foreach cc_arg : cc_args
Signature · 6 lines
2.24.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Acked-by on v1 4/4
#13 lore raw

Re: [igt-dev] [PATCH i-g-t 4/4] meson: Add -fcommon to cc_flags

Quoted 6 lines · Lyude

From: Lyude Paul <[email protected]>

Now that we've fixed a bunch of build breakages on systems where -fcommon is the default (gcc 10+), let's start building with -fcommon by default so we can make sure things don't break with this in the future. Supposedly it's supposed to be able to generate better code anyway!

The documentation claims otherwise, "on many targets implies a speed and code size penalty on global variable references". In fact the documentation even claims you get the multiple definition errors for variables with -fno-common and -fcommon helps avoiding them in legacy code! It's completely backwards to what happens. Oh well.

With that said, the code was clearly wrong, thanks for the series.

Quoted 2 lines
Signed-off-by Lyude Paul <[email protected]>
Acked-by Petri Latvala <[email protected]>

What this series proves is that no one is able to understand how tentative definitions and tentative declarations work in C.

Signature · 5 lines
Petri Latvala
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
CI
#14 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Fixes for GCC 10's -fcommon default

In reply to Lyude
== Series Details ==

== Series Details ==

Series: Fixes for GCC 10's -fcommon default
URL : https://patchwork.freedesktop.org/series/74749/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8137 -> IGTPW_4310
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html

Known issues
------------

Here are the changes found in IGTPW_4310 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@execlists:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927] / [i915#656])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-bxt-dsi/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-bxt-dsi/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][3] ([CI#94]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-tgl-y/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [FAIL][5] ([i915#217]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-icl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-icl-u2/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][7] ([fdo#109271]) -> [FAIL][8] ([i915#665] / [i915#704])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-kbl-guc/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-kbl-guc/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([i915#323]) -> [FAIL][10] ([fdo#111407])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/fi-kbl-7500u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/fi-kbl-7500u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112259]: https://bugs.freedesktop.org/show_bug.cgi?id=112259
[i915#1430]: https://gitlab.freedesktop.org/drm/intel/issues/1430
[i915#217]: https://gitlab.freedesktop.org/drm/intel/issues/217
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
[i915#665]: https://gitlab.freedesktop.org/drm/intel/issues/665
[i915#704]: https://gitlab.freedesktop.org/drm/intel/issues/704

Participating hosts (48 -> 42)
------------------------------

Additional (1): fi-tgl-dsi
Missing (7): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-gdg-551 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5510 -> IGTPW_4310

CI-20190529: 20190529
CI_DRM_8137: 5786b5e77cc17a1b494b9bdf3c3f29eedc2e2e7d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4310: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html
IGT_5510: e100092d50105463f58db531fa953c70cc58bb10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

CI
#15 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for Fixes for GCC 10's -fcommon default

In reply to Lyude
== Series Details ==

== Series Details ==

Series: Fixes for GCC 10's -fcommon default
URL : https://patchwork.freedesktop.org/series/74749/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8137_full -> IGTPW_4310_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4310_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4310_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4310_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_ctx_shared@single-timeline:
- shard-snb: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb4/igt@[email protected]

* igt@gem_eio@banned:
- shard-iclb: [PASS][2] -> [SKIP][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb7/igt@[email protected]
- shard-tglb: [PASS][4] -> [SKIP][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@[email protected]

* igt@gem_eio@kms:
- shard-glk: [PASS][6] -> [FAIL][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk5/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk5/igt@[email protected]

* igt@gem_wait@busy-vecs0:
- shard-hsw: NOTRUN -> [FAIL][8] +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw1/igt@[email protected]

* igt@gem_wait@write-wait-bcs0:
- shard-hsw: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw1/igt@[email protected]

* igt@i915_hangman@error-state-capture-vcs0:
- shard-snb: [PASS][11] -> [TIMEOUT][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb4/igt@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-apl: [PASS][13] -> [FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl6/igt@[email protected]
- shard-kbl: [PASS][15] -> [FAIL][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl1/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- shard-snb: [PASS][17] -> [FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb5/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][19] -> [INCOMPLETE][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl6/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_8137_full and IGTPW_4310_full:

### New IGT tests (10) ###

* igt@sysfs_heartbeat_interval@idempotent:
- Statuses :
- Exec time: [None] s

* igt@sysfs_heartbeat_interval@invalid:
- Statuses :
- Exec time: [None] s

* igt@sysfs_heartbeat_interval@nopreempt:
- Statuses :
- Exec time: [None] s

* igt@sysfs_heartbeat_interval@off:
- Statuses :
- Exec time: [None] s

* igt@sysfs_heartbeat_interval@precise:
- Statuses :
- Exec time: [None] s

* igt@sysfs_preempt_timeout@idempotent:
- Statuses :
- Exec time: [None] s

* igt@sysfs_preempt_timeout@invalid:
- Statuses :
- Exec time: [None] s

* igt@sysfs_timeslice_duration@duration:
- Statuses :
- Exec time: [None] s

* igt@sysfs_timeslice_duration@idempotent:
- Statuses :
- Exec time: [None] s

* igt@sysfs_timeslice_duration@timeout:
- Statuses :
- Exec time: [None] s

Known issues
------------

Here are the changes found in IGTPW_4310_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl1/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl1/igt@[email protected]

* igt@gem_ctx_persistence@close-replace-race:
- shard-kbl: [PASS][23] -> [INCOMPLETE][24] ([i915#1402])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl4/igt@[email protected]
- shard-glk: [PASS][25] -> [INCOMPLETE][26] ([i915#1402] / [i915#58] / [k.org#198133])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk2/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#110841])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb1/igt@[email protected]

* igt@gem_ctx_shared@q-out-order-blt:
- shard-glk: [PASS][29] -> [FAIL][30] ([fdo#112118]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk3/igt@[email protected]
- shard-apl: [PASS][31] -> [FAIL][32] ([fdo#112118])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl3/igt@[email protected]
- shard-tglb: [PASS][33] -> [FAIL][34] ([fdo#112118])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@[email protected]

* igt@gem_ctx_shared@q-out-order-vebox:
- shard-kbl: [PASS][35] -> [FAIL][36] ([fdo#112118])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl4/igt@[email protected]

* igt@gem_eio@banned:
- shard-apl: [PASS][37] -> [SKIP][38] ([fdo#109271]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl8/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl3/igt@[email protected]
- shard-glk: [PASS][39] -> [SKIP][40] ([fdo#109271]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk3/igt@[email protected]
- shard-kbl: [PASS][41] -> [SKIP][42] ([fdo#109271]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl3/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl4/igt@[email protected]

* igt@gem_exec_schedule@implicit-both-bsd1:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109276] / [i915#677]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb5/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#112146]) +8 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb1/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][47] -> [FAIL][48] ([i915#644])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk9/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk4/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-iclb: [PASS][49] -> [FAIL][50] ([i915#413])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb5/igt@[email protected]

* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-glk: [PASS][51] -> [FAIL][52] ([i915#407])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk8/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: [PASS][53] -> [FAIL][54] ([i915#79])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][55] -> [DMESG-WARN][56] ([i915#180])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-snb: [PASS][57] -> [DMESG-WARN][58] ([i915#478])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html

* igt@kms_plane_lowres@pipe-c-tiling-x:
- shard-hsw: [PASS][59] -> [DMESG-WARN][60] ([i915#478])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw5/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][61] -> [SKIP][62] ([fdo#109441]) +3 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_setmode@basic:
- shard-glk: [PASS][63] -> [FAIL][64] ([i915#31])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk8/igt@[email protected]

* igt@kms_vblank@pipe-c-query-idle-hang:
- shard-iclb: [PASS][65] -> [SKIP][66] ([fdo#109278])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb7/igt@[email protected]
- shard-tglb: [PASS][67] -> [SKIP][68] ([fdo#112015])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@[email protected]

* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][69] -> [SKIP][70] ([fdo#112080]) +11 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb6/igt@[email protected]

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][71] -> [SKIP][72] ([fdo#109276]) +17 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb5/igt@[email protected]

#### Possible fixes ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][73] ([fdo#112080]) -> [PASS][74] +12 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb4/igt@[email protected]

* igt@gem_ctx_isolation@rcs0-s3:
- shard-snb: [FAIL][75] -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb4/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb5/igt@[email protected]

* igt@gem_ctx_persistence@close-replace-race:
- shard-tglb: [INCOMPLETE][77] ([i915#1402]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb2/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb1/igt@[email protected]
- shard-apl: [INCOMPLETE][79] ([fdo#103927] / [i915#1402]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl1/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl8/igt@[email protected]

* igt@gem_eio@in-flight-contexts-1us:
- shard-hsw: [TIMEOUT][81] -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw1/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw1/igt@[email protected]

* igt@gem_exec_parallel@bcs0-fds:
- shard-apl: [FAIL][83] -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl3/igt@[email protected]
- shard-iclb: [FAIL][85] -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb6/igt@[email protected]
- shard-tglb: [FAIL][87] -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb3/igt@[email protected]
- shard-glk: [FAIL][89] -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk5/igt@[email protected]

* igt@gem_exec_schedule@implicit-read-write-bsd1:
- shard-iclb: [SKIP][91] ([fdo#109276] / [i915#677]) -> [PASS][92] +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb5/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [SKIP][93] ([fdo#112146]) -> [PASS][94] +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb4/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [SKIP][95] ([i915#677]) -> [PASS][96] +3 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb8/igt@[email protected]

* igt@gem_exec_schedule@preempt-contexts-bsd2:
- shard-iclb: [SKIP][97] ([fdo#109276]) -> [PASS][98] +15 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb8/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preempt-hang-render:
- shard-apl: [SKIP][99] ([fdo#109271]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl4/igt@[email protected]
- shard-glk: [SKIP][101] ([fdo#109271]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk8/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk6/igt@[email protected]
- shard-iclb: [SKIP][103] -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb2/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb1/igt@[email protected]
- shard-tglb: [SKIP][105] -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb6/igt@[email protected]
- shard-kbl: [SKIP][107] ([fdo#109271]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl7/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl7/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [DMESG-WARN][109] ([fdo#111870]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw7/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw5/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][111] ([i915#180]) -> [PASS][112] +1 similar issue
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl2/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl2/igt@[email protected]

* igt@i915_pm_dc@dc5-dpms:
- shard-iclb: [FAIL][113] ([i915#447]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb3/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb2/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-devices:
- shard-iclb: [SKIP][115] ([i915#1316]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb1/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb4/igt@[email protected]
- shard-hsw: [SKIP][117] ([fdo#109271]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw4/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw4/igt@[email protected]
- shard-tglb: [SKIP][119] ([i915#1316]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb6/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@[email protected]

* igt@i915_pm_rps@waitboost:
- shard-tglb: [FAIL][121] ([i915#413]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb7/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb5/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][123] ([i915#72]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk1/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk3/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [INCOMPLETE][125] ([i915#61]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw4/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-kbl: [FAIL][127] ([i915#49]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
- shard-glk: [FAIL][129] ([i915#49]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-glk2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-glk5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
- shard-apl: [FAIL][131] ([i915#49]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-snb: [DMESG-WARN][133] ([i915#478]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [DMESG-WARN][135] ([i915#180]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl6/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl7/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][137] ([fdo#109441]) -> [PASS][138] +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

* igt@kms_vblank@pipe-d-ts-continuation-modeset-hang:
- shard-tglb: [SKIP][139] ([fdo#112015]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb3/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb2/igt@[email protected]

* igt@perf@gen12-mi-rpc:
- shard-tglb: [FAIL][141] ([i915#1085]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb6/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb7/igt@[email protected]

* igt@perf_pmu@most-busy-idle-check-all-bcs0:
- shard-hsw: [FAIL][143] -> [PASS][144] +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw5/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw5/igt@[email protected]

#### Warnings ####

* igt@gem_userptr_blits@map-fixed-invalidate-busy@gtt:
- shard-hsw: [DMESG-WARN][145] ([fdo#110789] / [i915#478]) -> [DMESG-WARN][146] ([i915#478])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-hsw5/igt@gem_userptr_blits@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-hsw4/igt@gem_userptr_blits@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [SKIP][147] ([i915#468]) -> [FAIL][148] ([i915#454])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-tglb2/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-tglb6/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-apl: [TIMEOUT][149] ([i915#1319]) -> [FAIL][150] ([fdo#110321] / [fdo#110336])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl8/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl4/igt@[email protected]

* igt@runner@aborted:
- shard-kbl: [FAIL][151] ([i915#92]) -> ([FAIL][152], [FAIL][153]) ([i915#1389] / [i915#1402] / [i915#92])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-kbl3/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl1/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-kbl4/igt@[email protected]
- shard-apl: ([FAIL][154], [FAIL][155]) ([fdo#103927] / [i915#1402]) -> [FAIL][156] ([fdo#103927])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl3/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8137/shard-apl1/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/shard-apl1/igt@[email protected]

[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112015]: https://bugs.freedesktop.org/show_bug.cgi?id=112015
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112118]: https://bugs.freedesktop.org/show_bug.cgi?id=112118
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#1085]: https://gitlab.freedesktop.org/drm/intel/issues/1085
[i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1389]: https://gitlab.freedesktop.org/drm/intel/issues/1389
[i915#1402]: https://gitlab.freedesktop.org/drm/intel/issues/1402
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#58]: https://gitlab.freedesktop.org/d

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4310/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

CI
#16 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for Fixes for GCC 10's -fcommon default (rev2)

In reply to Lyude
== Series Details ==

== Series Details ==

Series: Fixes for GCC 10's -fcommon default (rev2)
URL : https://patchwork.freedesktop.org/series/74749/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8160 -> IGTPW_4329
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4329 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4329, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4329:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-hsw-peppy: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8160/fi-hsw-peppy/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/fi-hsw-peppy/igt@i915_selftest@live@gt_heartbeat.html

Known issues
------------

Here are the changes found in IGTPW_4329 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@execlists:
- fi-bxt-dsi: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927] / [i915#656])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8160/fi-bxt-dsi/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/fi-bxt-dsi/igt@i915_selftest@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][5] -> [FAIL][6] ([i915#323])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8160/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/fi-kbl-7500u/igt@[email protected]

[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656

Participating hosts (37 -> 39)
------------------------------

Additional (6): fi-bsw-n3050 fi-byt-j1900 fi-cfl-8109u fi-skl-6600u fi-bsw-nick fi-skl-6700k2
Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-kbl-8809g

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5523 -> IGTPW_4329

CI-20190529: 20190529
CI_DRM_8160: 6ba1729e5025761ab74914f6b8aa3288f493e9c7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4329: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/index.html
IGT_5523: cf6d524007ac51a7d5a48503ea3dd5f01fd4ebab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4329/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev