Skip to content

testing and gdbstub

Alex Bennée qemu-arm qemu-devel qemu-riscv 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest28 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28tests/docker: Install tools to cross-debug and build Linux kernelstests/docker/dockerfiles/debian10.docker tests/docker/dockerfiles/debian9.docker+6 -00 replies
2/28tests/docker: Update VirGL git repository URLtests/docker/dockerfiles/debian-amd64.docker+1 -10 replies
3/28tests/docker: Remove obsolete VirGL --with-glx configure optiontests/docker/dockerfiles/debian-amd64.docker+1 -10 replies
4/28tests/docker: Update VirGL to v0.8.0tests/docker/dockerfiles/debian-amd64.docker+1 -10 replies
5/28travis.yml: Set G_MESSAGES_DEBUG do report GLib errors.travis.yml+1 -00 replies
6/28gdbstub: make GDBState static and have common init functiongdbstub.c+81 -870 replies
7/28gdbstub: stop passing GDBState * around and use globalgdbstub.c+278 -2830 replies
8/28gdbstub: move str_buf to GDBState and use GStringgdbstub.c+90 -1050 replies
9/28gdbstub: move mem_buf to GDBState and use GByteArraygdbstub.c+35 -210 replies
10/28gdbstub: add helper for 128 bit registersinclude/exec/gdbstub.h+13 -00 replies
11/28target/arm: use gdb_get_reg helperstarget/arm/helper.c+7 -110 replies
12/28target/m68k: use gdb_get_reg helperstarget/m68k/helper.c+11 -181 reply
13/28target/i386: use gdb_get_reg helperstarget/i386/gdbstub.c+11 -162 replies
14/28gdbstub: extend GByteArray to read register helpersgdbstub.c hw/core/cpu.c include/exec/gdbstub.h +38 more+179 -1490 replies
15/28target/arm: prepare for multiple dynamic XMLstarget/arm/cpu.h target/arm/gdbstub.c target/arm/helper.c+30 -240 replies
16/28target/arm: explicitly encode regnum in our XMLtarget/arm/cpu.h target/arm/gdbstub.c target/arm/helper.c+13 -80 replies
17/28target/arm: default SVE length to 64 bytes for linux-usertarget/arm/cpu.c+4 -30 replies
18/28target/arm: generate xml description of our SVE registerstarget/arm/cpu.h target/arm/gdbstub.c target/arm/helper.c+261 -50 replies
19/28target/arm: don't bother with id_aa64pfr0_read for USER_ONLYtarget/arm/helper.c+15 -51 reply
20/28tests/tcg/aarch64: userspace system register testtests/tcg/aarch64/Makefile.target tests/tcg/aarch64/sysregs.c+178 -03 replies
21/28configure: allow user to specify what gdb to useconfigure+9 -02 replies
22/28tests/guest-debug: add a simple test runnertests/guest-debug/run-test.py+57 -01 reply
23/28tests/tcg/aarch64: add a gdbstub testcase for SVE registerstests/.gitignore tests/tcg/aarch64/Makefile.target tests/tcg/aarch64/gdbstub/test-sve.py+97 -01 reply
24/28tests/tcg/aarch64: add SVE iotcl testtests/tcg/aarch64/Makefile.target tests/tcg/aarch64/sve-ioctls.c+74 -05 replies
25/28tests/tcg/aarch64: add test-sve-ioctl guest-debug testtests/tcg/aarch64/Makefile.target tests/tcg/aarch64/gdbstub/test-sve-ioctl.py+91 -20 replies
26/28gdbstub: change GDBState.last_packet to GByteArraygdbstub.c+21 -180 replies
27/28gdbstub: do not split gdb_monitor_write payloadgdbstub.c+3 -200 replies
28/28gdbstub: Fix single-step issue by confirming 'vContSupported+' feature to gdbgdbstub.c+1 -10 replies

Reviews trailers per patch

20 of 28 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonDamien HeddePhilippe Mathieu-DaudéLaurent VivierDavid GibsonLuc Michel
1/28
2/28
3/28
4/28
5/28
6/28R-b R-b
7/28R-b R-b R-b
8/28R-b R-b T-b
9/28R-b R-b T-b
10/28R-b R-b
11/28R-b R-b
12/28R-b R-b R-b
13/28R-b
14/28R-b R-b A-b
15/28A-b
16/28R-b
17/28R-b
18/28A-b
19/28R-b R-b
20/28R-b
21/28R-b
22/28R-b T-b
23/28T-b
24/28T-b
25/28
26/28R-b R-b
27/28R-b
28/28T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH v1 00/28 for 5.0] testing and gdbstub

Hi,

This is the last chance to get any reviews in before I send a pull request later today. To avoid having multiple PRs I've combined both the testing changes and the gdbstub updates. In the end I had to drop Gerd's vm updates as it cause problems with the acceptance testing.

The following patches still need review:
- tests/tcg/aarch64: add test-sve-ioctl guest-debug test
- tests/tcg/aarch64: add SVE iotcl test
- tests/tcg/aarch64: add a gdbstub testcase for SVE registers
- target/arm: generate xml description of our SVE registers
- target/arm: prepare for multiple dynamic XMLs
- target/i386: use gdb_get_reg helpers

Alex Bennée (20):
gdbstub: make GDBState static and have common init function
gdbstub: stop passing GDBState * around and use global
gdbstub: move str_buf to GDBState and use GString
gdbstub: move mem_buf to GDBState and use GByteArray
gdbstub: add helper for 128 bit registers target/arm: use gdb_get_reg helpers
target/m68k: use gdb_get_reg helpers
target/i386: use gdb_get_reg helpers
gdbstub: extend GByteArray to read register helpers target/arm: prepare for multiple dynamic XMLs target/arm: explicitly encode regnum in our XML target/arm: default SVE length to 64 bytes for linux-user target/arm: generate xml description of our SVE registers target/arm: don't bother with id_aa64pfr0_read for USER_ONLY tests/tcg/aarch64: userspace system register test
configure: allow user to specify what gdb to use tests/guest-debug: add a simple test runner tests/tcg/aarch64: add a gdbstub testcase for SVE registers tests/tcg/aarch64: add SVE iotcl test tests/tcg/aarch64: add test-sve-ioctl guest-debug test

Changbin Du (1):
gdbstub: Fix single-step issue by confirming 'vContSupported+' feature
to gdb

Damien Hedde (2):
gdbstub: change GDBState.last_packet to GByteArray
gdbstub: do not split gdb_monitor_write payload

Philippe Mathieu-Daudé (5):
tests/docker: Install tools to cross-debug and build Linux kernels tests/docker: Update VirGL git repository URL tests/docker: Remove obsolete VirGL --with-glx configure option tests/docker: Update VirGL to v0.8.0
travis.yml: Set G_MESSAGES_DEBUG do report GLib errors

 configure                                    |   9 +
 include/exec/gdbstub.h                       |  62 +-
 include/hw/core/cpu.h                        |   2 +-
 target/alpha/cpu.h                           |   2 +-
 target/arm/cpu.h                             |  31 +-
 target/cris/cpu.h                            |   4 +-
 target/hppa/cpu.h                            |   2 +-
 target/i386/cpu.h                            |   2 +-
 target/lm32/cpu.h                            |   2 +-
 target/m68k/cpu.h                            |   2 +-
 target/microblaze/cpu.h                      |   2 +-
 target/mips/internal.h                       |   2 +-
 target/openrisc/cpu.h                        |   2 +-
 target/ppc/cpu.h                             |   4 +-
 target/riscv/cpu.h                           |   2 +-
 target/s390x/internal.h                      |   2 +-
 target/sh4/cpu.h                             |   2 +-
 target/sparc/cpu.h                           |   2 +-
 target/xtensa/cpu.h                          |   2 +-
 gdbstub.c                                    | 936 +++++++++----------
 hw/core/cpu.c                                |   2 +-
 target/alpha/gdbstub.c                       |   2 +-
 target/arm/cpu.c                             |   7 +-
 target/arm/gdbstub.c                         | 173 +++-
 target/arm/gdbstub64.c                       |   2 +-
 target/arm/helper.c                          | 186 +++-
 target/cris/gdbstub.c                        |   4 +-
 target/hppa/gdbstub.c                        |   2 +-
 target/i386/gdbstub.c                        |  29 +-
 target/lm32/gdbstub.c                        |   2 +-
 target/m68k/gdbstub.c                        |   2 +-
 target/m68k/helper.c                         |  33 +-
 target/microblaze/gdbstub.c                  |   2 +-
 target/mips/gdbstub.c                        |   2 +-
 target/nios2/cpu.c                           |   2 +-
 target/openrisc/gdbstub.c                    |   2 +-
 target/ppc/gdbstub.c                         |  48 +-
 target/ppc/translate_init.inc.c              |  54 +-
 target/riscv/gdbstub.c                       |  20 +-
 target/s390x/gdbstub.c                       |  30 +-
 target/sh4/gdbstub.c                         |   2 +-
 target/sparc/gdbstub.c                       |   2 +-
 target/xtensa/gdbstub.c                      |   2 +-
 tests/tcg/aarch64/sve-ioctls.c               |  70 ++
 tests/tcg/aarch64/sysregs.c                  | 172 ++++
 .travis.yml                                  |   1 +
 tests/.gitignore                             |   1 +
 tests/docker/dockerfiles/debian-amd64.docker |   6 +-
 tests/docker/dockerfiles/debian10.docker     |   3 +
 tests/docker/dockerfiles/debian9.docker      |   3 +
 tests/guest-debug/run-test.py                |  57 ++
 tests/tcg/aarch64/Makefile.target            |  32 +
 tests/tcg/aarch64/gdbstub/test-sve-ioctl.py  |  82 ++
 tests/tcg/aarch64/gdbstub/test-sve.py        |  81 ++
 54 files changed, 1491 insertions(+), 701 deletions(-)
 create mode 100644 tests/tcg/aarch64/sve-ioctls.c
 create mode 100644 tests/tcg/aarch64/sysregs.c
 create mode 100755 tests/guest-debug/run-test.py
 create mode 100644 tests/tcg/aarch64/gdbstub/test-sve-ioctl.py
 create mode 100644 tests/tcg/aarch64/gdbstub/test-sve.py
Signature · 1 line
2.20.1