Skip to content

Multiple fixes in PCIe qcom driver

Ansuel Smith linux-arm-msm linux-devicetree linux-pci lkml stable 7 versions – Applied

Status from this message: Applied to pci/dwc for v5.9, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest12 patches 4 repliesApplied
  2. v612 patches 1 replySuperseded
  3. v511 patches 7 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v410 patches9 repliesSuperseded
v311 patches20 repliesSuperseded
v210 patches12 repliesSuperseded
v112 patches20 repliesSuperseded

Changes in v7 from the cover letter

* Rework GEN1 patch

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/12PCI: qcom: Add missing ipq806x clocks in PCIe driverdrivers/pci/controller/dwc/pcie-qcom.c+33 -50 replies
2/12dt-bindings: PCI: qcom: Add missing clksDocumentation/devicetree/bindings/pci/qcom,pcie.txt+6 -20 replies
3/12PCI: qcom: Change duplicate PCI reset to phy resetdrivers/pci/controller/dwc/pcie-qcom.c+8 -100 replies
4/12PCI: qcom: Add missing reset for ipq806xdrivers/pci/controller/dwc/pcie-qcom.c+12 -00 replies
5/12dt-bindings: PCI: qcom: Add ext resetDocumentation/devicetree/bindings/pci/qcom,pcie.txt+4 -20 replies
6/12PCI: qcom: Use bulk clk api and assert on errordrivers/pci/controller/dwc/pcie-qcom.c+46 -850 replies
7/12PCI: qcom: Define some PARF params needed for ipq8064 SoCdrivers/pci/controller/dwc/pcie-qcom.c+24 -00 replies
8/12PCI: qcom: Add support for tx term offset for rev 2.1.0drivers/pci/controller/dwc/pcie-qcom.c+16 -10 replies
9/12PCI: qcom: Add ipq8064 rev2 variantdrivers/pci/controller/dwc/pcie-qcom.c+3 -10 replies
10/12dt-bindings: PCI: qcom: Add ipq8064 rev 2 variantDocumentation/devicetree/bindings/pci/qcom,pcie.txt+1 -00 replies
11/12PCI: qcom: Support pci speed set for ipq806xdrivers/pci/controller/dwc/pcie-qcom.c+13 -00 replies
12/12PCI: qcom: Replace define with standard valuedrivers/pci/controller/dwc/pcie-qcom.c+5 -100 replies

Reviews trailers per patch

9 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRob HerringPhilipp ZabelStanimir Varbanov
SeriesA-b A-b
1/12R-b
2/12A-b
3/12R-b
4/12R-b R-b
5/12A-b
6/12R-b
7/12R-b
8/12
9/12
10/12A-b
11/12R-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/12] Multiple fixes in PCIe qcom driver

This contains multiple fix for PCIe qcom driver.
Some optional reset and clocks were missing.
Fix a problem with no PARF programming that cause kernel lock on load. Add support to force gen 1 speed if needed. (due to hardware limitation) Add ipq8064 rev 2 support that use a different tx termination offset.

v7:
* Rework GEN1 patch

v6:
* Replace custom define
* Move define not used in 07 to 08

v5:
* Split PCI: qcom: Add ipq8064 rev2 variant and set tx term offset

v4:
* Fix grammar error across all patch subject
* Use bulk api for clks
* Program PARF only in ipq8064 SoC
* Program tx term only in ipq8064 SoC
* Drop configurable tx-dempth rx-eq
* Make added clk optional

v3:
* Fix check reported by checkpatch --strict
* Rename force_gen1 to gen

v2:
* Drop iATU programming (already done in pcie init)
* Use max-link-speed instead of force-gen1 custom definition
* Drop MRRS to 256B (Can't find a realy reason why this was suggested)
* Introduce a new variant for different revision of ipq8064

Abhishek Sahu (1):
PCI: qcom: Change duplicate PCI reset to phy reset

Ansuel Smith (10):
PCI: qcom: Add missing ipq806x clocks in PCIe driver
dt-bindings: PCI: qcom: Add missing clks
PCI: qcom: Add missing reset for ipq806x
dt-bindings: PCI: qcom: Add ext reset
PCI: qcom: Use bulk clk api and assert on error
PCI: qcom: Define some PARF params needed for ipq8064 SoC
PCI: qcom: Add support for tx term offset for rev 2.1.0
PCI: qcom: Add ipq8064 rev2 variant
dt-bindings: PCI: qcom: Add ipq8064 rev 2 variant
PCI: qcom: Replace define with standard value

Sham Muthayyan (1):
PCI: qcom: Support pci speed set for ipq806x

 .../devicetree/bindings/pci/qcom,pcie.txt     |  15 +-
 drivers/pci/controller/dwc/pcie-qcom.c        | 186 +++++++++++-------
 2 files changed, 128 insertions(+), 73 deletions(-)
Signature · 1 line
2.27.0.rc0