Skip to content

Makefile: libfdt: build only the strict necessary

Claudio Fontana qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/22 patches 5 repliesIn review
  2. v5 posting 1/22 patches 0 repliesSuperseded
  3. v42 patches 4 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 2/22 patches7 repliesSuperseded
v3 posting 1/22 patches1 replySuperseded
v21 patch4 repliesSuperseded
v11 patch3 repliesSuperseded

Changes in v5 from the cover letter

* include the dtc submodule update commit in the 1/2 patch

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Makefile: dtc: update, build the libfdt targetMakefile configure dtc+6 -70 replies
2/2Makefile: remove old compatibility gunksMakefile+0 -60 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMarkus ArmbrusterPhilippe Mathieu-Daudé
1/2R-b T-b
2/2R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] Makefile: libfdt: build only the strict necessary

v4 -> v5:

* include the dtc submodule update commit in the 1/2 patch

v3 -> v4: NB! only useful when updating to latest dtc (not in QEMU yet)

* changed the approach to leverage new upstream dtc Makefile, needs dtc submodule update to include upstream dtc commit 85e5d839847af54efab170f2b1331b2a6421e647.

* LIBFDT_srcdir does not exist anymore in upstream dtc: it is also not used anymore.

* LIBFDT_lib: need to avoid building libfdt.so at least for now, so pass as empty to avoid building the .so. This is to avoid breaking existing trees with objects already compiled without -fPIC.

* clean: no need to make dtc clean target, every artifact is captured by global clean rule

v2 -> v3:

* changed into a 2 patch series; in the second patch we remove the old compatibility gunks that were meant for removal some time after 4.1.

* renamed the libfdt PHONY rule to dtc/all, with the intent to make existing working trees forward and backward compatible across the change.

v1 -> v2:

* fix error generated when running UNCHECKED_GOALS without prior configure, for example during make docker-image-fedora. Without configure, DSOSUF is empty, and the module pattern rule in rules.mak that uses this variable can match too much; provide a default in the Makefile to avoid it.

* only attempt to build the archive when there is a non-empty list of objects. This could be done in general for the %.a: pattern in rules.mak, but maybe there are valid reasons to build an empty .a?

* removed some intermediate variables that did not add much value (LIBFDT_srcdir, LIBFDT_archive)

Tested locally with 3 VPATH configurations (no-, VPATH, VPATH in src subdir), and with docker-image-fedora, docker-test-debug@fedora that failed before.

Claudio Fontana (2):
Makefile: libfdt: build only the strict necessary
Makefile: remove old compatibility gunks

 Makefile  | 32 ++++++++++++++++----------------
 configure |  6 +-----
 rules.mak |  2 ++
 3 files changed, 19 insertions(+), 21 deletions(-)
Signature · 1 line
2.16.4