Skip to content

xfs: flush related error handling cleanups

Brian Foster linux-xfs 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest17 patches 18 repliesIn review
  2. v317 patches 39 repliesSuperseded
  3. v213 patches 32 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v112 patches35 repliesSuperseded

Changes in v4 from the cover letter · 20 lines

- Remove unnecessary xfs_trans_ail_delete() comment.
- Add Fixes: tag to dqflush duplicate verification patch.
v3: https://lore.kernel.org/linux-xfs/[email protected]/
- Drop flags param from xfs_buf_ioend_fail().
- Fix up iflush error handling patch subject and comments.
- Drop failed buffer ->ail_lock bypass patch.
- Split up AIL removal cleanup patch and dropped switch of call from xfs_buf_item_put().
- Rework XBF_WRITE_FAIL to reflect current buffer state.
- Create helper for ratelimited buffer alerts and use appropriately.
- Use BLK_STS_IOERR instead of errno_to_blk_status().
- Drop unused param from xfs_imap_to_bp().
v2: https://lore.kernel.org/linux-xfs/[email protected]/
- Rename some helper functions.
- Fix up dquot flush verifier instead of removing it.
- Drop quotaoff push handler removal patch.
- Reuse existing ratelimit state for buffer error messages.
- Combine AIL removal helpers.
- Refactor iflush error handling rework to update log item.
- Remove unused shutdown types.
v1: https://lore.kernel.org/linux-xfs/[email protected]/

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17xfs: refactor failed buffer resubmission into xfsaildfs/xfs/xfs_buf_item.c fs/xfs/xfs_buf_item.h fs/xfs/xfs_dquot_item.c +2 more+41 -710 replies
2/17xfs: factor out buffer I/O failure codefs/xfs/xfs_buf.c fs/xfs/xfs_buf.h fs/xfs/xfs_buf_item.c +1 more+22 -270 replies
3/17xfs: simplify inode flush error handlingfs/xfs/xfs_inode.c+45 -722 replies
4/17xfs: remove unnecessary shutdown check from xfs_iflush()fs/xfs/libxfs/xfs_inode_buf.c fs/xfs/xfs_inode.c+1 -190 replies
5/17xfs: reset buffer write failure state on successful completionfs/xfs/xfs_buf.c+5 -32 replies
6/17xfs: refactor ratelimited buffer error messages into helperfs/xfs/xfs_buf.c fs/xfs/xfs_buf.h fs/xfs/xfs_buf_item.c +2 more+41 -171 reply
7/17xfs: ratelimit unmount time per-buffer I/O error alertfs/xfs/xfs_buf.c+11 -41 reply
7/17xfs: ratelimit unmount time per-buffer I/O error alertfs/xfs/xfs_buf.c+17 -41 reply
8/17xfs: fix duplicate verification from xfs_qm_dqflush()fs/xfs/xfs_dquot.c+4 -51 reply
9/17xfs: abort consistently on dquot flush failurefs/xfs/xfs_dquot.c+10 -220 replies
10/17xfs: acquire ->ail_lock from xfs_trans_ail_delete()fs/xfs/xfs_buf_item.c fs/xfs/xfs_dquot.c fs/xfs/xfs_trans_ail.c +1 more+25 -251 reply
11/17xfs: use delete helper for items expected to be in AILfs/xfs/xfs_bmap_item.c fs/xfs/xfs_extfree_item.c fs/xfs/xfs_refcount_item.c +1 more+4 -41 reply
12/17xfs: drop unused shutdown parameter from xfs_trans_ail_remove()fs/xfs/xfs_buf_item.c fs/xfs/xfs_dquot.c fs/xfs/xfs_dquot_item.c +2 more+5 -101 reply
13/17xfs: combine xfs_trans_ail_[remove|delete]()fs/xfs/xfs_buf_item.c fs/xfs/xfs_dquot.c fs/xfs/xfs_dquot_item.c +3 more+6 -431 reply
14/17xfs: remove unused iflush stale parameterfs/xfs/xfs_icache.c fs/xfs/xfs_inode.c fs/xfs/xfs_inode_item.c +1 more+6 -70 replies
15/17xfs: random buffer write failure errortagfs/xfs/libxfs/xfs_errortag.h fs/xfs/xfs_buf.c fs/xfs/xfs_error.c+12 -10 replies
16/17xfs: remove unused shutdown typesfs/xfs/xfs_fsops.c fs/xfs/xfs_mount.h+1 -61 reply
17/17xfs: remove unused iget_flags param from xfs_imap_to_bp()fs/xfs/libxfs/xfs_inode_buf.c fs/xfs/libxfs/xfs_inode_buf.h fs/xfs/scrub/ialloc.c +2 more+8 -111 reply

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchAllison CollinsDave ChinnerChristoph HellwigDarrick J. Wong
1/17R-b R-b R-b R-b
2/17R-b R-b R-b R-b
3/17R-b R-b R-b
4/17R-b R-b R-b R-b
5/17R-b R-b R-b R-b
6/17R-b R-b R-b
7/17R-b R-b R-b R-b R-b R-b R-b
7/17R-b R-b R-b R-b R-b R-b R-b
8/17R-b R-b R-b R-b
9/17R-b R-b R-b R-b
10/17R-b R-b R-b
11/17R-b R-b R-b
12/17R-b R-b R-b
13/17R-b R-b R-b R-b
14/17R-b R-b R-b R-b
15/17R-b R-b R-b R-b
16/17R-b R-b R-b R-b
17/17R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/17] xfs: flush related error handling cleanups

Hi all,

I think everything has been reviewed to this point. Only minor changes noted below in this release. A git repo is available here[1].

The only outstanding feedback that I'm aware of is Dave's comment on patch 7 of v3 [2] regarding the shutdown assert check. I'm not aware of any means to get through xfs_wait_buftarg() with a dirty buffer that hasn't undergone the permanant error sequence and thus shut down the fs. I'm personally fine with any option among dropping the assert, keeping it or replacing it with a shutdown invocation because atm I don't see it making much of a functional difference, but I left it alone because the patch is otherwise reviewed.

Thoughts, reviews, flames appreciated.

Brian

[1] https://github.com/bsfost/linux-xfs/tree/xfs-flush-error-handling-cleanups-v4
[2] https://lore.kernel.org/linux-xfs/20200501112408.GB40250@bfoster/

v4:
- Remove unnecessary xfs_trans_ail_delete() comment.
- Add Fixes: tag to dqflush duplicate verification patch.
v3: https://lore.kernel.org/linux-xfs/[email protected]/
- Drop flags param from xfs_buf_ioend_fail().
- Fix up iflush error handling patch subject and comments.
- Drop failed buffer ->ail_lock bypass patch.
- Split up AIL removal cleanup patch and dropped switch of call from xfs_buf_item_put().
- Rework XBF_WRITE_FAIL to reflect current buffer state.
- Create helper for ratelimited buffer alerts and use appropriately.
- Use BLK_STS_IOERR instead of errno_to_blk_status().
- Drop unused param from xfs_imap_to_bp().
v2: https://lore.kernel.org/linux-xfs/[email protected]/
- Rename some helper functions.
- Fix up dquot flush verifier instead of removing it.
- Drop quotaoff push handler removal patch.
- Reuse existing ratelimit state for buffer error messages.
- Combine AIL removal helpers.
- Refactor iflush error handling rework to update log item.
- Remove unused shutdown types.
v1: https://lore.kernel.org/linux-xfs/[email protected]/

Brian Foster (17):
xfs: refactor failed buffer resubmission into xfsaild
xfs: factor out buffer I/O failure code
xfs: simplify inode flush error handling
xfs: remove unnecessary shutdown check from xfs_iflush()
xfs: reset buffer write failure state on successful completion
xfs: refactor ratelimited buffer error messages into helper
xfs: ratelimit unmount time per-buffer I/O error alert
xfs: fix duplicate verification from xfs_qm_dqflush()
xfs: abort consistently on dquot flush failure
xfs: acquire ->ail_lock from xfs_trans_ail_delete()
xfs: use delete helper for items expected to be in AIL
xfs: drop unused shutdown parameter from xfs_trans_ail_remove()
xfs: combine xfs_trans_ail_[remove|delete]()
xfs: remove unused iflush stale parameter
xfs: random buffer write failure errortag
xfs: remove unused shutdown types
xfs: remove unused iget_flags param from xfs_imap_to_bp()

 fs/xfs/libxfs/xfs_errortag.h  |   4 +-
 fs/xfs/libxfs/xfs_inode_buf.c |  12 +--
 fs/xfs/libxfs/xfs_inode_buf.h |   2 +-
 fs/xfs/scrub/ialloc.c         |   3 +-
 fs/xfs/xfs_bmap_item.c        |   2 +-
 fs/xfs/xfs_buf.c              |  65 ++++++++++++----
 fs/xfs/xfs_buf.h              |   2 +
 fs/xfs/xfs_buf_item.c         | 106 +++++---------------------
 fs/xfs/xfs_buf_item.h         |   2 -
 fs/xfs/xfs_dquot.c            |  47 +++++-------
 fs/xfs/xfs_dquot_item.c       |  17 +----
 fs/xfs/xfs_error.c            |   3 +
 fs/xfs/xfs_extfree_item.c     |   2 +-
 fs/xfs/xfs_fsops.c            |   5 +-
 fs/xfs/xfs_icache.c           |   2 +-
 fs/xfs/xfs_inode.c            | 139 ++++++++++++----------------------
 fs/xfs/xfs_inode_item.c       |  28 +------
 fs/xfs/xfs_inode_item.h       |   2 +-
 fs/xfs/xfs_log_recover.c      |   2 +-
 fs/xfs/xfs_message.c          |  22 ++++++
 fs/xfs/xfs_message.h          |   3 +
 fs/xfs/xfs_mount.h            |   2 -
 fs/xfs/xfs_refcount_item.c    |   2 +-
 fs/xfs/xfs_rmap_item.c        |   2 +-
 fs/xfs/xfs_trans_ail.c        |  68 +++++++++++------
 fs/xfs/xfs_trans_priv.h       |  18 +----
 26 files changed, 231 insertions(+), 331 deletions(-)
Signature · 1 line
2.21.1