Remove duplicated kmap code
Status from this message: [merged] kmap-consolidate-kmap_prot-definitions.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest15 patches 14 repliesApplied 15/15
- v211 patches 16 repliesSuperseded
- v110 patches 24 repliesSuperseded
Changes in v3 from the cover letter
Collect review/acks
Add kmap_prot consolidation patch from Christoph Add 3 suggested patches from Al Viro Fix include for microblaze
Fix static inline for microblaze
Patches in v3 All 15 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | arch/kmap: Remove BUG_ON()arch/ arch/ arch/ +8 more | +13 | 0 replies | Applied |
| 2/15 | arch/xtensa: Move kmap build bug out of the wayarch/ arch/ | +4 | 0 replies | Applied |
| 3/15 | arch/kmap: Remove redundant arch specific kmapsarch/ arch/ arch/ +14 more | +29 | 0 replies | Applied |
| 4/15 | arch/kunmap: Remove duplicate kunmap implementationsarch/ arch/ arch/ +13 more | +9 | 0 replies | Applied |
| 5/15 | {x86,powerpc,microblaze}/kmap: Move preempt disablearch/ arch/ arch/ +3 more | +36 | 0 replies | Applied |
| 6/15 | arch/kmap_atomic: Consolidate duplicate codearch/ arch/ arch/ +18 more | +46 | 0 replies | Applied |
| 7/15 | arch/kunmap_atomic: Consolidate duplicate codearch/ arch/ arch/ +20 more | +31 | 38 replies | Applied |
| 8/15 | arch/kmap: Ensure kmap_prot visibilityarch/ arch/ arch/ +2 more | +3 | 0 replies | Applied |
| 9/15 | arch/kmap: Don't hard code kmap_prot valuesarch/ arch/ arch/ +1 more | +4 | 0 replies | Applied |
| 10/15 | arch/kmap: Define kmap_atomic_prot() for all arch'sarch/ arch/ arch/ +8 more | +25 | 2 replies | Applied |
| 11/15 | drm: Remove drm specific kmap_atomic codedrivers/ drivers/ include/ | +12 | 0 replies | Applied |
| 12/15 | kmap: Remove kmap_atomic_to_page()arch/ arch/ arch/ | +0 | 0 replies | Applied |
| 13/15 | parisc/kmap: Remove duplicate kmap codearch/ include/ | +9 | 2 replies | Applied |
| 14/15 | sparc: Remove unnecessary includesarch/ arch/ | +0 | 0 replies | Applied |
| 15/15 | kmap: Consolidate kmap_prot definitionsarch/ arch/ arch/ +8 more | +6 | 3 replies | Applied |
Reviews trailers per patch
11 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Dan Williams | Christoph Hellwig | Daniel Vetter | Christian König |
|---|---|---|---|---|
| 1/15 | R-b | R-b | ||
| 2/15 | R-b | |||
| 3/15 | R-b | |||
| 4/15 | R-b | |||
| 5/15 | R-b | |||
| 6/15 | R-b | |||
| 7/15 | R-b R-b | |||
| 8/15 | R-b | |||
| 9/15 | R-b | |||
| 10/15 | R-b | |||
| 11/15 | R-b | A-b | R-b | |
| 12/15 | ||||
| 13/15 | ||||
| 14/15 | ||||
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH V3 00/15] Remove duplicated kmap code
From: Ira Weiny <[email protected]>
The kmap infrastructure has been copied almost verbatim to every architecture. This series consolidates obvious duplicated code by defining core functions which call into the architectures only when needed.
Some of the k[un]map_atomic() implementations have some similarities but the similarities were not sufficient to warrant further changes.
In addition we remove a duplicate implementation of kmap() in DRM.
Testing was done by 0day to cover all the architectures I can't readily build/test.
---
Changes from V2:
Collect review/acks
Add kmap_prot consolidation patch from Christoph Add 3 suggested patches from Al Viro Fix include for microblaze
Fix static inline for microblaze
Changes from V1:
Fix bisect-ability
Update commit message and fix line lengths Remove unneded kunmap_atomic_high() declarations Remove unneded kmap_atomic_high() declarations collect reviews
rebase to 5.7-rc4
Changes from V0:
Define kmap_flush_tlb() and make kmap() truely arch independent. Redefine the k[un]map_atomic_* code to call into the architectures for
high mem pages
Ensure all architectures define kmap_prot, use it appropriately, and
define kmap_atomic_prot()
Remove drm implementation of kmap_atomic()
Ira Weiny (15):
arch/kmap: Remove BUG_ON()
arch/xtensa: Move kmap build bug out of the way arch/kmap: Remove redundant arch specific kmaps arch/kunmap: Remove duplicate kunmap implementations {x86,powerpc,microblaze}/kmap: Move preempt disable arch/kmap_atomic: Consolidate duplicate code arch/kunmap_atomic: Consolidate duplicate code arch/kmap: Ensure kmap_prot visibility arch/kmap: Don't hard code kmap_prot values arch/kmap: Define kmap_atomic_prot() for all arch's
drm: Remove drm specific kmap_atomic code
kmap: Remove kmap_atomic_to_page() parisc/kmap: Remove duplicate kmap code
sparc: Remove unnecessary includes
kmap: Consolidate kmap_prot definitions
arch/arc/include/asm/highmem.h | 18 ------- arch/arc/mm/highmem.c | 28 ++-------- arch/arm/include/asm/highmem.h | 9 ---- arch/arm/mm/highmem.c | 35 ++----------- arch/csky/include/asm/highmem.h | 12 +---- arch/csky/mm/highmem.c | 56 ++++---------------- arch/microblaze/include/asm/highmem.h | 27 ---------- arch/microblaze/mm/highmem.c | 16 ++---- arch/microblaze/mm/init.c | 3 -- arch/mips/include/asm/highmem.h | 11 +--- arch/mips/mm/cache.c | 6 +-- arch/mips/mm/highmem.c | 49 +++--------------- arch/nds32/include/asm/highmem.h | 9 ---- arch/nds32/mm/highmem.c | 39 ++------------ arch/parisc/include/asm/cacheflush.h | 30 +---------- arch/powerpc/include/asm/highmem.h | 28 ---------- arch/powerpc/mm/highmem.c | 21 ++------ arch/powerpc/mm/mem.c | 3 -- arch/sparc/include/asm/highmem.h | 25 +-------- arch/sparc/mm/highmem.c | 20 ++------ arch/sparc/mm/io-unit.c | 1 - arch/sparc/mm/iommu.c | 1 - arch/x86/include/asm/fixmap.h | 1 - arch/x86/include/asm/highmem.h | 9 ---- arch/x86/mm/highmem_32.c | 50 ++---------------- arch/xtensa/include/asm/highmem.h | 27 ---------- arch/xtensa/mm/highmem.c | 22 ++++---- drivers/gpu/drm/ttm/ttm_bo_util.c | 56 ++------------------ drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 16 +++--- include/drm/ttm/ttm_bo_api.h | 4 -- include/linux/highmem.h | 74 ++++++++++++++++++++++++--- 31 files changed, 150 insertions(+), 556 deletions(-)
Signature · 1 line
2.25.1