Skip to content

Add regulator devfreq support to Panfrost

Clément Péron dri-devel lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest14 patches 5 repliesIn review
  2. v414 patches 1 replySuperseded
  3. v314 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v214 patches11 repliesSuperseded
v1 RFC15 patches20 repliesSuperseded

Changes in v5 from the cover letter

- Fix missed a pfdev to &pfdev->devfreq during rebase

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/panfrost: avoid static declarationdrivers/gpu/drm/panfrost/panfrost_devfreq.c+18 -200 replies
2/14drm/panfrost: clean headers in devfreqdrivers/gpu/drm/panfrost/panfrost_devfreq.c+2 -60 replies
3/14drm/panfrost: don't use pfdevfreq.busy_count to know if hw is idledrivers/gpu/drm/panfrost/panfrost_job.c+0 -40 replies
4/14drm/panfrost: introduce panfrost_devfreq structdrivers/gpu/drm/panfrost/panfrost_devfreq.c drivers/gpu/drm/panfrost/panfrost_devfreq.h drivers/gpu/drm/panfrost/panfrost_device.h +1 more+66 -470 replies
5/14drm/panfrost: use spinlock instead of atomicdrivers/gpu/drm/panfrost/panfrost_devfreq.c drivers/gpu/drm/panfrost/panfrost_devfreq.h+40 -120 replies
6/14drm/panfrost: properly handle error in probedrivers/gpu/drm/panfrost/panfrost_devfreq.c drivers/gpu/drm/panfrost/panfrost_devfreq.h+20 -60 replies
7/14drm/panfrost: rename error labels in device_initdrivers/gpu/drm/panfrost/panfrost_device.c+15 -150 replies
8/14drm/panfrost: move devfreq_init()/fini() in devicedrivers/gpu/drm/panfrost/panfrost_device.c drivers/gpu/drm/panfrost/panfrost_drv.c+13 -140 replies
9/14drm/panfrost: dynamically alloc regulatorsdrivers/gpu/drm/panfrost/panfrost_device.c drivers/gpu/drm/panfrost/panfrost_device.h+10 -70 replies
10/14drm/panfrost: add regulators to devfreqdrivers/gpu/drm/panfrost/panfrost_devfreq.c drivers/gpu/drm/panfrost/panfrost_devfreq.h drivers/gpu/drm/panfrost/panfrost_device.c+33 -70 replies
11/14arm64: defconfig: Enable devfreq cooling devicearch/arm64/configs/defconfig+1 -00 replies
12/14arm64: dts: allwinner: h6: Add cooling map for GPUarch/arm64/boot/dts/allwinner/sun50i-h6.dtsi+22 -00 replies
13/14arm64: dts: allwinner: h6: Add GPU OPP tablearch/arm64/boot/dts/allwinner/sun50i-h6.dtsi+80 -00 replies
14/14arm64: dts: allwinner: force GPU regulator to be alwaysarch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts+1 -00 replies

Reviews trailers per patch

12 of 14 patches have a Reviewed-by or Acked-by.

PatchSteven PriceAlyssa Rosenzweig
1/14R-b R-b
2/14R-b R-b
3/14R-b R-b
4/14R-b R-b
5/14R-b R-b
6/14R-b R-b
7/14R-b R-b
8/14R-b R-b
9/14R-b R-b
10/14R-b R-b
11/14R-b
12/14R-b
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/14] Add regulator devfreq support to Panfrost

Hi,

This serie cleans and adds regulator support to Panfrost devfreq. This is mostly based on comment for the freshly introduced lima devfreq.

We need to add regulator support because on Allwinner the GPU OPP table defines both frequencies and voltages.

First patches [01-07] should not change the actual behavior and introduce a proper panfrost_devfreq struct.

Regards,
Clément

Changes since v4:
- Fix missed a pfdev to &pfdev->devfreq during rebase

Changes since v3:
- Collect Steven Price reviewed-by tags
- Rebase on next/master (next-20200709)

Changes since v2:
- Collect Alyssa Rosenzweig reviewed-by tags
- Fix opp_set_regulator before adding opp_table (introduce in v2)
- Call err_fini in case opp_add_table failed

Changes since v1:
- Collect Steven Price reviewed-by tags
- Fix spinlock comment
- Drop OPP clock-name patch
- Drop device_property_test patch
- Add rename error labels patch

Clément Péron (14):
drm/panfrost: avoid static declaration
drm/panfrost: clean headers in devfreq
drm/panfrost: don't use pfdevfreq.busy_count to know if hw is idle drm/panfrost: introduce panfrost_devfreq struct drm/panfrost: use spinlock instead of atomic
drm/panfrost: properly handle error in probe
drm/panfrost: rename error labels in device_init drm/panfrost: move devfreq_init()/fini() in device drm/panfrost: dynamically alloc regulators
drm/panfrost: add regulators to devfreq
arm64: defconfig: Enable devfreq cooling device
arm64: dts: allwinner: h6: Add cooling map for GPU
[DO NOT MERGE] arm64: dts: allwinner: h6: Add GPU OPP table [DO NOT MERGE] arm64: dts: allwinner: force GPU regulator to be always

 .../dts/allwinner/sun50i-h6-beelink-gs1.dts   |   1 +
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi  | 102 ++++++++++
 arch/arm64/configs/defconfig                  |   1 +
 drivers/gpu/drm/panfrost/panfrost_devfreq.c   | 175 ++++++++++++------
 drivers/gpu/drm/panfrost/panfrost_devfreq.h   |  30 ++-
 drivers/gpu/drm/panfrost/panfrost_device.c    |  61 +++---
 drivers/gpu/drm/panfrost/panfrost_device.h    |  14 +-
 drivers/gpu/drm/panfrost/panfrost_drv.c       |  15 +-
 drivers/gpu/drm/panfrost/panfrost_job.c       |  10 +-
 9 files changed, 296 insertions(+), 113 deletions(-)
Signature · 1 line
2.25.1