Skip to content

Fixes around device realization

Markus Armbruster qemu-arm qemu-devel qemu-riscv 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 74 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24arm/stm32f405: Fix realization of "stm32f2xx-adc" deviceshw/arm/stm32f405_soc.c+11 -95 replies
2/24display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge"hw/display/xlnx_dp.c+4 -09 replies
3/24sd/pxa2xx_mmci: Fix to realize "pxa2xx-mmci" devicehw/sd/pxa2xx_mmci.c+1 -01 reply
4/24aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" deviceshw/arm/aspeed_ast2600.c hw/arm/aspeed_soc.c+2 -27 replies
5/24aspeed: Don't create unwanted "cortex-a7-arm-cpu" deviceshw/arm/aspeed_ast2600.c+3 -04 replies
6/24armv7m: Bury unwanted "ARM,bitband-memory" deviceshw/arm/armv7m.c+4 -25 replies
7/24auxbus: Fix aux-to-i2c-bridge to be a subtype of aux-slavehw/misc/auxbus.c+1 -11 reply
8/24mac_via: Fix to realize "mos6522-q800-via*" deviceshw/misc/mac_via.c+3 -01 reply
9/24macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" deviceshw/misc/macio/cuda.c hw/misc/macio/pmu.c+6 -107 replies
10/24macio: Bury unwanted "macio-gpio" deviceshw/misc/macio/macio.c+2 -02 replies
11/24pnv/phb4: Bury unwanted "pnv-phb4-pec-stack" deviceshw/pci-host/pnv_phb4_pec.c+3 -04 replies
12/24MAINTAINERS: Make section PowerNV cover pci-host/pnv* as wellMAINTAINERS+2 -01 reply
13/24ppc4xx: Drop redundant device realizationhw/ppc/ppc440_uc.c+0 -24 replies
14/24macio: Put "macio-nvram" device on the macio bushw/misc/macio/macio.c+2 -11 reply
15/24macio: Fix macio-bus to be a subtype of System bushw/misc/macio/macio.c+1 -13 replies
16/24ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bushw/ppc/pnv.c+3 -33 replies
17/24pnv/psi: Correct the pnv-psi* devices not to be sysbus deviceshw/ppc/pnv_psi.c include/hw/ppc/pnv_psi.h+2 -23 replies
18/24display/sm501 display/ati: Fix to realize "i2c-ddc"hw/display/ati.c hw/display/sm501.c+2 -05 replies
19/24riscv: Fix to put "riscv.hart_array" devices on sysbushw/riscv/sifive_e.c hw/riscv/sifive_u.c hw/riscv/spike.c +1 more+16 -191 reply
20/24riscv: Fix type of SiFive[EU]SocState, member parent_objinclude/hw/riscv/sifive_e.h include/hw/riscv/sifive_u.h+2 -22 replies
21/24sparc/leon3: Fix to put grlib,* devices on sysbushw/sparc/leon3.c+2 -22 replies
22/24qdev: Assert devices are plugged into a bus that can take themhw/core/qdev.c+5 -02 replies
23/24sd: Hide the qdev-but-not-quite thing created by sd_init()hw/sd/sd.c+28 -120 replies
24/24qdev: Assert onboard devices all get realized properlyhw/core/qdev.c+16 -01 reply

Reviews trailers per patch

18 of 24 patches have a Reviewed-by or Acked-by.

PatchDavid GibsonKONRAD FredericGreg KurzPhilippe Mathieu-DaudéEdgar E. IglesiasBALATON ZoltanCédric Le GoaterThomas HuthAlistair FrancisMark Cave-AylandPeter Maydell
1/24R-b
2/24R-b R-b
3/24R-b
4/24
5/24R-b
6/24
7/24R-b
8/24R-b
9/24
10/24
11/24R-b R-b
12/24A-b
13/24R-b R-b R-b
14/24R-b
15/24R-b
16/24R-b
17/24R-b
18/24T-b
19/24R-b
20/24R-b R-b
21/24R-b R-b
22/24R-b
23/24
24/24R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 11 reviewers.

Read the v1 thread

Cover letter [PATCH 00/24] Fixes around device realization

This fixes a bunch of bugs I ran into while reworking how qdevs plug into buses. I instrumented the code a bit to flush out instances of bug patterns. I'll post these hacks separately.

Impact is less than clear in places. Help with that is appreciated.

Markus Armbruster (24):
arm/stm32f405: Fix realization of "stm32f2xx-adc" devices display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge" sd/pxa2xx_mmci: Fix to realize "pxa2xx-mmci" device
aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices
aspeed: Don't create unwanted "cortex-a7-arm-cpu" devices
armv7m: Bury unwanted "ARM,bitband-memory" devices
auxbus: Fix aux-to-i2c-bridge to be a subtype of aux-slave
mac_via: Fix to realize "mos6522-q800-via*" devices
macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices
macio: Bury unwanted "macio-gpio" devices
pnv/phb4: Bury unwanted "pnv-phb4-pec-stack" devices
MAINTAINERS: Make section PowerNV cover pci-host/pnv* as well
ppc4xx: Drop redundant device realization
macio: Put "macio-nvram" device on the macio bus
macio: Fix macio-bus to be a subtype of System bus ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus pnv/psi: Correct the pnv-psi* devices not to be sysbus devices display/sm501 display/ati: Fix to realize "i2c-ddc"
riscv: Fix to put "riscv.hart_array" devices on sysbus
riscv: Fix type of SiFive[EU]SocState, member parent_obj sparc/leon3: Fix to put grlib,* devices on sysbus
qdev: Assert devices are plugged into a bus that can take them
sd: Hide the qdev-but-not-quite thing created by sd_init()
qdev: Assert onboard devices all get realized properly

 include/hw/ppc/pnv_psi.h    |  2 +-
 include/hw/riscv/sifive_e.h |  2 +-
 include/hw/riscv/sifive_u.h |  2 +-
 hw/arm/armv7m.c             |  6 ++++--
 hw/arm/aspeed_ast2600.c     |  5 ++++-
 hw/arm/aspeed_soc.c         |  2 +-
 hw/arm/stm32f405_soc.c      | 20 ++++++++++---------
 hw/core/qdev.c              | 21 +++++++++++++++++++
 hw/display/ati.c            |  1 +
 hw/display/sm501.c          |  1 +
 hw/display/xlnx_dp.c        |  4 ++++
 hw/misc/auxbus.c            |  2 +-
 hw/misc/mac_via.c           |  3 +++
 hw/misc/macio/cuda.c        |  8 +++-----
 hw/misc/macio/macio.c       |  7 +++++--
 hw/misc/macio/pmu.c         |  8 +++-----
 hw/pci-host/pnv_phb4_pec.c  |  3 +++
 hw/ppc/pnv.c                |  6 +++---
 hw/ppc/pnv_psi.c            |  2 +-
 hw/ppc/ppc440_uc.c          |  2 --
 hw/riscv/sifive_e.c         |  5 ++---
 hw/riscv/sifive_u.c         | 14 ++++++-------
 hw/riscv/spike.c            | 12 +++++------
 hw/riscv/virt.c             |  4 ++--
 hw/sd/pxa2xx_mmci.c         |  1 +
 hw/sd/sd.c                  | 40 ++++++++++++++++++++++++++-----------
 hw/sparc/leon3.c            |  4 ++--
 MAINTAINERS                 |  2 ++
 28 files changed, 121 insertions(+), 68 deletions(-)
Signature · 1 line
2.21.1