Skip to content

4.4.225-rc1 review

Greg Kroah-Hartman linux-crypto linux-tegra lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest65 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/65igb: use igb_adapter->io_addr instead of e1000_hw->hw_addrdrivers/net/ethernet/intel/igb/igb_main.c+2 -20 replies
2/65padata: Remove unused but set variableskernel/padata.c+0 -40 replies
3/65padata: get_next is never NULLkernel/padata.c+4 -90 replies
4/65padata: ensure the reorder timer callback runs on the correct CPUinclude/linux/padata.h kernel/padata.c+44 -10 replies
5/65padata: ensure padata_do_serial() runs on the correct CPUinclude/linux/padata.h kernel/padata.c+21 -10 replies
6/65evm: Check also if *tfm is an error pointer in init_desc()security/integrity/evm/evm_crypto.c+1 -10 replies
7/65fix multiplication overflow in copy_fdtable()fs/file.c+1 -10 replies
8/65HID: multitouch: add eGalaxTouch P80H84 supportdrivers/hid/hid-ids.h drivers/hid/hid-multitouch.c+4 -00 replies
9/65ceph: fix double unlock in handle_cap_export()fs/ceph/caps.c+1 -00 replies
10/65USB: core: Fix misleading driver bug reportdrivers/usb/core/message.c+2 -20 replies
11/65platform/x86: asus-nb-wmi: Do not load on Asus T100TA and T200TAdrivers/platform/x86/asus-nb-wmi.c+24 -00 replies
12/65ARM: futex: Address build warningarch/arm/include/asm/futex.h+7 -20 replies
13/65media: Fix media_open() to clear filp->private_data in error legdrivers/media/media-devnode.c+1 -00 replies
14/65drivers/media/media-devnode: clear private_data before put_device()drivers/media/media-devnode.c+2 -10 replies
15/65media-devnode: add missing mutex lock in error handlerdrivers/media/media-devnode.c+3 -00 replies
16/65media-devnode: fix namespace messdrivers/media/media-devnode.c include/media/media-devnode.h+62 -620 replies
17/65media-device: dynamically allocate struct media_devnodedrivers/media/media-device.c drivers/media/media-devnode.c drivers/media/usb/uvc/uvc_driver.c +2 more+46 -190 replies
18/65media: fix use-after-free in cdev_put() when app exits after driver unbinddrivers/media/media-device.c drivers/media/media-devnode.c+33 -210 replies
19/65media: fix media devnode ioctl/syscall and unregister racedrivers/media/media-device.c drivers/media/media-devnode.c include/media/media-devnode.h+34 -140 replies
20/65i2c: dev: switch from register_chrdev to cdev APIdrivers/i2c/i2c-dev.c+15 -40 replies
21/65i2c: dev: dont start function name with returndrivers/i2c/i2c-dev.c+3 -30 replies
22/65i2c: dev: use after free in detachdrivers/i2c/i2c-dev.c+1 -10 replies
23/65i2c-dev: dont get i2c adapter via i2c_devdrivers/i2c/i2c-dev.c+1 -60 replies
24/65i2c: dev: Fix the race between the release of i2c_dev and cdevdrivers/i2c/i2c-dev.c+26 -220 replies
25/65padata: set cpu_index of unused CPUs to -1kernel/padata.c+7 -10 replies
26/65sched/fair, cpumask: Export for_each_cpu_wrap()include/linux/cpumask.h lib/cpumask.c+49 -03 replies
27/65padata: Replace delayed timer with immediate workqueue in padata_reorderinclude/linux/padata.h kernel/padata.c+22 -860 replies
28/65padata: initialize pd->cpu with effective cpumaskkernel/padata.c+1 -10 replies
29/65padata: purge get_cpu and reorder_via_wq from padata_do_serialkernel/padata.c+3 -200 replies
30/65ALSA: pcm: fix incorrect hw_base increasesound/core/pcm_lib.c+1 -00 replies
31/65ext4: lock the xattr block before checksuming itfs/ext4/xattr.c+32 -340 replies
32/65platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointerdrivers/platform/x86/alienware-wmi.c+8 -90 replies
33/65libnvdimm/btt: Remove unnecessary code in btt_freelist_initdrivers/nvdimm/btt.c+2 -60 replies
34/65l2tp: lock socket before checking flags in connect()include/net/ipv6.h net/ipv6/datagram.c net/l2tp/l2tp_ip.c +1 more+28 -130 replies
35/65l2tp: fix racy socket lookup in l2tp_ip and l2tp_ip6 bind()net/l2tp/l2tp_ip.c net/l2tp/l2tp_ip6.c+32 -380 replies
36/65l2tp: hold session while sending creation notificationsnet/l2tp/l2tp_netlink.c+4 -20 replies
37/65l2tp: take a reference on sessions used in genetlink handlersnet/l2tp/l2tp_core.c net/l2tp/l2tp_core.h net/l2tp/l2tp_netlink.c+35 -160 replies
38/65l2tp: dont use l2tp_tunnel_find() in l2tp_ip and l2tp_ip6net/l2tp/l2tp_ip.c net/l2tp/l2tp_ip6.c+16 -290 replies
39/65net: l2tp: export debug flags to UAPIinclude/uapi/linux/l2tp.h net/l2tp/l2tp_core.h+16 -110 replies
40/65net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*Documentation/networking/l2tp.txt include/uapi/linux/if_pppol2tp.h+10 -110 replies
41/65net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*net/l2tp/l2tp_ppp.c+27 -270 replies
42/65New kernel function to get IP overhead on a socket.include/linux/net.h net/socket.c+49 -00 replies
43/65L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.net/l2tp/l2tp_eth.c+51 -40 replies
44/65l2tp: remove useless duplicate session detection in l2tp_netlinknet/l2tp/l2tp_netlink.c+0 -50 replies
45/65l2tp: remove l2tp_session_find()net/l2tp/l2tp_core.c net/l2tp/l2tp_core.h+1 -530 replies
46/65l2tp: define parameters of l2tp_session_get*() as "const"net/l2tp/l2tp_core.c net/l2tp/l2tp_core.h+7 -50 replies
47/65l2tp: define parameters of l2tp_tunnel_find*() as "const"net/l2tp/l2tp_core.c net/l2tp/l2tp_core.h+4 -40 replies
48/65l2tp: initialise sessions refcount before making it reachablenet/l2tp/l2tp_core.c+2 -40 replies
49/65l2tp: hold tunnel while looking up sessions in l2tp_netlinknet/l2tp/l2tp_core.c net/l2tp/l2tp_core.h net/l2tp/l2tp_netlink.c+38 -470 replies
50/65l2tp: hold tunnel while processing genl delete commandnet/l2tp/l2tp_netlink.c+4 -20 replies
51/65l2tp: hold tunnel while handling genl tunnel updatesnet/l2tp/l2tp_netlink.c+4 -20 replies
52/65l2tp: hold tunnel while handling genl TUNNEL_GET commandsnet/l2tp/l2tp_netlink.c+15 -120 replies
53/65l2tp: hold tunnel used while creating sessions with netlinknet/l2tp/l2tp_netlink.c+12 -90 replies
54/65l2tp: prevent creation of sessions on terminated tunnelsnet/l2tp/l2tp_core.c net/l2tp/l2tp_core.h+32 -130 replies
55/65l2tp: pass tunnel pointer to ->session_create()net/l2tp/l2tp_core.h net/l2tp/l2tp_eth.c net/l2tp/l2tp_netlink.c +1 more+17 -250 replies
56/65l2tp: fix l2tp_eth module loadingnet/l2tp/l2tp_eth.c+2 -490 replies
57/65l2tp: dont register sessions in l2tp_session_create()net/l2tp/l2tp_core.c net/l2tp/l2tp_core.h net/l2tp/l2tp_eth.c +1 more+38 -220 replies
58/65l2tp: initialise l2tp_eth sessions before registering themnet/l2tp/l2tp_eth.c+76 -320 replies
59/65l2tp: protect sock pointer of struct pppol2tp_session with RCUnet/l2tp/l2tp_ppp.c+101 -530 replies
60/65l2tp: initialise PPP sessions before registering themnet/l2tp/l2tp_ppp.c+38 -310 replies
61/65Revert "gfs2: Dont demote a glock until its revokes are written"fs/gfs2/glock.c+0 -30 replies
62/65staging: iio: ad2s1210: Fix SPI readingdrivers/staging/iio/resolver/ad2s1210.c+12 -50 replies
63/65mei: release me_cl object referencedrivers/misc/mei/client.c+2 -00 replies
64/65iio: sca3000: Remove an erroneous get_device()drivers/staging/iio/accel/sca3000_ring.c+1 -10 replies
65/65l2tp: device MTU setup, tunnel socket needs a lockinclude/linux/net.h net/l2tp/l2tp_eth.c net/socket.c+4 -20 replies

Reviews trailers per patch

7 of 65 patches have a Reviewed-by or Acked-by.

PatchSteffen KlassertSakari AilusMauro Carvalho ChehabJean DelvareJaroslav KyselaYan, Zheng[email protected]Alexander DuyckAaron BrownGuillaume Nault
1/65A-b T-b
2/65A-b
3/65A-b
4/65
5/65
6/65
7/65
8/65
9/65R-b
10/65Reported-and-tested-by
11/65
12/65
13/65A-b
14/65
15/65
16/65
17/65
18/65T-b
19/65T-b
20/65
21/65
22/65
23/65R-b T-b
24/65
25/65
26/65
27/65
28/65
29/65
30/65R-b
31/65
32/65
33/65
34/65
35/65
36/65
37/65
38/65
39/65
40/65
41/65
42/65
43/65
44/65
45/65
46/65
47/65
48/65
49/65
50/65
51/65
52/65
53/65
54/65
55/65
56/65
57/65
58/65
59/65
60/65
61/65
62/65
63/65
64/65
65/65T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v1 thread

Cover letter [PATCH 4.4 00/65] 4.4.225-rc1 review

This is the start of the stable review cycle for the 4.4.225 release. There are 65 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Thu, 28 May 2020 18:36:22 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.4.225-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 4.4.225-rc1

R. Parameswaran <[email protected]>
l2tp: device MTU setup, tunnel socket needs a lock

Christophe JAILLET <[email protected]>
iio: sca3000: Remove an erroneous 'get_device()'

Alexander Usyskin <[email protected]>
mei: release me_cl object reference

Dragos Bogdan <[email protected]>
staging: iio: ad2s1210: Fix SPI reading

Bob Peterson <[email protected]>
Revert "gfs2: Don't demote a glock until its revokes are written"

Guillaume Nault <[email protected]>
l2tp: initialise PPP sessions before registering them

Guillaume Nault <[email protected]>
l2tp: protect sock pointer of struct pppol2tp_session with RCU

Guillaume Nault <[email protected]>
l2tp: initialise l2tp_eth sessions before registering them

Guillaume Nault <[email protected]>
l2tp: don't register sessions in l2tp_session_create()

Guillaume Nault <[email protected]>
l2tp: fix l2tp_eth module loading

Guillaume Nault <[email protected]>

    l2tp: pass tunnel pointer to ->session_create()

Guillaume Nault <[email protected]>
l2tp: prevent creation of sessions on terminated tunnels

Guillaume Nault <[email protected]>
l2tp: hold tunnel used while creating sessions with netlink

Guillaume Nault <[email protected]>
l2tp: hold tunnel while handling genl TUNNEL_GET commands

Guillaume Nault <[email protected]>
l2tp: hold tunnel while handling genl tunnel updates

Guillaume Nault <[email protected]>
l2tp: hold tunnel while processing genl delete command

Guillaume Nault <[email protected]>
l2tp: hold tunnel while looking up sessions in l2tp_netlink

Guillaume Nault <[email protected]>
l2tp: initialise session's refcount before making it reachable

Guillaume Nault <[email protected]>
l2tp: define parameters of l2tp_tunnel_find*() as "const"

Guillaume Nault <[email protected]>
l2tp: define parameters of l2tp_session_get*() as "const"

Guillaume Nault <[email protected]>
l2tp: remove l2tp_session_find()

Guillaume Nault <[email protected]>
l2tp: remove useless duplicate session detection in l2tp_netlink

R. Parameswaran <[email protected]>
L2TP:Adjust intf MTU, add underlay L3, L2 hdrs.

R. Parameswaran <[email protected]>
New kernel function to get IP overhead on a socket.

Asbjørn Sloth Tønnesen <[email protected]>

    net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*

Asbjørn Sloth Tønnesen <[email protected]>
net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*

Asbjørn Sloth Tønnesen <[email protected]>
net: l2tp: export debug flags to UAPI

Guillaume Nault <[email protected]>
l2tp: don't use l2tp_tunnel_find() in l2tp_ip and l2tp_ip6

Guillaume Nault <[email protected]>
l2tp: take a reference on sessions used in genetlink handlers

Guillaume Nault <[email protected]>
l2tp: hold session while sending creation notifications

Guillaume Nault <[email protected]>
l2tp: fix racy socket lookup in l2tp_ip and l2tp_ip6 bind()

Guillaume Nault <[email protected]>
l2tp: lock socket before checking flags in connect()

Vishal Verma <[email protected]>
libnvdimm/btt: Remove unnecessary code in btt_freelist_init

Colin Ian King <[email protected]>
platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer

Theodore Ts'o <[email protected]>
ext4: lock the xattr block before checksuming it

Brent Lu <[email protected]>
ALSA: pcm: fix incorrect hw_base increase

Daniel Jordan <[email protected]>
padata: purge get_cpu and reorder_via_wq from padata_do_serial

Daniel Jordan <[email protected]>

    padata: initialize pd->cpu with effective cpumask

Herbert Xu <[email protected]>
padata: Replace delayed timer with immediate workqueue in padata_reorder

Peter Zijlstra <[email protected]>
sched/fair, cpumask: Export for_each_cpu_wrap()

Mathias Krause <[email protected]>
padata: set cpu_index of unused CPUs to -1

Kevin Hao <[email protected]>
i2c: dev: Fix the race between the release of i2c_dev and cdev

viresh kumar <[email protected]>
i2c-dev: don't get i2c adapter via i2c_dev

Dan Carpenter <[email protected]>
i2c: dev: use after free in detach

Wolfram Sang <[email protected]>
i2c: dev: don't start function name with 'return'

Erico Nunes <[email protected]>
i2c: dev: switch from register_chrdev to cdev API

Shuah Khan <[email protected]>
media: fix media devnode ioctl/syscall and unregister race

Shuah Khan <[email protected]>
media: fix use-after-free in cdev_put() when app exits after driver unbind

Mauro Carvalho Chehab <[email protected]>
media-device: dynamically allocate struct media_devnode

Mauro Carvalho Chehab <[email protected]>
media-devnode: fix namespace mess

Max Kellermann <[email protected]>
media-devnode: add missing mutex lock in error handler

Max Kellermann <[email protected]>
drivers/media/media-devnode: clear private_data before put_device()

Shuah Khan <[email protected]>

    media: Fix media_open() to clear filp->private_data in error leg

Thomas Gleixner <[email protected]>
ARM: futex: Address build warning

Hans de Goede <[email protected]>
platform/x86: asus-nb-wmi: Do not load on Asus T100TA and T200TA

Alan Stern <[email protected]>
USB: core: Fix misleading driver bug report

Wu Bo <[email protected]>
ceph: fix double unlock in handle_cap_export()

Sebastian Reichel <[email protected]>
HID: multitouch: add eGalaxTouch P80H84 support

Al Viro <[email protected]>
fix multiplication overflow in copy_fdtable()

Roberto Sassu <[email protected]>
evm: Check also if *tfm is an error pointer in init_desc()

Mathias Krause <[email protected]>
padata: ensure padata_do_serial() runs on the correct CPU

Mathias Krause <[email protected]>
padata: ensure the reorder timer callback runs on the correct CPU

Jason A. Donenfeld <[email protected]>
padata: get_next is never NULL

Tobias Klauser <[email protected]>
padata: Remove unused but set variables

Cao jin <[email protected]>

    igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

-------------

Diffstat:

 Documentation/networking/l2tp.txt         |   8 +-
 Makefile                                  |   4 +-
 arch/arm/include/asm/futex.h              |   9 +-
 drivers/hid/hid-ids.h                     |   1 +
 drivers/hid/hid-multitouch.c              |   3 +
 drivers/i2c/i2c-dev.c                     |  60 +++---
 drivers/media/media-device.c              |  43 +++--
 drivers/media/media-devnode.c             | 168 +++++++++-------
 drivers/media/usb/uvc/uvc_driver.c        |   2 +-
 drivers/misc/mei/client.c                 |   2 +
 drivers/net/ethernet/intel/igb/igb_main.c |   4 +-
 drivers/nvdimm/btt.c                      |   8 +-
 drivers/platform/x86/alienware-wmi.c      |  17 +-
 drivers/platform/x86/asus-nb-wmi.c        |  24 +++
 drivers/staging/iio/accel/sca3000_ring.c  |   2 +-
 drivers/staging/iio/resolver/ad2s1210.c   |  17 +-
 drivers/usb/core/message.c                |   4 +-
 fs/ceph/caps.c                            |   1 +
 fs/ext4/xattr.c                           |  66 ++++---
 fs/file.c                                 |   2 +-
 fs/gfs2/glock.c                           |   3 -
 include/linux/cpumask.h                   |  17 ++
 include/linux/net.h                       |   3 +
 include/linux/padata.h                    |  13 +-
 include/media/media-device.h              |   5 +-
 include/media/media-devnode.h             |  32 +++-
 include/net/ipv6.h                        |   2 +
 include/uapi/linux/if_pppol2tp.h          |  13 +-
 include/uapi/linux/l2tp.h                 |  17 +-
 kernel/padata.c                           |  88 ++++-----
 lib/cpumask.c                             |  32 ++++
 net/ipv6/datagram.c                       |   4 +-
 net/l2tp/l2tp_core.c                      | 181 ++++++-----------
 net/l2tp/l2tp_core.h                      |  47 +++--
 net/l2tp/l2tp_eth.c                       | 216 +++++++++++++--------
 net/l2tp/l2tp_ip.c                        |  68 ++++---
 net/l2tp/l2tp_ip6.c                       |  82 ++++----
 net/l2tp/l2tp_netlink.c                   | 124 +++++++-----
 net/l2tp/l2tp_ppp.c                       | 309 ++++++++++++++++++------------
 net/socket.c                              |  46 +++++
 security/integrity/evm/evm_crypto.c       |   2 +-
 sound/core/pcm_lib.c                      |   1 +
 42 files changed, 1014 insertions(+), 736 deletions(-)