Skip to content

Summit SMB3xx driver & device-tree

Dmitry Osipenko linux-arm-msm linux-devicetree linux-pm linux-tegra lkml 2 versions – Applied

Status from this message: Applied to for-5.10/arm/dt, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 4 repliesApplied
  2. v29 patches 5 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10dt-bindings: battery: Add temperature propertiesDocumentation/devicetree/bindings/power/supply/battery.yaml+24 -01 reply
2/10dt-bindings: power: supply: Add device-tree binding for Summit SMB3xxDocumentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml include/dt-bindings/power/summit,smb347-charger.h+171 -01 reply
3/10power: supply: Support battery temperature device-tree propertiesdrivers/power/supply/power_supply_core.c include/linux/power_supply.h+25 -00 replies
4/10power: supply: smb347-charger: Use resource-managed APIdrivers/power/supply/smb347-charger.c+29 -460 replies
5/10power: supply: smb347-charger: Implement device-tree supportdrivers/power/supply/smb347-charger.c+137 -140 replies
6/10power: supply: smb347-charger: Support SMB345 and SMB358drivers/power/supply/Kconfig drivers/power/supply/smb347-charger.c+62 -530 replies
7/10power: supply: smb347-charger: Remove virtual smb347-batterydrivers/power/supply/smb347-charger.c+60 -1460 replies
8/10power: supply: smb347-charger: Replace mutex with IRQ disable/enabledrivers/power/supply/smb347-charger.c+20 -180 replies
9/10ARM: dts: qcom: apq8064-nexus7: Add SMB345 battery chargerarch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts+24 -00 replies
10/10ARM: tegra: nexus7: Add SMB347 battery chargerarch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi+23 -11 reply

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchDmitry OsipenkoDavid HeidelbergRob Herring
1/10R-b
2/10R-b
3/10
4/10R-b
5/10
6/10
7/10R-b
8/10T-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/10] Summit SMB3xx driver & device-tree

We gathered existing patches, fixed and improved what we could and final result is an working charging driver with device-tree support for Nexus 7.

At this moment charging works with:
- Nexus 7 2012 (grouper and tilapia)
- Nexus 7 2013 (flo and deb)
- ... and there are more devices equipped with these chargers.

Changelog:

v3: - The uint32 type now isn't specified for standard units in the SMB
DT binding because standard units already have a type. Thanks to Rob Herring for the suggestion!

- The battery binding changes are rebased on top of the new battery.yaml

- The new battery temperature DT properties now have shorter names and use <min max> format. Thanks to Rob Herring for the suggestion!

- Added new patch that adds SMB charger node to the new Nexus 7 2012 device-tree which has been merged into v5.9 kernel.

v2: - Addressed v1 review comments from Rob Herring and Sebastian Reichel
by moving out common battery properties from the charger node into the battery-cell node.

- power_supply_register() of the SMB driver converted to resource-managed API variant.

- Improved DT property names of the SMB binding by making them to follow the generic power-supply naming scheme (-microvolts at the end, etc).

David Heidelberg (7):
dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx
power: supply: smb347-charger: Use resource-managed API
power: supply: smb347-charger: Implement device-tree support
power: supply: smb347-charger: Support SMB345 and SMB358
power: supply: smb347-charger: Remove virtual smb347-battery
ARM: dts: qcom: apq8064-nexus7: Add SMB345 battery charger
ARM: tegra: nexus7: Add SMB347 battery charger

Dmitry Osipenko (3):
dt-bindings: battery: Add temperature properties
power: supply: Support battery temperature device-tree properties
power: supply: smb347-charger: Replace mutex with IRQ disable/enable

 .../bindings/power/supply/battery.yaml        |  24 +
 .../power/supply/summit,smb347-charger.yaml   | 152 +++++
 .../boot/dts/qcom-apq8064-asus-nexus7-flo.dts |  24 +
 .../tegra30-asus-nexus7-grouper-common.dtsi   |  24 +-
 drivers/power/supply/Kconfig                  |   6 +-
 drivers/power/supply/power_supply_core.c      |  19 +
 drivers/power/supply/smb347-charger.c         | 565 +++++++++---------
 .../dt-bindings/power/summit,smb347-charger.h |  19 +
 include/linux/power_supply.h                  |   6 +
 9 files changed, 568 insertions(+), 271 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
 create mode 100644 include/dt-bindings/power/summit,smb347-charger.h
Signature · 1 line
2.27.0