rtc: pcf2127: add alarm support
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 2 repliesApplied
- v32 patches 3 repliesSuperseded
- v22 patches 8 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 3 patches | 7 replies | Superseded |
Changes in v4 from the cover letter
- Replace "goto irq_err" with "return IRQ_NONE" in interrupt handler
- Add Reviewed-by trailers
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | rtc: pcf2127: add pca2129 device idDocumentation/ drivers/ | +5 | 0 replies | |
| 2/2 | rtc: pcf2127: add alarm supportdrivers/ | +134 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Bruno Thomsen |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] rtc: pcf2127: add alarm support
From: Liam Beguin <[email protected]>
The board used to test this series has the interrupt line of the RTC connected to a circuit controlling the power of the board. An event on the interrupt line while the board is off will power it on. Because of these hardware limitations, the irq handler added in this patch wasn't fully tested.
The alarm fuctionality was tested on a PCA2129, with:
$ date "2010-10-10 10:10" Sun Oct 10 10:10:00 UTC 2010 $ /usr/sbin/rtcwake -u -d /dev/rtc0 -s10 --mode off [ ... ] $ # power on after 10 seconds
Changes since v1:
- Document new compatible string for the pca2129
- Add calls to pcf2127_wdt_active_ping after accessing CTRL2
- Use sizeof(buf) instead of hadcoding value
- Cleanup debug trace
- Add interrupt handler and wakeup-source devicetree option
Changes since v2:
- Rebase on latest mainline tree
- Remove redundant if in pcf2127_rtc_alarm_irq_enable
- Remove duplicate watchdog ping in pcf2127_rtc_irq
- Avoid forward declaration
- Remove dev_err strings
- Remove dev_dbg traces since they are now part of the core
- Avoid unnecessary read in pcf2127_rtc_irq with regmap_write
- Add extra rtc_class_ops struct with alarm functions
Changes since v3:
- Replace "goto irq_err" with "return IRQ_NONE" in interrupt handler
- Add Reviewed-by trailers
Liam Beguin (2):
rtc: pcf2127: add pca2129 device id
rtc: pcf2127: add alarm support
.../devicetree/bindings/rtc/trivial-rtc.yaml | 2 + drivers/rtc/rtc-pcf2127.c | 137 ++++++++++++++++++ 2 files changed, 139 insertions(+)
Interdiff against v3:
drivers/rtc/rtc-pcf2127.c +2 -4
@@ -416,7 +416,7 @@ static irqreturn_t pcf2127_rtc_irq(int irq, void *dev) ret =regmap_read (pcf2127->regmap,PCF2127_REG_CTRL2 , &ctrl2);if (ret) - goto irq_err; +return IRQ_NONE ;if (ctrl2 &PCF2127_BIT_CTRL2_AF ) { regmap_write(pcf2127->regmap, PCF2127_REG_CTRL2,
@@ -427,11 +427,9 @@ static irqreturn_t pcf2127_rtc_irq(int irq, void *dev) ret =pcf2127_wdt_active_ping (&pcf2127->wdd);if (ret) - goto irq_err; +return IRQ_NONE ;return IRQ_HANDLED ; -irq_err: -return IRQ_NONE ; }static const struct rtc_class_ops pcf2127_rtc_alrm_ops = {
base-commit: 7c30b859a947535f2213277e827d7ac7dcff9c84
Signature · 1 line
2.27.0