RFC hw/qdev: Warn when using pre-qdev/QOM devices
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest23 patches 6 repliesIn review
- v1 RFC35 patches 19 repliesSuperseded
Changes in v2 from the cover letter
- Addressed bonzini comments, removed invalid patches
- Addressed thuth comment
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | qom/object: Update documentationinclude/ | +3 | 0 replies | |
| 2/23 | hw/core/qdev: Add qdev_warn_deprecated_function_used() helperconfigure hw/ include/ | +42 | 1 reply | |
| 3/23 | hw/arm/omap: Emit warning when old code is usedhw/ hw/ hw/ +5 more | +32 | 0 replies | |
| 4/23 | hw/arm/pxa2xx: Emit warning when old code is usedhw/ hw/ hw/ | +9 | 0 replies | |
| 5/23 | hw/arm/nseries: Emit warning when old code is usedhw/ | +2 | 0 replies | |
| 6/23 | hw/char/parallel: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 7/23 | hw/display/blizzard: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 8/23 | hw/display/ramfb: Emit warning when old code is usedhw/ | +3 | 2 replies | |
| 9/23 | hw/display/tc6393xb: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 10/23 | hw/display/vga-isa-mm: Emit warning when old code is usedhw/ hw/ | +8 | 0 replies | |
| 11/23 | hw/dma/etraxfs_dma: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 12/23 | hw/dma/soc_dma: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 13/23 | hw/input/lasips2: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 14/23 | hw/input/tsc2005: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 15/23 | hw/m68k/mcf520x: Emit warning when old code is usedhw/ hw/ | +8 | 1 reply | |
| 16/23 | hw/misc/cbus: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 17/23 | hw/nvram/eeprom93xx: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 18/23 | hw/openrisc/cputimer: Emit warning when old code is usedhw/ | +3 | 1 reply | |
| 19/23 | hw/ppc/ppc4xx: Emit warning when old code is usedhw/ hw/ hw/ | +33 | 0 replies | |
| 20/23 | hw/sh4: Emit warning when old code is usedhw/ hw/ hw/ +2 more | +18 | 0 replies | |
| 21/23 | hw/riscv: Emit warning when old code is usedhw/ hw/ | +8 | 1 reply | |
| 22/23 | hw/usb/hcd-musb: Emit warning when old code is usedhw/ | +3 | 0 replies | |
| 23/23 | hw/xtensa/xtfpga: Emit warning when old code is usedhw/ | +3 | 0 replies |
Reviews trailers per patch
2 of 23 patches have a Reviewed-by or Acked-by.
| Patch | Paolo Bonzini | Thomas Huth | Alistair Francis |
|---|---|---|---|
| 1/23 | |||
| 2/23 | |||
| 3/23 | |||
| 4/23 | |||
| 5/23 | |||
| 6/23 | |||
| 7/23 | |||
| 8/23 | |||
| 9/23 | |||
| 10/23 | |||
| 11/23 | |||
| 12/23 | |||
| 13/23 | |||
| 14/23 | |||
| 15/23 | A-b | ||
| 16/23 | |||
| 17/23 | |||
| 18/23 | |||
| 19/23 | |||
| 20/23 | |||
| 21/23 | R-b | R-b | |
| 22/23 | |||
| 23/23 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [RFC PATCH v2 00/23] hw/qdev: Warn when using pre-qdev/QOM devices
This is a trivial RFC series to anotate pre-qdev/QOM devices so developers using them without knowing they are not QOM'ified yet can realize it and convert them if/when they have time.
qdev/QOM devices are introspectable, so easier to test or even fuzz.
Since RFC v1:
- Addressed bonzini comments, removed invalid patches
- Addressed thuth comment
Philippe Mathieu-Daudé (23):
qom/object: Update documentation
hw/core/qdev: Add qdev_warn_deprecated_function_used() helper hw/arm/omap: Emit warning when old code is used hw/arm/pxa2xx: Emit warning when old code is used hw/arm/nseries: Emit warning when old code is used hw/char/parallel: Emit warning when old code is used hw/display/blizzard: Emit warning when old code is used hw/display/ramfb: Emit warning when old code is used hw/display/tc6393xb: Emit warning when old code is used hw/display/vga-isa-mm: Emit warning when old code is used hw/dma/etraxfs_dma: Emit warning when old code is used hw/dma/soc_dma: Emit warning when old code is used hw/input/lasips2: Emit warning when old code is used hw/input/tsc2005: Emit warning when old code is used hw/m68k/mcf520x: Emit warning when old code is used hw/misc/cbus: Emit warning when old code is used hw/nvram/eeprom93xx: Emit warning when old code is used hw/openrisc/cputimer: Emit warning when old code is used hw/ppc/ppc4xx: Emit warning when old code is used hw/sh4: Emit warning when old code is used hw/riscv: Emit warning when old code is used hw/usb/hcd-musb: Emit warning when old code is used hw/xtensa/xtfpga: Emit warning when old code is used
configure | 8 ++++++++ include/hw/qdev-deprecated.h | 26 ++++++++++++++++++++++++++ include/qom/object.h | 6 +++--- hw/arm/nseries.c | 2 ++ hw/arm/omap1.c | 6 ++++++ hw/arm/pxa2xx.c | 3 +++ hw/char/omap_uart.c | 5 +++++ hw/char/parallel.c | 3 +++ hw/char/sh_serial.c | 3 +++ hw/core/qdev.c | 8 ++++++++ hw/display/blizzard.c | 3 +++ hw/display/pxa2xx_lcd.c | 3 +++ hw/display/ramfb.c | 3 +++ hw/display/tc6393xb.c | 3 +++ hw/display/vga-isa-mm.c | 5 +++++ hw/display/vga.c | 3 +++ hw/dma/etraxfs_dma.c | 4 +++- hw/dma/soc_dma.c | 3 +++ hw/input/lasips2.c | 4 +++- hw/input/pxa2xx_keypad.c | 3 +++ hw/input/tsc2005.c | 3 +++ hw/intc/sh_intc.c | 3 +++ hw/m68k/mcf5206.c | 5 +++++ hw/m68k/mcf5208.c | 3 +++ hw/misc/cbus.c | 3 +++ hw/misc/omap_gpmc.c | 3 +++ hw/misc/omap_l4.c | 3 +++ hw/misc/omap_sdrc.c | 3 +++ hw/nvram/eeprom93xx.c | 3 +++ hw/openrisc/cputimer.c | 3 +++ hw/ppc/ppc405_boards.c | 5 +++++ hw/ppc/ppc405_uc.c | 21 +++++++++++++++++++++ hw/ppc/ppc4xx_devs.c | 7 +++++++ hw/riscv/riscv_htif.c | 4 ++++ hw/riscv/sifive_uart.c | 4 ++++ hw/sd/omap_mmc.c | 5 +++++ hw/sh4/r2d.c | 3 +++ hw/sh4/sh7750.c | 4 ++++ hw/ssi/omap_spi.c | 3 +++ hw/timer/omap_synctimer.c | 4 ++++ hw/timer/sh_timer.c | 5 +++++ hw/usb/hcd-musb.c | 3 +++ hw/xtensa/xtfpga.c | 3 +++ 43 files changed, 202 insertions(+), 5 deletions(-) create mode 100644 include/hw/qdev-deprecated.h
Signature · 1 line
2.21.3