Skip to content

RFC hw/qdev: Warn when using pre-qdev/QOM devices

Philippe Mathieu-Daudé qemu-arm qemu-devel qemu-riscv 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest23 patches 6 repliesIn review
  2. v1 RFC35 patches 19 repliesSuperseded

Changes in v2 from the cover letter

- Addressed bonzini comments, removed invalid patches
- Addressed thuth comment

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23qom/object: Update documentationinclude/qom/object.h+3 -30 replies
2/23hw/core/qdev: Add qdev_warn_deprecated_function_used() helperconfigure hw/core/qdev.c include/hw/qdev-deprecated.h+42 -01 reply
3/23hw/arm/omap: Emit warning when old code is usedhw/arm/omap1.c hw/char/omap_uart.c hw/misc/omap_gpmc.c +5 more+32 -00 replies
4/23hw/arm/pxa2xx: Emit warning when old code is usedhw/arm/pxa2xx.c hw/display/pxa2xx_lcd.c hw/input/pxa2xx_keypad.c+9 -00 replies
5/23hw/arm/nseries: Emit warning when old code is usedhw/arm/nseries.c+2 -00 replies
6/23hw/char/parallel: Emit warning when old code is usedhw/char/parallel.c+3 -00 replies
7/23hw/display/blizzard: Emit warning when old code is usedhw/display/blizzard.c+3 -00 replies
8/23hw/display/ramfb: Emit warning when old code is usedhw/display/ramfb.c+3 -02 replies
9/23hw/display/tc6393xb: Emit warning when old code is usedhw/display/tc6393xb.c+3 -00 replies
10/23hw/display/vga-isa-mm: Emit warning when old code is usedhw/display/vga-isa-mm.c hw/display/vga.c+8 -00 replies
11/23hw/dma/etraxfs_dma: Emit warning when old code is usedhw/dma/etraxfs_dma.c+3 -10 replies
12/23hw/dma/soc_dma: Emit warning when old code is usedhw/dma/soc_dma.c+3 -00 replies
13/23hw/input/lasips2: Emit warning when old code is usedhw/input/lasips2.c+3 -10 replies
14/23hw/input/tsc2005: Emit warning when old code is usedhw/input/tsc2005.c+3 -00 replies
15/23hw/m68k/mcf520x: Emit warning when old code is usedhw/m68k/mcf5206.c hw/m68k/mcf5208.c+8 -01 reply
16/23hw/misc/cbus: Emit warning when old code is usedhw/misc/cbus.c+3 -00 replies
17/23hw/nvram/eeprom93xx: Emit warning when old code is usedhw/nvram/eeprom93xx.c+3 -00 replies
18/23hw/openrisc/cputimer: Emit warning when old code is usedhw/openrisc/cputimer.c+3 -01 reply
19/23hw/ppc/ppc4xx: Emit warning when old code is usedhw/ppc/ppc405_boards.c hw/ppc/ppc405_uc.c hw/ppc/ppc4xx_devs.c+33 -00 replies
20/23hw/sh4: Emit warning when old code is usedhw/char/sh_serial.c hw/intc/sh_intc.c hw/sh4/r2d.c +2 more+18 -00 replies
21/23hw/riscv: Emit warning when old code is usedhw/riscv/riscv_htif.c hw/riscv/sifive_uart.c+8 -01 reply
22/23hw/usb/hcd-musb: Emit warning when old code is usedhw/usb/hcd-musb.c+3 -00 replies
23/23hw/xtensa/xtfpga: Emit warning when old code is usedhw/xtensa/xtfpga.c+3 -00 replies

Reviews trailers per patch

2 of 23 patches have a Reviewed-by or Acked-by.

PatchPaolo BonziniThomas HuthAlistair Francis
1/23
2/23
3/23
4/23
5/23
6/23
7/23
8/23
9/23
10/23
11/23
12/23
13/23
14/23
15/23A-b
16/23
17/23
18/23
19/23
20/23
21/23R-b R-b
22/23
23/23

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [RFC PATCH v2 00/23] hw/qdev: Warn when using pre-qdev/QOM devices

This is a trivial RFC series to anotate pre-qdev/QOM devices so developers using them without knowing they are not QOM'ified yet can realize it and convert them if/when they have time.

qdev/QOM devices are introspectable, so easier to test or even fuzz.

Since RFC v1:
- Addressed bonzini comments, removed invalid patches
- Addressed thuth comment

Philippe Mathieu-Daudé (23):
qom/object: Update documentation
hw/core/qdev: Add qdev_warn_deprecated_function_used() helper hw/arm/omap: Emit warning when old code is used hw/arm/pxa2xx: Emit warning when old code is used hw/arm/nseries: Emit warning when old code is used hw/char/parallel: Emit warning when old code is used hw/display/blizzard: Emit warning when old code is used hw/display/ramfb: Emit warning when old code is used hw/display/tc6393xb: Emit warning when old code is used hw/display/vga-isa-mm: Emit warning when old code is used hw/dma/etraxfs_dma: Emit warning when old code is used hw/dma/soc_dma: Emit warning when old code is used hw/input/lasips2: Emit warning when old code is used hw/input/tsc2005: Emit warning when old code is used hw/m68k/mcf520x: Emit warning when old code is used hw/misc/cbus: Emit warning when old code is used hw/nvram/eeprom93xx: Emit warning when old code is used hw/openrisc/cputimer: Emit warning when old code is used hw/ppc/ppc4xx: Emit warning when old code is used hw/sh4: Emit warning when old code is used hw/riscv: Emit warning when old code is used hw/usb/hcd-musb: Emit warning when old code is used hw/xtensa/xtfpga: Emit warning when old code is used

 configure                    |  8 ++++++++
 include/hw/qdev-deprecated.h | 26 ++++++++++++++++++++++++++
 include/qom/object.h         |  6 +++---
 hw/arm/nseries.c             |  2 ++
 hw/arm/omap1.c               |  6 ++++++
 hw/arm/pxa2xx.c              |  3 +++
 hw/char/omap_uart.c          |  5 +++++
 hw/char/parallel.c           |  3 +++
 hw/char/sh_serial.c          |  3 +++
 hw/core/qdev.c               |  8 ++++++++
 hw/display/blizzard.c        |  3 +++
 hw/display/pxa2xx_lcd.c      |  3 +++
 hw/display/ramfb.c           |  3 +++
 hw/display/tc6393xb.c        |  3 +++
 hw/display/vga-isa-mm.c      |  5 +++++
 hw/display/vga.c             |  3 +++
 hw/dma/etraxfs_dma.c         |  4 +++-
 hw/dma/soc_dma.c             |  3 +++
 hw/input/lasips2.c           |  4 +++-
 hw/input/pxa2xx_keypad.c     |  3 +++
 hw/input/tsc2005.c           |  3 +++
 hw/intc/sh_intc.c            |  3 +++
 hw/m68k/mcf5206.c            |  5 +++++
 hw/m68k/mcf5208.c            |  3 +++
 hw/misc/cbus.c               |  3 +++
 hw/misc/omap_gpmc.c          |  3 +++
 hw/misc/omap_l4.c            |  3 +++
 hw/misc/omap_sdrc.c          |  3 +++
 hw/nvram/eeprom93xx.c        |  3 +++
 hw/openrisc/cputimer.c       |  3 +++
 hw/ppc/ppc405_boards.c       |  5 +++++
 hw/ppc/ppc405_uc.c           | 21 +++++++++++++++++++++
 hw/ppc/ppc4xx_devs.c         |  7 +++++++
 hw/riscv/riscv_htif.c        |  4 ++++
 hw/riscv/sifive_uart.c       |  4 ++++
 hw/sd/omap_mmc.c             |  5 +++++
 hw/sh4/r2d.c                 |  3 +++
 hw/sh4/sh7750.c              |  4 ++++
 hw/ssi/omap_spi.c            |  3 +++
 hw/timer/omap_synctimer.c    |  4 ++++
 hw/timer/sh_timer.c          |  5 +++++
 hw/usb/hcd-musb.c            |  3 +++
 hw/xtensa/xtfpga.c           |  3 +++
 43 files changed, 202 insertions(+), 5 deletions(-)
 create mode 100644 include/hw/qdev-deprecated.h
Signature · 1 line
2.21.3