Error handling fixes & cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest26 patches 14 repliesIn review
- v225 patches 13 repliesSuperseded
- v122 patches 14 repliesSuperseded
Changes in v3 from the cover letter
* PATCH 20: Can actually fail; propagate [Igor, Paolo]
* PATCH 26: New
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/26 | net/virtio: Fix failover_replug_primary() return value regressionhw/ | +1 | 0 replies | |
| 2/26 | pci: Delete useless error_propagate()hw/ | +0 | 0 replies | |
| 3/26 | Clean up some calls to ignore Error objects the right waychardev/ hw/ hw/ +2 more | +7 | 1 reply | |
| 4/26 | tests: Use &error_abort where appropriatetests/ tests/ tests/ +4 more | +59 | 0 replies | |
| 5/26 | tests: Use error_free_or_abort() where appropriatetests/ tests/ tests/ +4 more | +14 | 0 replies | |
| 6/26 | usb/dev-mtp: Fix Error double free after inotify failurehw/ | +0 | 1 reply | |
| 7/26 | spapr: Plug minor memory leak in spapr_machine_init()hw/ | +1 | 0 replies | |
| 8/26 | qga: Plug unlikely memory leak in guest-set-memory-blocksqga/ | +1 | 0 replies | |
| 9/26 | sd/milkymist-memcard: Plug minor memory leak in realizehw/ | +2 | 1 reply | |
| 10/26 | test-util-filemonitor: Plug unlikely memory leaktests/ | +1 | 1 reply | |
| 11/26 | vnc: Plug minor memory leak in vnc_display_open()ui/ | +1 | 1 reply | |
| 12/26 | aspeed: Clean up roundabout error propagationhw/ hw/ | +8 | 0 replies | |
| 13/26 | qdev: Drop qbus_set_bus_hotplug_handler() parameter @errphw/ hw/ hw/ +3 more | +7 | 0 replies | |
| 14/26 | qdev: Drop qbus_set_hotplug_handler() parameter @errphw/ hw/ hw/ +12 more | +22 | 0 replies | |
| 15/26 | hw: Fix error API violation around object_property_set_link()hw/ hw/ hw/ +5 more | +16 | 1 reply | |
| 16/26 | hw/arm: Drop useless object_property_set_link() error handlinghw/ hw/ hw/ +2 more | +24 | 0 replies | |
| 17/26 | riscv/sifive_u: Fix sifive_u_soc_realize() error API violationshw/ | +9 | 0 replies | |
| 18/26 | riscv_hart: Fix riscv_harts_realize() error API violationshw/ | +5 | 0 replies | |
| 19/26 | mips/cps: Fix mips_cps_realize() error API violationshw/ | +19 | 0 replies | |
| 20/26 | x86: Fix x86_cpu_new() error handlinghw/ | +5 | 2 replies | |
| 21/26 | amd_iommu: Fix amdvi_realize() error API violationhw/ | +4 | 0 replies | |
| 22/26 | arm/stm32f205 arm/stm32f405: Fix realize error API violationhw/ hw/ | +2 | 2 replies | |
| 23/26 | aspeed: Fix realize error API violationhw/ hw/ | +6 | 1 reply | |
| 24/26 | hw/arm/armsse: Fix armsse_realize() error API violationhw/ | +4 | 1 reply | |
| 25/26 | arm/{bcm2835, fsl-imx25, fsl-imx6}: Fix realize error API violationshw/ hw/ hw/ | +14 | 1 reply | |
| 26/26 | migration/rdma: Plug memory leaks in qemu_rdma_registration_stop()migration/ | +9 | 1 reply |
Reviews trailers per patch
22 of 26 patches have a Reviewed-by or Acked-by.
| Patch | Alistair Francis | Eric Blake | Greg Kurz | David Gibson | Cédric Le Goater | Thomas Huth | zhanghailiang | Jens Freimann | Michael S. Tsirkin | Eric Auger | Philippe Mathieu-Daudé | Daniel P. Berrangé | Dr. David Alan Gilbert | Mark Cave-Ayland | Paolo Bonzini |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1/26 | R-b | R-b | |||||||||||||
| 2/26 | R-b | R-b | |||||||||||||
| 3/26 | R-b | R-b | |||||||||||||
| 4/26 | R-b | ||||||||||||||
| 5/26 | R-b | ||||||||||||||
| 6/26 | R-b | ||||||||||||||
| 7/26 | R-b | A-b | |||||||||||||
| 8/26 | R-b | ||||||||||||||
| 9/26 | R-b | ||||||||||||||
| 10/26 | R-b | ||||||||||||||
| 11/26 | R-b | ||||||||||||||
| 12/26 | R-b | ||||||||||||||
| 13/26 | |||||||||||||||
| 14/26 | |||||||||||||||
| 15/26 | R-b | R-b | R-b | ||||||||||||
| 16/26 | R-b | ||||||||||||||
| 17/26 | R-b | ||||||||||||||
| 18/26 | R-b | ||||||||||||||
| 19/26 | |||||||||||||||
| 20/26 | R-b | ||||||||||||||
| 21/26 | |||||||||||||||
| 22/26 | R-b | R-b | |||||||||||||
| 23/26 | R-b | ||||||||||||||
| 24/26 | R-b | ||||||||||||||
| 25/26 | R-b | ||||||||||||||
| 26/26 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 15 reviewers.
Cover letter [PATCH v3 00/26] Error handling fixes & cleanups
This series addresses a number of error handling issues I found while working on error handling improvements.
v3:
* PATCH 20: Can actually fail; propagate [Igor, Paolo]
* PATCH 26: New
Markus Armbruster (26):
net/virtio: Fix failover_replug_primary() return value regression
pci: Delete useless error_propagate()
Clean up some calls to ignore Error objects the right way
tests: Use &error_abort where appropriate
tests: Use error_free_or_abort() where appropriate usb/dev-mtp: Fix Error double free after inotify failure
spapr: Plug minor memory leak in spapr_machine_init()
qga: Plug unlikely memory leak in guest-set-memory-blocks sd/milkymist-memcard: Plug minor memory leak in realize
test-util-filemonitor: Plug unlikely memory leak
vnc: Plug minor memory leak in vnc_display_open()
aspeed: Clean up roundabout error propagation
qdev: Drop qbus_set_bus_hotplug_handler() parameter @errp
qdev: Drop qbus_set_hotplug_handler() parameter @errp
hw: Fix error API violation around object_property_set_link() hw/arm: Drop useless object_property_set_link() error handling riscv/sifive_u: Fix sifive_u_soc_realize() error API violations
riscv_hart: Fix riscv_harts_realize() error API violations mips/cps: Fix mips_cps_realize() error API violations
x86: Fix x86_cpu_new() error handling
amd_iommu: Fix amdvi_realize() error API violation arm/stm32f205 arm/stm32f405: Fix realize error API violation
aspeed: Fix realize error API violation
hw/arm/armsse: Fix armsse_realize() error API violation arm/{bcm2835,fsl-imx25,fsl-imx6}: Fix realize error API violations migration/rdma: Plug memory leaks in qemu_rdma_registration_stop()
include/hw/qdev-core.h | 5 +- chardev/char-socket.c | 6 +- hw/9pfs/9p.c | 6 +- hw/acpi/pcihp.c | 3 +- hw/acpi/piix4.c | 2 +- hw/arm/armsse.c | 61 +++++----------- hw/arm/armv7m.c | 7 +- hw/arm/aspeed_ast2600.c | 35 ++++----- hw/arm/aspeed_soc.c | 29 +++----- hw/arm/bcm2835_peripherals.c | 12 ++-- hw/arm/fsl-imx25.c | 12 ++-- hw/arm/fsl-imx6.c | 12 ++-- hw/arm/nrf51_soc.c | 6 +- hw/arm/stm32f205_soc.c | 2 +- hw/arm/stm32f405_soc.c | 2 +- hw/arm/virt.c | 4 +- hw/char/virtio-serial-bus.c | 4 +- hw/core/bus.c | 8 +-- hw/display/virtio-gpu-pci.c | 2 +- hw/display/virtio-vga.c | 2 +- hw/dma/sparc32_dma.c | 6 +- hw/dma/xilinx_axidma.c | 12 +--- hw/i386/amd_iommu.c | 6 +- hw/i386/x86.c | 8 ++- hw/mips/cps.c | 35 +++++---- hw/misc/macio/macio.c | 3 +- hw/net/virtio-net.c | 2 +- hw/net/xilinx_axienet.c | 12 +--- hw/pci/pci.c | 3 - hw/pci/pcie.c | 2 +- hw/pci/shpc.c | 2 +- hw/ppc/spapr.c | 4 +- hw/ppc/spapr_drc.c | 4 +- hw/ppc/spapr_pci.c | 4 +- hw/riscv/riscv_hart.c | 14 ++-- hw/riscv/sifive_u.c | 12 +++- hw/s390x/ap-bridge.c | 2 +- hw/s390x/css-bridge.c | 2 +- hw/s390x/s390-pci-bus.c | 14 +--- hw/scsi/scsi-bus.c | 2 +- hw/scsi/virtio-scsi.c | 4 +- hw/scsi/vmw_pvscsi.c | 2 +- hw/sd/milkymist-memcard.c | 5 +- hw/usb/bus.c | 2 +- hw/usb/dev-mtp.c | 2 - hw/usb/dev-smartcard-reader.c | 2 +- hw/virtio/virtio-iommu-pci.c | 2 +- hw/xen/xen-bus.c | 2 +- hw/xen/xen-legacy-backend.c | 2 +- migration/rdma.c | 19 +++-- qga/commands-posix.c | 1 + tests/check-block-qdict.c | 24 ++----- tests/check-qobject.c | 5 +- tests/check-qom-proplist.c | 14 ++-- tests/test-base64.c | 3 +- tests/test-bdrv-graph-mod.c | 4 +- tests/test-block-iothread.c | 3 +- tests/test-crypto-cipher.c | 8 +-- tests/test-io-task.c | 4 +- tests/test-logging.c | 12 +--- tests/test-qemu-opts.c | 22 ++---- tests/test-replication.c | 109 +++++++++-------------------- tests/test-string-input-visitor.c | 33 +++------ tests/test-string-output-visitor.c | 16 ++--- tests/test-util-filemonitor.c | 1 + ui/vnc.c | 6 +- 66 files changed, 240 insertions(+), 436 deletions(-)
Signature · 1 line
2.26.2