Skip to content

Error handling fixes & cleanups

Markus Armbruster qemu-arm qemu-devel qemu-riscv 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest26 patches 14 repliesIn review
  2. v225 patches 13 repliesSuperseded
  3. v122 patches 14 repliesSuperseded

Changes in v3 from the cover letter

* PATCH 20: Can actually fail; propagate [Igor, Paolo]
* PATCH 26: New

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26net/virtio: Fix failover_replug_primary() return value regressionhw/net/virtio-net.c+1 -10 replies
2/26pci: Delete useless error_propagate()hw/pci/pci.c+0 -30 replies
3/26Clean up some calls to ignore Error objects the right waychardev/char-socket.c hw/9pfs/9p.c hw/arm/virt.c +2 more+7 -161 reply
4/26tests: Use &error_abort where appropriatetests/check-qobject.c tests/check-qom-proplist.c tests/test-logging.c +4 more+59 -1450 replies
5/26tests: Use error_free_or_abort() where appropriatetests/check-block-qdict.c tests/check-qom-proplist.c tests/test-base64.c +4 more+14 -390 replies
6/26usb/dev-mtp: Fix Error double free after inotify failurehw/usb/dev-mtp.c+0 -21 reply
7/26spapr: Plug minor memory leak in spapr_machine_init()hw/ppc/spapr.c+1 -00 replies
8/26qga: Plug unlikely memory leak in guest-set-memory-blocksqga/commands-posix.c+1 -00 replies
9/26sd/milkymist-memcard: Plug minor memory leak in realizehw/sd/milkymist-memcard.c+2 -31 reply
10/26test-util-filemonitor: Plug unlikely memory leaktests/test-util-filemonitor.c+1 -01 reply
11/26vnc: Plug minor memory leak in vnc_display_open()ui/vnc.c+1 -21 reply
12/26aspeed: Clean up roundabout error propagationhw/arm/aspeed_ast2600.c hw/arm/aspeed_soc.c+8 -120 replies
13/26qdev: Drop qbus_set_bus_hotplug_handler() parameter @errphw/core/bus.c hw/scsi/scsi-bus.c hw/usb/bus.c +3 more+7 -70 replies
14/26qdev: Drop qbus_set_hotplug_handler() parameter @errphw/acpi/pcihp.c hw/acpi/piix4.c hw/char/virtio-serial-bus.c +12 more+22 -330 replies
15/26hw: Fix error API violation around object_property_set_link()hw/display/virtio-gpu-pci.c hw/display/virtio-vga.c hw/dma/sparc32_dma.c +5 more+16 -291 reply
16/26hw/arm: Drop useless object_property_set_link() error handlinghw/arm/armsse.c hw/arm/armv7m.c hw/arm/aspeed_ast2600.c +2 more+24 -760 replies
17/26riscv/sifive_u: Fix sifive_u_soc_realize() error API violationshw/riscv/sifive_u.c+9 -30 replies
18/26riscv_hart: Fix riscv_harts_realize() error API violationshw/riscv/riscv_hart.c+5 -90 replies
19/26mips/cps: Fix mips_cps_realize() error API violationshw/mips/cps.c+19 -100 replies
20/26x86: Fix x86_cpu_new() error handlinghw/i386/x86.c+5 -32 replies
21/26amd_iommu: Fix amdvi_realize() error API violationhw/i386/amd_iommu.c+4 -20 replies
22/26arm/stm32f205 arm/stm32f405: Fix realize error API violationhw/arm/stm32f205_soc.c hw/arm/stm32f405_soc.c+2 -22 replies
23/26aspeed: Fix realize error API violationhw/arm/aspeed_ast2600.c hw/arm/aspeed_soc.c+6 -41 reply
24/26hw/arm/armsse: Fix armsse_realize() error API violationhw/arm/armsse.c+4 -41 reply
25/26arm/{bcm2835, fsl-imx25, fsl-imx6}: Fix realize error API violationshw/arm/bcm2835_peripherals.c hw/arm/fsl-imx25.c hw/arm/fsl-imx6.c+14 -221 reply
26/26migration/rdma: Plug memory leaks in qemu_rdma_registration_stop()migration/rdma.c+9 -101 reply

Reviews trailers per patch

22 of 26 patches have a Reviewed-by or Acked-by.

PatchAlistair FrancisEric BlakeGreg KurzDavid GibsonCédric Le GoaterThomas HuthzhanghailiangJens FreimannMichael S. TsirkinEric AugerPhilippe Mathieu-DaudéDaniel P. BerrangéDr. David Alan GilbertMark Cave-AylandPaolo Bonzini
1/26R-b R-b
2/26R-b R-b
3/26R-b R-b
4/26R-b
5/26R-b
6/26R-b
7/26R-b A-b
8/26R-b
9/26R-b
10/26R-b
11/26R-b
12/26R-b
13/26
14/26
15/26R-b R-b R-b
16/26R-b
17/26R-b
18/26R-b
19/26
20/26R-b
21/26
22/26R-b R-b
23/26R-b
24/26R-b
25/26R-b
26/26R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 15 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/26] Error handling fixes & cleanups

This series addresses a number of error handling issues I found while working on error handling improvements.

v3:
* PATCH 20: Can actually fail; propagate [Igor, Paolo]
* PATCH 26: New

Markus Armbruster (26):
net/virtio: Fix failover_replug_primary() return value regression
pci: Delete useless error_propagate()
Clean up some calls to ignore Error objects the right way
tests: Use &error_abort where appropriate
tests: Use error_free_or_abort() where appropriate usb/dev-mtp: Fix Error double free after inotify failure
spapr: Plug minor memory leak in spapr_machine_init()
qga: Plug unlikely memory leak in guest-set-memory-blocks sd/milkymist-memcard: Plug minor memory leak in realize
test-util-filemonitor: Plug unlikely memory leak
vnc: Plug minor memory leak in vnc_display_open()
aspeed: Clean up roundabout error propagation
qdev: Drop qbus_set_bus_hotplug_handler() parameter @errp
qdev: Drop qbus_set_hotplug_handler() parameter @errp
hw: Fix error API violation around object_property_set_link() hw/arm: Drop useless object_property_set_link() error handling riscv/sifive_u: Fix sifive_u_soc_realize() error API violations
riscv_hart: Fix riscv_harts_realize() error API violations mips/cps: Fix mips_cps_realize() error API violations
x86: Fix x86_cpu_new() error handling
amd_iommu: Fix amdvi_realize() error API violation arm/stm32f205 arm/stm32f405: Fix realize error API violation
aspeed: Fix realize error API violation
hw/arm/armsse: Fix armsse_realize() error API violation arm/{bcm2835,fsl-imx25,fsl-imx6}: Fix realize error API violations migration/rdma: Plug memory leaks in qemu_rdma_registration_stop()

 include/hw/qdev-core.h             |   5 +-
 chardev/char-socket.c              |   6 +-
 hw/9pfs/9p.c                       |   6 +-
 hw/acpi/pcihp.c                    |   3 +-
 hw/acpi/piix4.c                    |   2 +-
 hw/arm/armsse.c                    |  61 +++++-----------
 hw/arm/armv7m.c                    |   7 +-
 hw/arm/aspeed_ast2600.c            |  35 ++++-----
 hw/arm/aspeed_soc.c                |  29 +++-----
 hw/arm/bcm2835_peripherals.c       |  12 ++--
 hw/arm/fsl-imx25.c                 |  12 ++--
 hw/arm/fsl-imx6.c                  |  12 ++--
 hw/arm/nrf51_soc.c                 |   6 +-
 hw/arm/stm32f205_soc.c             |   2 +-
 hw/arm/stm32f405_soc.c             |   2 +-
 hw/arm/virt.c                      |   4 +-
 hw/char/virtio-serial-bus.c        |   4 +-
 hw/core/bus.c                      |   8 +--
 hw/display/virtio-gpu-pci.c        |   2 +-
 hw/display/virtio-vga.c            |   2 +-
 hw/dma/sparc32_dma.c               |   6 +-
 hw/dma/xilinx_axidma.c             |  12 +---
 hw/i386/amd_iommu.c                |   6 +-
 hw/i386/x86.c                      |   8 ++-
 hw/mips/cps.c                      |  35 +++++----
 hw/misc/macio/macio.c              |   3 +-
 hw/net/virtio-net.c                |   2 +-
 hw/net/xilinx_axienet.c            |  12 +---
 hw/pci/pci.c                       |   3 -
 hw/pci/pcie.c                      |   2 +-
 hw/pci/shpc.c                      |   2 +-
 hw/ppc/spapr.c                     |   4 +-
 hw/ppc/spapr_drc.c                 |   4 +-
 hw/ppc/spapr_pci.c                 |   4 +-
 hw/riscv/riscv_hart.c              |  14 ++--
 hw/riscv/sifive_u.c                |  12 +++-
 hw/s390x/ap-bridge.c               |   2 +-
 hw/s390x/css-bridge.c              |   2 +-
 hw/s390x/s390-pci-bus.c            |  14 +---
 hw/scsi/scsi-bus.c                 |   2 +-
 hw/scsi/virtio-scsi.c              |   4 +-
 hw/scsi/vmw_pvscsi.c               |   2 +-
 hw/sd/milkymist-memcard.c          |   5 +-
 hw/usb/bus.c                       |   2 +-
 hw/usb/dev-mtp.c                   |   2 -
 hw/usb/dev-smartcard-reader.c      |   2 +-
 hw/virtio/virtio-iommu-pci.c       |   2 +-
 hw/xen/xen-bus.c                   |   2 +-
 hw/xen/xen-legacy-backend.c        |   2 +-
 migration/rdma.c                   |  19 +++--
 qga/commands-posix.c               |   1 +
 tests/check-block-qdict.c          |  24 ++-----
 tests/check-qobject.c              |   5 +-
 tests/check-qom-proplist.c         |  14 ++--
 tests/test-base64.c                |   3 +-
 tests/test-bdrv-graph-mod.c        |   4 +-
 tests/test-block-iothread.c        |   3 +-
 tests/test-crypto-cipher.c         |   8 +--
 tests/test-io-task.c               |   4 +-
 tests/test-logging.c               |  12 +---
 tests/test-qemu-opts.c             |  22 ++----
 tests/test-replication.c           | 109 +++++++++--------------------
 tests/test-string-input-visitor.c  |  33 +++------
 tests/test-string-output-visitor.c |  16 ++---
 tests/test-util-filemonitor.c      |   1 +
 ui/vnc.c                           |   6 +-
 66 files changed, 240 insertions(+), 436 deletions(-)
Signature · 1 line
2.26.2