Skip to content

net: phy: call phy_disable_interrupts() in phy_init_hw()

Jisheng Zhang lkml netdev 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesNew
  2. v32 patches 6 repliesSuperseded
  3. v22 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches0 repliesSuperseded

Changes in v4 from the cover letter

- call phy_disable_interrupts() have interrupts disabled first then config_init, thank Florian

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: phy: make phy_disable_interrupts() non-staticdrivers/net/phy/phy.c include/linux/phy.h+2 -10 replies
2/2net: phy: call phy_disable_interrupts() in phy_init_hw()drivers/net/phy/phy_device.c+4 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

We face an issue with rtl8211f, a pin is shared between INTB and PMEB, and the PHY Register Accessible Interrupt is enabled by default, so the INTB/PMEB pin is always active in polling mode case.

As Heiner pointed out "I was thinking about calling phy_disable_interrupts() in phy_init_hw(), to have a defined init state as we don't know in which state the PHY is if the PHY driver is loaded. We shouldn't assume that it's the chip power-on defaults, BIOS or boot loader could have changed this. Or in case of dual-boot systems the other OS could leave the PHY in whatever state."

patch1 makes phy_disable_interrupts() non-static so that it could be used in phy_init_hw() to have a defined init state.

patch2 calls phy_disable_interrupts() in phy_init_hw() to have a defined init state.

Since v3:
- call phy_disable_interrupts() have interrupts disabled first then config_init, thank Florian

Since v2:
- Don't export phy_disable_interrupts() but just make it non-static

Since v1:
- EXPORT the correct symbol

Jisheng Zhang (2):
net: phy: make phy_disable_interrupts() non-static
net: phy: call phy_disable_interrupts() in phy_init_hw()

 drivers/net/phy/phy.c        | 2 +-
 drivers/net/phy/phy_device.c | 4 ++++
 include/linux/phy.h          | 1 +
 3 files changed, 6 insertions(+), 1 deletion(-)
Signature · 1 line
2.27.0