Skip to content

drm/ast: Managed modesetting

Thomas Zimmermann dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest14 patches 5 repliesIn review
  2. v114 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* use to_ast_private() instead of
struct drm_device.dev_private (Sam)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/ast: Move cursor functions to ast_cursor.cdrivers/gpu/drm/ast/Makefile drivers/gpu/drm/ast/ast_cursor.c drivers/gpu/drm/ast/ast_drv.h +1 more+229 -1960 replies
2/14drm/ast: Pass struct ast_private instance to cursor init/fini functionsdrivers/gpu/drm/ast/ast_cursor.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+9 -80 replies
3/14drm/ast: Move cursor fb pinning and mapping into helperdrivers/gpu/drm/ast/ast_cursor.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+59 -420 replies
4/14drm/ast: Update cursor image and checksum from same functiondrivers/gpu/drm/ast/ast_cursor.c+5 -190 replies
5/14drm/ast: Move cursor pageflip into helperdrivers/gpu/drm/ast/ast_cursor.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+21 -130 replies
6/14drm/ast: Replace ast_cursor_move() with ast_cursor_show()drivers/gpu/drm/ast/ast_cursor.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+35 -230 replies
7/14drm/ast: Don't enable HW cursors twice during atomic updatedrivers/gpu/drm/ast/ast_mode.c+0 -60 replies
8/14drm/ast: Add helper to hide cursordrivers/gpu/drm/ast/ast_cursor.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+7 -10 replies
9/14drm/ast: Keep cursor HW BOs mappeddrivers/gpu/drm/ast/ast_cursor.c drivers/gpu/drm/ast/ast_drv.h+21 -280 replies
10/14drm/ast: Managed cursor releasedrivers/gpu/drm/ast/ast_cursor.c drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+22 -200 replies
11/14drm/ast: Init cursors before creating modesetting structuresdrivers/gpu/drm/ast/ast_mode.c+4 -10 replies
12/14drm/ast: Replace struct ast_crtc with struct drm_crtcdrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_mode.c+6 -103 replies
13/14drm/ast: Use managed mode-config initdrivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_main.c drivers/gpu/drm/ast/ast_mode.c+3 -80 replies
14/14drm/ast: Initialize mode setting in ast_mode_config_init()drivers/gpu/drm/ast/ast_drv.h drivers/gpu/drm/ast/ast_main.c drivers/gpu/drm/ast/ast_mode.c+41 -370 replies

Reviews trailers per patch

2 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSam Ravnborg
SeriesA-b
1/14A-b
2/14A-b
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/14] drm/ast: Managed modesetting

This is the first patchset to convert ast to use managed interfaces. These patches address modesetting. I expect that there will be at least one more set of patches for memory management and one for device structures.

Patches 1 to 11 tackle HW cursor handling. The overall point is to get cursor support out of the plane functions and put the code into helpers. There are quite a few improvements that make cursors easier and faster to use. Patch 10 converts cursors to managed release.

With cursors out of the way, modesetting initialization is much more simple. Patches 12 to 14 put all related code next to each other and switch to managed initialization.

The patchset was tested on AST2100 hardware.

v2:
* use to_ast_private() instead of
struct drm_device.dev_private (Sam)

Thomas Zimmermann (14):
drm/ast: Move cursor functions to ast_cursor.c drm/ast: Pass struct ast_private instance to cursor init/fini
functions
drm/ast: Move cursor fb pinning and mapping into helper drm/ast: Update cursor image and checksum from same function drm/ast: Move cursor pageflip into helper
drm/ast: Replace ast_cursor_move() with ast_cursor_show() drm/ast: Don't enable HW cursors twice during atomic update drm/ast: Add helper to hide cursor
drm/ast: Keep cursor HW BOs mapped
drm/ast: Managed cursor release
drm/ast: Init cursors before creating modesetting structures drm/ast: Replace struct ast_crtc with struct drm_crtc drm/ast: Use managed mode-config init
drm/ast: Initialize mode setting in ast_mode_config_init()

 drivers/gpu/drm/ast/Makefile     |   3 +-
 drivers/gpu/drm/ast/ast_cursor.c | 289 +++++++++++++++++++++++++++
 drivers/gpu/drm/ast/ast_drv.h    |  19 +-
 drivers/gpu/drm/ast/ast_main.c   |  35 +---
 drivers/gpu/drm/ast/ast_mode.c   | 322 ++++++-------------------------
 5 files changed, 359 insertions(+), 309 deletions(-)
 create mode 100644 drivers/gpu/drm/ast/ast_cursor.c

--
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel