Skip to content

bcache: extend bucket size to 32bit width

Coly Li linux-bcache linux-block 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest16 patches 0 repliesNew
  2. v316 patches 16 repliesSuperseded
  3. v217 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC16 patches0 repliesSuperseded

Changelog from the cover letter

v4: Update with Hannes' comments of v3 series code review.
v3: Update with Hannes' comments of v2 series code review.
v2: several bug fixes, and add sysfs file to display cache set feature
sets information.
v1: initial RFC version.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16bcache: add read_super_common() to read major part of super blockdrivers/md/bcache/super.c+63 -480 replies
2/16bcache: add more accurate error information in read_super_common()drivers/md/bcache/super.c+14 -50 replies
3/16bcache: disassemble the big if() checks in bch_cache_set_alloc()drivers/md/bcache/super.c+37 -150 replies
4/16bcache: fix super block seq numbers comparision in register_cache_set()drivers/md/bcache/super.c+8 -10 replies
5/16bcache: increase super block version for cache device and backing devicedrivers/md/bcache/features.h drivers/md/bcache/super.c include/uapi/linux/bcache.h+128 -110 replies
6/16bcache: move bucket related code into read_super_common()drivers/md/bcache/super.c+5 -50 replies
7/16bcache: struct cache_sb is only for in-memory super block nowinclude/uapi/linux/bcache.h+6 -40 replies
8/16bcache: introduce meta_bucket_pages() related helper routinesdrivers/md/bcache/bcache.h drivers/md/bcache/super.c+23 -00 replies
9/16bcache: handle c->uuids properly for bucket size > 8MBdrivers/md/bcache/super.c+6 -40 replies
10/16bcache: handle cache prio_buckets and disk_buckets properly for bucket size > 8MBdrivers/md/bcache/bcache.h drivers/md/bcache/super.c+10 -90 replies
11/16bcache: handle cache set verify_ondisk properly for bucket size > 8MBdrivers/md/bcache/btree.c+10 -20 replies
12/16bcache: handle btree node memory allocation properly for bucket size > 8MBdrivers/md/bcache/super.c+1 -10 replies
13/16bcache: add bucket_size_hi into struct cache_sb_disk for large bucketdrivers/md/bcache/alloc.c drivers/md/bcache/features.c drivers/md/bcache/features.h +3 more+52 -110 replies
14/16bcache: add sysfs file to display feature sets information of cache setdrivers/md/bcache/Makefile drivers/md/bcache/features.c drivers/md/bcache/features.h +1 more+73 -10 replies
15/16bcache: avoid extra memory allocation from mempool c->fill_iterdrivers/md/bcache/super.c+1 -10 replies
16/16bcache: avoid extra memory consumption in struct bbio for large bucket sizedrivers/md/bcache/io.c drivers/md/bcache/super.c+2 -20 replies

Reviews trailers per patch

13 of 16 patches have a Reviewed-by or Acked-by.

PatchHannes Reinecke
1/16
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16
14/16
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/16] bcache: extend bucket size to 32bit width

This patch series is an effort to extent bucket_size from 16bit to 32bit width. This is the code base for next step to use zoned device as cache device.

In this series, these changes should be noticed,
- Increase the super block version to
BCACHE_SB_VERSION_CDEV_WITH_FEATURES 5
BCACHE_SB_VERSION_BDEV_WITH_FEATURES 6
- The new version adds 3 new members,

        __le64          feature_compat;
        __le64          feature_incompat;
        __le64          feature_ro_compat;

If new feature added will change the on-disk format, just setting the feature set bits, no need to upstream super block version.
- The in-memory struct cache_sb does not exactly map the on-disk struct cache_sb_disk.
- Add 32bit bucket_size_hi in struct cache_sb_disk,

        __le32          bucket_size_hi;

In theory bucket_size can be extended to 48bit, but now 32bit width is big enough.
- Other changes to follow the large bucket size.

The changes are mostly on cache device, except the super block update there is no change about the backing device.

Any code review comments or suggestion is welcome. Thanks in advance.

Coly Li
---
Changelog:
v4: Update with Hannes' comments of v3 series code review.
v3: Update with Hannes' comments of v2 series code review.
v2: several bug fixes, and add sysfs file to display cache set feature
sets information.
v1: initial RFC version.

Coly Li (16):
bcache: add read_super_common() to read major part of super block
bcache: add more accurate error information in read_super_common()
bcache: disassemble the big if() checks in bch_cache_set_alloc()
bcache: fix super block seq numbers comparision in
register_cache_set()
bcache: increase super block version for cache device and backing
device
bcache: move bucket related code into read_super_common()
bcache: struct cache_sb is only for in-memory super block now
bcache: introduce meta_bucket_pages() related helper routines
bcache: handle c->uuids properly for bucket size > 8MB
bcache: handle cache prio_buckets and disk_buckets properly for bucket
size > 8MB
bcache: handle cache set verify_ondisk properly for bucket size > 8MB
bcache: handle btree node memory allocation properly for bucket size >

    8MB

bcache: add bucket_size_hi into struct cache_sb_disk for large bucket
bcache: add sysfs file to display feature sets information of cache
set
bcache: avoid extra memory allocation from mempool c->fill_iter
bcache: avoid extra memory consumption in struct bbio for large bucket
size

 drivers/md/bcache/Makefile   |   2 +-
 drivers/md/bcache/alloc.c    |   2 +-
 drivers/md/bcache/bcache.h   |  29 +++-
 drivers/md/bcache/btree.c    |  12 +-
 drivers/md/bcache/features.c |  75 ++++++++++
 drivers/md/bcache/features.h |  86 ++++++++++++
 drivers/md/bcache/io.c       |   2 +-
 drivers/md/bcache/movinggc.c |   4 +-
 drivers/md/bcache/super.c    | 261 ++++++++++++++++++++++++-----------
 drivers/md/bcache/sysfs.c    |  14 ++
 include/uapi/linux/bcache.h  |  38 +++--
 11 files changed, 422 insertions(+), 103 deletions(-)
 create mode 100644 drivers/md/bcache/features.c
 create mode 100644 drivers/md/bcache/features.h
Signature · 1 line
2.26.2