Skip to content

Allow guest-get-fsinfo also for non-PCI devices

Thomas Huth qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Use g_new0 instead of g_malloc0 (as suggested by Daniel)
- Init fields to -1 explicitely, not via memset (Daniel)
- Add the fourth patch to also fill in virtio information on s390x

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4qga/qapi-schema: Document -1 for invalid PCI address fieldsqga/qapi-schema.json+1 -10 replies
2/4qga/commands-posix: Rework build_guest_fsinfo_for_real_device() functionqga/commands-posix.c+41 -241 reply
3/4qga/commands-posix: Move the udev code from the pci to the generic functionqga/commands-posix.c+33 -291 reply
4/4qga/commands-posix: Support fsinfo for non-PCI virtio devices, tooqga/commands-posix.c+41 -11 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices

The information that can be retrieved via UDEV is also usable for non-PCI devices. So let's allow build_guest_fsinfo_for_real_device() on non-PCI devices, too. This is required to fix the bug that CCW devices show up without "Target" when running libvirt's "virsh domfsinfo" command (see
https://bugzilla.redhat.com/show_bug.cgi?id=1755075 for details).

v2:
- Use g_new0 instead of g_malloc0 (as suggested by Daniel)
- Init fields to -1 explicitely, not via memset (Daniel)
- Add the fourth patch to also fill in virtio information on s390x

Thomas Huth (4):
qga/qapi-schema: Document -1 for invalid PCI address fields qga/commands-posix: Rework build_guest_fsinfo_for_real_device()
function
qga/commands-posix: Move the udev code from the pci to the generic
function
qga/commands-posix: Support fsinfo for non-PCI virtio devices, too

 qga/commands-posix.c | 157 ++++++++++++++++++++++++++++++-------------
 qga/qapi-schema.json |   2 +-
 2 files changed, 110 insertions(+), 49 deletions(-)
Signature · 1 line
2.18.1