Skip to content

virtiofsd: Add a unprivileged passthrough mode

Vivek Goyal qemu-devel virtio-fs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesIn review
  2. v1 RFC5 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5virtiofsd: Add notion of unprivileged modetools/virtiofsd/passthrough_ll.c+8 -01 reply
2/5virtiofsd: create lock/pid file in per user cache dirtools/virtiofsd/fuse_virtio.c+14 -11 reply
3/5virtiofsd: open /proc/self/fd/ in sandbox=NONE modetools/virtiofsd/passthrough_ll.c+12 -11 reply
4/5virtiofsd: Open lo->source while setting up root in sandbox=NONE modetools/virtiofsd/passthrough_ll.c+4 -13 replies
5/5virtiofsd: Skip setup_capabilities() in sandbox=NONE modetools/virtiofsd/passthrough_ll.c+2 -11 reply

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchDr. David Alan Gilbert
1/5
2/5R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] virtiofsd: Add a unprivileged passthrough mode

Hi,

This is V2 of patches. Only change since last version is handling of lock/pid file creation as per the comments from Daniel Berrange.

I can't think of any more changes needed. As a unpriviliged user inside VM I can do simple operations like create/remove/read/write files.

For more testing, I probably need a testsuite which runs as unpriviliged user. pjdfstests needs to run as root and this does not work in this setup as creation of files as root fails. (On host, daemon tries to switch to root uid and that fails).

So as of now, I think these are the minimum changes needed to support unprivileged passthrough mode of virtiofsd.

Thanks
Vivek

Vivek Goyal (5):
virtiofsd: Add notion of unprivileged mode
virtiofsd: create lock/pid file in per user cache dir
virtiofsd: open /proc/self/fd/ in sandbox=NONE mode
virtiofsd: Open lo->source while setting up root in sandbox=NONE mode
virtiofsd: Skip setup_capabilities() in sandbox=NONE mode

 tools/virtiofsd/fuse_virtio.c    | 15 ++++++++++++++-
 tools/virtiofsd/passthrough_ll.c | 29 ++++++++++++++++++++++++++---
 2 files changed, 40 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.4