Skip to content

selective merging of system ram resources

David Hildenbrand kexec linux-acpi linux-hyperv linux-mm linux-nvdimm linux-s390 linuxppc-dev lkml nvdimm virtualization xen-devel 4 versions – Applied

Status from this message: [merged] kernel-resource-move-and-rename-ioresource_mem_driver_managed.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 6 repliesApplied 8/8
  2. v37 patches 4 repliesSuperseded
  3. v27 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches6 repliesSuperseded

Changes in v4 from the cover letter

- "mm/memory_hotplug: guard more declarations by CONFIG_MEMORY_HOTPLUG" -- Fix configs without CONFIG_MEMORY_HOTPLUG with the new mhp_t type -- Did a buch of cross-compiles with different configs, hope there isn't anything I missed.

Patches in v4 All 8 applied

#Subject and filesSizeRepliesApplied
1/8kernel/resource: make release_mem_region_adjustable() never failinclude/linux/ioport.h kernel/resource.c mm/memory_hotplug.c+31 -443 repliesApplied
2/8kernel/resource: move and rename IORESOURCE_MEM_DRIVER_MANAGEDinclude/linux/ioport.h kernel/kexec_file.c mm/memory_hotplug.c+6 -40 repliesApplied
3/8mm/memory_hotplug: guard more declarations by CONFIG_MEMORY_HOTPLUGinclude/linux/memory_hotplug.h mm/sparse.c+5 -90 repliesApplied
4/8mm/memory_hotplug: prepare passing flags to add_memory() and friendsarch/powerpc/platforms/powernv/memtrace.c arch/powerpc/platforms/pseries/hotplug-memory.c drivers/acpi/acpi_memhotplug.c +8 more+30 -200 repliesApplied
5/8mm/memory_hotplug: MEMHP_MERGE_RESOURCE to specify merging of System RAM resourcesinclude/linux/ioport.h include/linux/memory_hotplug.h kernel/resource.c +1 more+78 -03 repliesApplied
6/8virtio-mem: try to merge system ram resourcesdrivers/virtio/virtio_mem.c+2 -11 replyApplied
7/8xen/balloon: try to merge system ram resourcesdrivers/xen/balloon.c+1 -11 replyApplied
8/8hv_balloon: try to merge system ram resourcesdrivers/hv/hv_balloon.c+1 -11 replyApplied

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchWei LiuJuergen GrossPankaj GuptaWei YangDavid Hildenbrand
SeriesR-b R-b
1/8R-b R-b
2/8
3/8
4/8A-b R-b R-b
5/8R-b R-b
6/8R-b R-b
7/8R-b R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/8] selective merging of system ram resources

Some add_memory*() users add memory in small, contiguous memory blocks. Examples include virtio-mem, hyper-v balloon, and the XEN balloon.

This can quickly result in a lot of memory resources, whereby the actual resource boundaries are not of interest (e.g., it might be relevant for DIMMs, exposed via /proc/iomem to user space). We really want to merge added resources in this scenario where possible.

Resources are effectively stored in a list-based tree. Having a lot of resources not only wastes memory, it also makes traversing that tree more expensive, and makes /proc/iomem explode in size (e.g., requiring kexec-tools to manually merge resources when creating a kdump header. The current kexec-tools resource count limit does not allow for more than ~100GB of memory with a memory block size of 128MB on x86-64).

Let's allow to selectively merge system ram resources by specifying a new flag for add_memory*(). Patch #5 contains a /proc/iomem example. Only tested with virtio-mem.

v3 -> v4:
- "mm/memory_hotplug: guard more declarations by CONFIG_MEMORY_HOTPLUG" -- Fix configs without CONFIG_MEMORY_HOTPLUG with the new mhp_t type -- Did a buch of cross-compiles with different configs, hope there isn't anything I missed.

v2 -> v3:
- "mm/memory_hotplug: prepare passing flags to add_memory() and friends" -- Use proper __bitwise type for flags
-- Use "MHP_NONE" for empty flags
- Rebased to latest -next, added rb's

v1 -> v2:
- I had another look at v1 after vacation and didn't like it - it felt like a hack. So I want forward and added a proper flag to add_memory*(), and introduce a clean (non-racy) way to mark System RAM resources mergeable.
- "kernel/resource: move and rename IORESOURCE_MEM_DRIVER_MANAGED" -- Clean that flag up, felt wrong in the PnP section
- "mm/memory_hotplug: prepare passing flags to add_memory() and friends" -- Previously sent in other context - decided to keep Wei's ack
- "mm/memory_hotplug: MEMHP_MERGE_RESOURCE to specify merging of System RAM resources"
-- Cleaner approach to get the job done by using proper flags and only
merging the single, specified resource
- "virtio-mem: try to merge system ram resources"
"xen/balloon: try to merge system ram resources"
"hv_balloon: try to merge system ram resources"
-- Use the new flag MEMHP_MERGE_RESOURCE, much cleaner

RFC -> v1:
- Switch from rather generic "merge_child_mem_resources()" where a resource name has to be specified to "merge_system_ram_resources().
- Smaller comment/documentation/patch description changes/fixes

David Hildenbrand (8):
kernel/resource: make release_mem_region_adjustable() never fail kernel/resource: move and rename IORESOURCE_MEM_DRIVER_MANAGED mm/memory_hotplug: guard more declarations by CONFIG_MEMORY_HOTPLUG mm/memory_hotplug: prepare passing flags to add_memory() and friends mm/memory_hotplug: MEMHP_MERGE_RESOURCE to specify merging of System
RAM resources
virtio-mem: try to merge system ram resources xen/balloon: try to merge system ram resources
hv_balloon: try to merge system ram resources

 arch/powerpc/platforms/powernv/memtrace.c     |   2 +-
 .../platforms/pseries/hotplug-memory.c        |   2 +-
 drivers/acpi/acpi_memhotplug.c                |   3 +-
 drivers/base/memory.c                         |   3 +-
 drivers/dax/kmem.c                            |   2 +-
 drivers/hv/hv_balloon.c                       |   2 +-
 drivers/s390/char/sclp_cmd.c                  |   2 +-
 drivers/virtio/virtio_mem.c                   |   3 +-
 drivers/xen/balloon.c                         |   2 +-
 include/linux/ioport.h                        |  12 +-
 include/linux/memory_hotplug.h                |  35 +++---
 kernel/kexec_file.c                           |   2 +-
 kernel/resource.c                             | 109 ++++++++++++++----
 mm/memory_hotplug.c                           |  47 +++-----
 mm/sparse.c                                   |   2 +
 15 files changed, 151 insertions(+), 77 deletions(-)
Signature · 1 line
2.26.2