Skip to content

RFC Remove struct pcie_link_state and aspm_register_info

Saheed O. Bolarinwa linux-kernel-mentees 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 RFC Latest23 patches 0 repliesNew

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23PCI: Migrate ASPM info from struct pcie_link_state to struct pci_devdrivers/pci/pcie/aspm.c drivers/pci/probe.c include/linux/pci.h+4 -50 replies
2/23PCI: Add l1ss_cap and l1ss_cap_ptr to struct pci_devdrivers/pci/probe.c include/linux/pci.h+8 -00 replies
3/23PCI: Rework calc_l*_latency() to take a pci_dev *drivers/pci/pcie/aspm.c+10 -60 replies
4/23PCI: Compute aspm_register_info.support directlydrivers/pci/pcie/aspm.c+9 -30 replies
5/23PCI: Read value of aspm_register_info.l1ss_ctl1 directlydrivers/pci/pcie/aspm.c+10 -40 replies
6/23PCI: Replace aspm_register_info.l1ss_cap* with their pci_dev versiondrivers/pci/pcie/aspm.c+18 -160 replies
7/23PCI: Compute aspm_register_info.enable directlydrivers/pci/pcie/aspm.c+11 -30 replies
8/23PCI: Remove unused aspm_calc_l1ss_info() argumentsdrivers/pci/pcie/aspm.c+2 -40 replies
9/23PCI: Remove pcie_get_aspm_reg() and struct aspm_register_infodrivers/pci/pcie/aspm.c+0 -630 replies
10/23PCI: Relocate call to aspm_calc_l1ss_infodrivers/pci/pcie/aspm.c+2 -40 replies
11/23PCI: Rework and Rename aspm_calc_l1ss_info()drivers/pci/pcie/aspm.c+15 -280 replies
12/23PCI: Add ASPM and CLOCK PM states to struct pci_devdrivers/pci/pcie/aspm.c include/linux/pci.h+32 -50 replies
13/23PCI: Initialise and Update values of pci_dev's PCIe link infodrivers/pci/pcie/aspm.c+109 -240 replies
14/23PCI: Change Return and Argument values from pcie_link_state to pci_devdrivers/pci/pcie/aspm.c+76 -690 replies
15/23PCI: Replace pcie_link_state based device list with a pci_dev onedrivers/pci/pcie/aspm.c+11 -160 replies
16/23PCI: Remove Exit latencies from struct pcie_link_statedrivers/pci/pcie/aspm.c+6 -180 replies
17/23PCI: Remove .clkpm_* from struct pcie_link_statedrivers/pci/pcie/aspm.c+5 -180 replies
18/23PCI: Remove .aspm_* from struct pcie_link_statedrivers/pci/pcie/aspm.c+38 -990 replies
19/23PCI: Remove .parent from struct pcie_link_statedrivers/pci/pcie/aspm.c+2 -50 replies
20/23PCI: Remove .root from struct pcie_link_statedrivers/pci/pcie/aspm.c+4 -120 replies
21/23PCI: Remove .downstream from struct pcie_link_statedrivers/pci/pcie/aspm.c+4 -60 replies
22/23PCI: Remove .pdev from struct pcie_link_statedrivers/pci/pcie/aspm.c+52 -850 replies
23/23PCI: Remove struct pcie_link_statedrivers/pci/pcie/aspm.c include/linux/pci.h+1 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [Linux-kernel-mentees] [RFC PATCH v5 00/23] Remove struct pcie_link_state and aspm_register_info

This series removes struct pcie_link_state and struct aspm_register_info and reoganise the code in a require.

MERGE:
Please don't merge yet

ToDo
- Remove redundant functions like get_link_state()
- Are locks still needed?
- A few cleanups
- Look for any other redundant code

Saheed O. Bolarinwa (23):
PCI: Migrate ASPM info from struct pcie_link_state to struct pci_dev
PCI: Add l1ss_cap and l1ss_cap_ptr to struct pci_dev
PCI: Rework calc_l*_latency() to take a pci_dev *
PCI: Compute aspm_register_info.support directly
PCI: Read value of aspm_register_info.l1ss_ctl1 directly
PCI: Replace aspm_register_info.l1ss_cap* with their pci_dev version
PCI: Compute aspm_register_info.enable directly
PCI: Remove unused aspm_calc_l1ss_info() arguments
PCI: Remove pcie_get_aspm_reg() and struct aspm_register_info
PCI: Relocate call to aspm_calc_l1ss_info
PCI: Rework and Rename aspm_calc_l1ss_info()
PCI: Add ASPM and CLOCK PM states to struct pci_dev
PCI: Initialise and Update values of pci_dev's PCIe link info
PCI: Change Return and Argument values from pcie_link_state to pci_dev
PCI: Replace pcie_link_state based device list with a pci_dev one
PCI: Remove Exit latencies from struct pcie_link_state
PCI: Remove .clkpm_* from struct pcie_link_state
PCI: Remove .aspm_* from struct pcie_link_state
PCI: Remove .parent from struct pcie_link_state
PCI: Remove .root from struct pcie_link_state
PCI: Remove .downstream from struct pcie_link_state
PCI: Remove .pdev from struct pcie_link_state
PCI: Remove struct pcie_link_state

 drivers/pci/pcie/aspm.c | 570 ++++++++++++++++------------------------
 drivers/pci/probe.c     |   7 +
 include/linux/pci.h     |  37 ++-
 3 files changed, 267 insertions(+), 347 deletions(-)

base-commit: 5f49ff2540e2c2799cde0cfaf6af9e1f824cd393

Signature · 6 lines
2.18.4

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees