Skip to content

Remove LPC register partitioning

Chia-Wei, Wang linux-arm-kernel linux-aspeed linux-devicetree lkml openbmc 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 17 repliesIn review
  2. v45 patches 3 repliesSuperseded
  3. v35 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches7 repliesSuperseded
v14 patches8 repliesSuperseded

Changes since v2 from the cover letter

- Add v2 binding check to ensure the synchronization between the device tree change and the driver register offset fix.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5dt-bindings: aspeed-lpc: Remove LPC partitioningDocumentation/devicetree/bindings/mfd/aspeed-lpc.txt+25 -757 replies
2/5ARM: dts: Remove LPC BMC and Host partitionsarch/arm/boot/dts/aspeed-g4.dtsi arch/arm/boot/dts/aspeed-g5.dtsi arch/arm/boot/dts/aspeed-g6.dtsi+148 -1962 replies
3/5ipmi: kcs: aspeed: Adapt to new LPC DTS layoutdrivers/char/ipmi/kcs_bmc_aspeed.c+16 -113 replies
4/5pinctrl: aspeed-g5: Adapt to new LPC device tree layoutdrivers/pinctrl/aspeed/pinctrl-aspeed-g5.c+11 -63 replies
5/5soc: aspeed: Adapt to new LPC device tree layoutdrivers/soc/aspeed/aspeed-lpc-ctrl.c drivers/soc/aspeed/aspeed-lpc-snoop.c+29 -142 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchHaiyue WangLinus WalleijAndrew JefferyCorey MinyardRob Herring
1/5R-b A-b
2/5R-b T-b
3/5A-b R-b A-b
4/5A-b R-b T-b
5/5R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/5] Remove LPC register partitioning

The LPC controller has no concept of the BMC and the Host partitions. The incorrect partitioning can impose unnecessary range restrictions on register access through the syscon regmap interface.

For instance, HICRB contains the I/O port address configuration of KCS channel 1/2. However, the KCS#1/#2 drivers cannot access HICRB as it is located at the other LPC partition.

In addition, to be backward compatible, the newly added HW control bits could be located at any reserved bits over the LPC addressing space.

Thereby, this patch series aims to remove the LPC partitioning for better driver development and maintenance. This requires the change to both the device tree and the driver implementation. To ensure both sides are synchronously updated, a v2 binding check is added.

Chagnes since v4:
- Add child node example in dt-bindings.

Chagnes since v3:
- Revise binding check as suggested by Haiyue Wang.

Changes since v2:
- Add v2 binding check to ensure the synchronization between the device tree change and the driver register offset fix.

Changes since v1:
- Add the fix to the aspeed-lpc binding documentation.

Chia-Wei, Wang (5):
dt-bindings: aspeed-lpc: Remove LPC partitioning
ARM: dts: Remove LPC BMC and Host partitions
ipmi: kcs: aspeed: Adapt to new LPC DTS layout
pinctrl: aspeed-g5: Adapt to new LPC device tree layout
soc: aspeed: Adapt to new LPC device tree layout

 .../devicetree/bindings/mfd/aspeed-lpc.txt    | 100 ++++---------
 arch/arm/boot/dts/aspeed-g4.dtsi              |  74 ++++------
 arch/arm/boot/dts/aspeed-g5.dtsi              | 135 ++++++++----------
 arch/arm/boot/dts/aspeed-g6.dtsi              | 135 ++++++++----------
 drivers/char/ipmi/kcs_bmc_aspeed.c            |  27 ++--
 drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c    |  17 ++-
 drivers/soc/aspeed/aspeed-lpc-ctrl.c          |  20 ++-
 drivers/soc/aspeed/aspeed-lpc-snoop.c         |  23 +--
 8 files changed, 229 insertions(+), 302 deletions(-)
Signature · 1 line
2.17.1