Skip to content

Convert remaining submodules to meson, cleanup env var handling

Paolo Bonzini qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4slirp: Convert Makefile bits to meson bitsMakefile configure meson.build +3 more+99 -770 replies
2/4dtc: Convert Makefile bits to meson bitsMakefile configure default-configs/targets/aarch64-softmmu.mak +11 more+83 -1062 replies
3/4configure: do not clobber environment CFLAGS/CXXFLAGS/LDFLAGSconfigure meson.build+19 -220 replies
4/4configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to mesonconfigure meson.build+27 -120 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRichard Henderson
SeriesT-b R-b
1/4
2/4
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Convert remaining submodules to meson, cleanup env var handling

The main purpose of this series is to have a correct and consistent handling of CFLAGS/CXXFLAGS/LDFLAGS environment variables:

- correct: avoid that the -pie flag, used for the compiler checks in the configure script, ends up being passed to Meson if an LDFLAGS environment variable exists (patch 3)

- consistent: ensure that CFLAGS that are set in the configure script are persistent even if Meson is restarted; to do so, make the configure script store them in the cross file it generates.

In order to avoid having to deal with recursive make, patches 1 and 2 integrate the Meson-based build system with the build of embedded slirp and libfdt. This follows the lead of Richard's patches to do the same with Capstone.

Based-on: <[email protected]>
Supersedes: <[email protected]>

Paolo Bonzini (4):
slirp: Convert Makefile bits to meson bits
dtc: Convert Makefile bits to meson bits
configure: do not clobber environment CFLAGS/CXXFLAGS/LDFLAGS
configure: consistently pass CFLAGS/CXXFLAGS/LDFLAGS to meson

 Makefile                                      |  28 +--
 configure                                     | 222 +++++-------------
 default-configs/targets/aarch64-softmmu.mak   |   1 +
 default-configs/targets/arm-softmmu.mak       |   1 +
 .../targets/microblaze-softmmu.mak            |   1 +
 .../targets/microblazeel-softmmu.mak          |   1 +
 default-configs/targets/mips64el-softmmu.mak  |   1 +
 default-configs/targets/ppc-softmmu.mak       |   1 +
 default-configs/targets/ppc64-softmmu.mak     |   1 +
 default-configs/targets/riscv32-softmmu.mak   |   1 +
 default-configs/targets/riscv64-softmmu.mak   |   1 +
 default-configs/targets/rx-softmmu.mak        |   1 +
 meson.build                                   | 164 +++++++++++--
 meson_options.txt                             |   6 +
 net/meson.build                               |   2 +-
 tests/qtest/meson.build                       |   6 +-
 16 files changed, 225 insertions(+), 213 deletions(-)
Signature · 1 line
2.26.2