Skip to content

HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

Douglas Anderson linux-arm-kernel linux-devicetree linux-input lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest4 patches 1 replyIn review
  2. v84 patches 8 repliesSuperseded
  3. v74 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v64 patches4 repliesSuperseded
v54 patches6 repliesSuperseded
v44 patches9 repliesSuperseded

Changes in v9 from the cover letter

- 120 ms delay => 180 ms delay
- Local variable in ACPI code "ihid_of" => "ihid_acpi".
- Squash Benjamin's change for ACPI power on.

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4HID: i2c-hid: Reorganize so ACPI and OF are separate modulesdrivers/hid/Makefile drivers/hid/i2c-hid/Kconfig drivers/hid/i2c-hid/Makefile +5 more+379 -2610 replies
2/4arm64: defconfig: Update config names for i2c-hid rejiggerarch/arm64/configs/defconfig+2 -10 replies
3/4dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix GT7375PDocumentation/devicetree/bindings/input/goodix,gt7375p.yaml+65 -00 replies
4/4HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid coredrivers/hid/i2c-hid/Kconfig drivers/hid/i2c-hid/Makefile drivers/hid/i2c-hid/i2c-hid-of-goodix.c+134 -20 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchHans de GoedeWill DeaconRob Herring
1/4R-b
2/4A-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [PATCH v9 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

The goal of this series is to support the Goodix GT7375P touchscreen. This touchscreen is special because it has power sequencing requirements that necessitate driving a reset GPIO.

To do this, we totally rejigger the way i2c-hid is organized so that it's easier to jam the Goodix support in there.

This series was:
- Tested on a device that uses normal i2c-hid.
- Tested on a device that has a Goodix i2c-hid device.
- Tested on an ACPI device, but an earlier version of the series.

I believe the plan is for Benjamin to land the whole series. Will said this about the arm64 defconfig change (and provided his Ack):

Quoted 6 lines

...there are a few things I really care about
in defconfig (e.g. things like page size!), generally speaking we don't need to Ack everything that changes in there.

That said, might be worth checking whether arm-soc have any defconfig changes queued in -next so you don't end up with conflicts.

Changes in v9:
- 120 ms delay => 180 ms delay
- Local variable in ACPI code "ihid_of" => "ihid_acpi".
- Squash Benjamin's change for ACPI power on.

Changes in v8:
- Mark suspend/resume as static as per patches robot.

Changes in v7:
- Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...")

Changes in v6:
- ACPI probe function should have been "static"
- Don't export suspend/resume, just export dev_pm_ops from core.
- Fixed crash in ACPI module (missing init of "client")
- No need for regulator include in the core.
- Removed i2c_device_id table from ACPI module.
- Suspend/resume are no longer exported from the core.

Changes in v5:
- Add shutdown_tail op and use it in ACPI.
- Added mention of i2c-hid in the yaml itself as per Rob.
- Adjusted subject as per Rob.
- i2chid_subclass_data => i2chid_ops.
- power_up_device => power_up (same with power_down).
- subclass => ops.

Changes in v4:
- ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4.
- Fully rejigger so ACPI and OF are full subclasses.
- Totally redid based on the new subclass system.

Changes in v3:
- Fixed compatible in example.
- Removed Benjamin as a maintainer.
- Rework to use subclassing.
- Updated description.

Changes in v2:
- ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2.
- Get timings based on the compatible string.
- Use a separate compatible string for this new touchscreen.

Douglas Anderson (4):
HID: i2c-hid: Reorganize so ACPI and OF are separate modules
arm64: defconfig: Update config names for i2c-hid rejigger
dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix

    GT7375P

HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core

 .../bindings/input/goodix,gt7375p.yaml        |  65 +++++
 arch/arm64/configs/defconfig                  |   3 +-
 drivers/hid/Makefile                          |   2 +-
 drivers/hid/i2c-hid/Kconfig                   |  47 +++-
 drivers/hid/i2c-hid/Makefile                  |   6 +-
 drivers/hid/i2c-hid/i2c-hid-acpi.c            | 143 ++++++++++
 drivers/hid/i2c-hid/i2c-hid-core.c            | 252 +++---------------
 drivers/hid/i2c-hid/i2c-hid-of-goodix.c       | 116 ++++++++
 drivers/hid/i2c-hid/i2c-hid-of.c              | 143 ++++++++++
 drivers/hid/i2c-hid/i2c-hid.h                 |  22 ++
 include/linux/platform_data/i2c-hid.h         |  41 ---
 11 files changed, 578 insertions(+), 262 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
 create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c
 create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c
 create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c
 delete mode 100644 include/linux/platform_data/i2c-hid.h
Signature · 1 line
2.30.0.284.gd98b1dd5eaa7-goog