RFC kvm: arm64: Always-on nVHE hypervisor
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest26 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/26 | psci: Export configured PSCI versiondrivers/ include/ | +14 | 1 reply | |
| 2/26 | psci: Export configured PSCI function IDsdrivers/ include/ | +11 | 1 reply | |
| 3/26 | psci: Export psci_cpu_suspend_featuredrivers/ include/ | +3 | 0 replies | |
| 4/26 | arm64: Move MAIR_EL1_SET to asm/memory.harch/ arch/ | +13 | 0 replies | |
| 5/26 | kvm: arm64: Initialize MAIR_EL2 using a constantarch/ | +1 | 0 replies | |
| 6/26 | kvm: arm64: Add .hyp.data ELF sectionarch/ arch/ arch/ +1 more | +21 | 0 replies | |
| 7/26 | kvm: arm64: Support per_cpu_ptr in nVHE hyp codearch/ arch/ arch/ +1 more | +33 | 0 replies | |
| 8/26 | kvm: arm64: Create nVHE copy of cpu_logical_maparch/ arch/ | +33 | 0 replies | |
| 9/26 | kvm: arm64: Move hyp-init params to a per-CPU structarch/ arch/ arch/ +3 more | +41 | 0 replies | |
| 10/26 | kvm: arm64: Refactor handle_trap to use a switcharch/ | +8 | 0 replies | |
| 11/26 | kvm: arm64: Extract parts of el2_setup into a macroarch/ arch/ | +141 | 0 replies | |
| 12/26 | kvm: arm64: Add SMC handler in nVHE EL2arch/ | +36 | 1 reply | |
| 13/26 | kvm: arm64: Bootstrap PSCI SMC handler in nVHE EL2arch/ arch/ arch/ +3 more | +124 | 0 replies | |
| 14/26 | kvm: arm64: Forward safe PSCI SMCs coming from hostarch/ | +39 | 0 replies | |
| 15/26 | arm64: kvm: Add standalone ticket spinlock implementation for use at hyparch/ | +96 | 0 replies | |
| 16/26 | kvm: arm64: Add offset for hyp VA <-> PA conversionarch/ arch/ | +18 | 0 replies | |
| 17/26 | kvm: arm64: Bootstrap PSCI power state of host CPUsarch/ arch/ arch/ +1 more | +14 | 0 replies | |
| 18/26 | kvm: arm64: Intercept PSCI_CPU_OFF host SMC callsarch/ | +29 | 2 replies | |
| 19/26 | kvm: arm64: Extract __do_hyp_init into a helper functionarch/ | +28 | 0 replies | |
| 20/26 | kvm: arm64: Add CPU entry point in nVHE hyparch/ arch/ arch/ | +32 | 0 replies | |
| 21/26 | kvm: arm64: Add function to enter host from KVM nVHE hyp codearch/ | +9 | 0 replies | |
| 22/26 | kvm: arm64: Intercept PSCI_CPU_ON host SMC callsarch/ arch/ arch/ | +117 | 0 replies | |
| 23/26 | kvm: arm64: Intercept host's CPU_SUSPEND PSCI SMCsarch/ arch/ drivers/ +1 more | +57 | 2 replies | |
| 24/26 | kvm: arm64: Keep nVHE EL2 vector installedarch/ | +13 | 0 replies | |
| 25/26 | kvm: arm64: Trap host SMCsarch/ arch/ arch/ | +9 | 0 replies | |
| 26/26 | kvm: arm64: Fix EL2 mode availability checksarch/ arch/ | +21 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 00/26] kvm: arm64: Always-on nVHE hypervisor
As we progress towards being able to keep guest state private to the host running nVHE hypervisor, this series allows the hypervisor to install itself on newly booted CPUs before the host is allowed to run on them.
To this end, the hypervisor starts trapping host SMCs and intercepting host's PSCI CPU_ON/OFF/SUSPEND calls. It replaces the host's entry point with its own, initializes the EL2 state of the new CPU and installs the nVHE hyp vector before ERETing to the host's entry point.
Other PSCI SMCs are forwarded to EL3, though only the known set of SMCs implemented in the kernel is allowed. Non-PSCI SMCs are also forwarded to EL3. Future changes will need to ensure the safety of all SMCs wrt. private guests.
The host is still allowed to reset EL2 back to the stub vector, eg. for hibernation or kexec, but will not disable nVHE when there are no VMs.
Tested on Rock Pi 4b.
Sending this as an RFC to get feedback on the following decisions:
1) The kernel checks new cores' features against the finalized system capabilities. To avoid the need to move this code/data to EL2, the implementation only allows to boot cores that were online at the time of KVM initialization.
2) Trapping and forwarding SMCs cannot be switched off. This could cause issues eg. if EL3 always returned to EL1. A kernel command line flag may be needed to turn the feature off on such platforms.
-David
David Brazdil (25):
psci: Export configured PSCI version
psci: Export configured PSCI function IDs
psci: Export psci_cpu_suspend_feature
arm64: Move MAIR_EL1_SET to asm/memory.h
kvm: arm64: Initialize MAIR_EL2 using a constant
kvm: arm64: Add .hyp.data ELF section
kvm: arm64: Support per_cpu_ptr in nVHE hyp code
kvm: arm64: Create nVHE copy of cpu_logical_map
kvm: arm64: Move hyp-init params to a per-CPU struct
kvm: arm64: Refactor handle_trap to use a switch
kvm: arm64: Extract parts of el2_setup into a macro
kvm: arm64: Add SMC handler in nVHE EL2
kvm: arm64: Bootstrap PSCI SMC handler in nVHE EL2
kvm: arm64: Forward safe PSCI SMCs coming from host
kvm: arm64: Add offset for hyp VA <-> PA conversion
kvm: arm64: Bootstrap PSCI power state of host CPUs
kvm: arm64: Intercept PSCI_CPU_OFF host SMC calls
kvm: arm64: Extract __do_hyp_init into a helper function
kvm: arm64: Add CPU entry point in nVHE hyp
kvm: arm64: Add function to enter host from KVM nVHE hyp code
kvm: arm64: Intercept PSCI_CPU_ON host SMC calls
kvm: arm64: Intercept host's CPU_SUSPEND PSCI SMCs
kvm: arm64: Keep nVHE EL2 vector installed
kvm: arm64: Trap host SMCs
kvm: arm64: Fix EL2 mode availability checks
Will Deacon (1):
arm64: kvm: Add standalone ticket spinlock implementation for use at
hyp
arch/arm64/include/asm/kvm_arm.h | 3 +- arch/arm64/include/asm/kvm_asm.h | 142 +++++++++ arch/arm64/include/asm/kvm_hyp.h | 10 + arch/arm64/include/asm/memory.h | 13 + arch/arm64/include/asm/percpu.h | 6 + arch/arm64/include/asm/sections.h | 1 + arch/arm64/include/asm/virt.h | 16 + arch/arm64/kernel/asm-offsets.c | 5 + arch/arm64/kernel/head.S | 140 +-------- arch/arm64/kernel/image-vars.h | 3 + arch/arm64/kernel/vmlinux.lds.S | 10 + arch/arm64/kvm/arm.c | 109 ++++++- arch/arm64/kvm/hyp/include/nvhe/spinlock.h | 96 ++++++ arch/arm64/kvm/hyp/nvhe/Makefile | 3 +- arch/arm64/kvm/hyp/nvhe/host.S | 9 + arch/arm64/kvm/hyp/nvhe/hyp-init.S | 82 ++++- arch/arm64/kvm/hyp/nvhe/hyp-main.c | 57 +++- arch/arm64/kvm/hyp/nvhe/hyp.lds.S | 3 + arch/arm64/kvm/hyp/nvhe/percpu.c | 38 +++ arch/arm64/kvm/hyp/nvhe/psci.c | 333 +++++++++++++++++++++ arch/arm64/mm/proc.S | 13 - drivers/firmware/psci/psci.c | 27 +- include/linux/psci.h | 20 ++ include/uapi/linux/psci.h | 8 + 24 files changed, 948 insertions(+), 199 deletions(-) create mode 100644 arch/arm64/kvm/hyp/include/nvhe/spinlock.h create mode 100644 arch/arm64/kvm/hyp/nvhe/percpu.c create mode 100644 arch/arm64/kvm/hyp/nvhe/psci.c
--
2.29.1.341.ge80a0c044ae-goog