Skip to content

RFC kvm: arm64: Always-on nVHE hypervisor

David Brazdil kvmarm linux-arm-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest26 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/26psci: Export configured PSCI versiondrivers/firmware/psci/psci.c include/linux/psci.h+14 -01 reply
2/26psci: Export configured PSCI function IDsdrivers/firmware/psci/psci.c include/linux/psci.h+11 -91 reply
3/26psci: Export psci_cpu_suspend_featuredrivers/firmware/psci/psci.c include/linux/psci.h+3 -10 replies
4/26arm64: Move MAIR_EL1_SET to asm/memory.harch/arm64/include/asm/memory.h arch/arm64/mm/proc.S+13 -130 replies
5/26kvm: arm64: Initialize MAIR_EL2 using a constantarch/arm64/kvm/hyp/nvhe/hyp-init.S+1 -10 replies
6/26kvm: arm64: Add .hyp.data ELF sectionarch/arm64/include/asm/sections.h arch/arm64/kernel/vmlinux.lds.S arch/arm64/kvm/arm.c +1 more+21 -00 replies
7/26kvm: arm64: Support per_cpu_ptr in nVHE hyp codearch/arm64/include/asm/percpu.h arch/arm64/kernel/image-vars.h arch/arm64/kvm/hyp/nvhe/Makefile +1 more+33 -10 replies
8/26kvm: arm64: Create nVHE copy of cpu_logical_maparch/arm64/kvm/arm.c arch/arm64/kvm/hyp/nvhe/percpu.c+33 -00 replies
9/26kvm: arm64: Move hyp-init params to a per-CPU structarch/arm64/include/asm/kvm_asm.h arch/arm64/include/asm/kvm_hyp.h arch/arm64/kernel/asm-offsets.c +3 more+41 -230 replies
10/26kvm: arm64: Refactor handle_trap to use a switcharch/arm64/kvm/hyp/nvhe/hyp-main.c+8 -70 replies
11/26kvm: arm64: Extract parts of el2_setup into a macroarch/arm64/include/asm/kvm_asm.h arch/arm64/kernel/head.S+141 -1270 replies
12/26kvm: arm64: Add SMC handler in nVHE EL2arch/arm64/kvm/hyp/nvhe/hyp-main.c+36 -01 reply
13/26kvm: arm64: Bootstrap PSCI SMC handler in nVHE EL2arch/arm64/include/asm/kvm_hyp.h arch/arm64/kvm/arm.c arch/arm64/kvm/hyp/nvhe/Makefile +3 more+124 -10 replies
14/26kvm: arm64: Forward safe PSCI SMCs coming from hostarch/arm64/kvm/hyp/nvhe/psci.c+39 -10 replies
15/26arm64: kvm: Add standalone ticket spinlock implementation for use at hyparch/arm64/kvm/hyp/include/nvhe/spinlock.h+96 -00 replies
16/26kvm: arm64: Add offset for hyp VA <-> PA conversionarch/arm64/kvm/arm.c arch/arm64/kvm/hyp/nvhe/psci.c+18 -00 replies
17/26kvm: arm64: Bootstrap PSCI power state of host CPUsarch/arm64/include/asm/kvm_asm.h arch/arm64/include/asm/kvm_hyp.h arch/arm64/kvm/arm.c +1 more+14 -00 replies
18/26kvm: arm64: Intercept PSCI_CPU_OFF host SMC callsarch/arm64/kvm/hyp/nvhe/psci.c+29 -12 replies
19/26kvm: arm64: Extract __do_hyp_init into a helper functionarch/arm64/kvm/hyp/nvhe/hyp-init.S+28 -110 replies
20/26kvm: arm64: Add CPU entry point in nVHE hyparch/arm64/include/asm/kvm_asm.h arch/arm64/kernel/asm-offsets.c arch/arm64/kvm/hyp/nvhe/hyp-init.S+32 -00 replies
21/26kvm: arm64: Add function to enter host from KVM nVHE hyp codearch/arm64/kvm/hyp/nvhe/host.S+9 -00 replies
22/26kvm: arm64: Intercept PSCI_CPU_ON host SMC callsarch/arm64/include/asm/kvm_hyp.h arch/arm64/kvm/arm.c arch/arm64/kvm/hyp/nvhe/psci.c+117 -00 replies
23/26kvm: arm64: Intercept host's CPU_SUSPEND PSCI SMCsarch/arm64/kvm/arm.c arch/arm64/kvm/hyp/nvhe/psci.c drivers/firmware/psci/psci.c +1 more+57 -102 replies
24/26kvm: arm64: Keep nVHE EL2 vector installedarch/arm64/kvm/arm.c+13 -40 replies
25/26kvm: arm64: Trap host SMCsarch/arm64/include/asm/kvm_arm.h arch/arm64/kernel/head.S arch/arm64/kvm/hyp/nvhe/hyp-init.S+9 -20 replies
26/26kvm: arm64: Fix EL2 mode availability checksarch/arm64/include/asm/virt.h arch/arm64/kvm/arm.c+21 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/26] kvm: arm64: Always-on nVHE hypervisor

As we progress towards being able to keep guest state private to the host running nVHE hypervisor, this series allows the hypervisor to install itself on newly booted CPUs before the host is allowed to run on them.

To this end, the hypervisor starts trapping host SMCs and intercepting host's PSCI CPU_ON/OFF/SUSPEND calls. It replaces the host's entry point with its own, initializes the EL2 state of the new CPU and installs the nVHE hyp vector before ERETing to the host's entry point.

Other PSCI SMCs are forwarded to EL3, though only the known set of SMCs implemented in the kernel is allowed. Non-PSCI SMCs are also forwarded to EL3. Future changes will need to ensure the safety of all SMCs wrt. private guests.

The host is still allowed to reset EL2 back to the stub vector, eg. for hibernation or kexec, but will not disable nVHE when there are no VMs.

Tested on Rock Pi 4b.

Sending this as an RFC to get feedback on the following decisions:

1) The kernel checks new cores' features against the finalized system capabilities. To avoid the need to move this code/data to EL2, the implementation only allows to boot cores that were online at the time of KVM initialization.

2) Trapping and forwarding SMCs cannot be switched off. This could cause issues eg. if EL3 always returned to EL1. A kernel command line flag may be needed to turn the feature off on such platforms.

-David

David Brazdil (25):
psci: Export configured PSCI version
psci: Export configured PSCI function IDs
psci: Export psci_cpu_suspend_feature
arm64: Move MAIR_EL1_SET to asm/memory.h
kvm: arm64: Initialize MAIR_EL2 using a constant
kvm: arm64: Add .hyp.data ELF section
kvm: arm64: Support per_cpu_ptr in nVHE hyp code
kvm: arm64: Create nVHE copy of cpu_logical_map
kvm: arm64: Move hyp-init params to a per-CPU struct
kvm: arm64: Refactor handle_trap to use a switch
kvm: arm64: Extract parts of el2_setup into a macro
kvm: arm64: Add SMC handler in nVHE EL2
kvm: arm64: Bootstrap PSCI SMC handler in nVHE EL2
kvm: arm64: Forward safe PSCI SMCs coming from host
kvm: arm64: Add offset for hyp VA <-> PA conversion
kvm: arm64: Bootstrap PSCI power state of host CPUs
kvm: arm64: Intercept PSCI_CPU_OFF host SMC calls
kvm: arm64: Extract __do_hyp_init into a helper function
kvm: arm64: Add CPU entry point in nVHE hyp
kvm: arm64: Add function to enter host from KVM nVHE hyp code
kvm: arm64: Intercept PSCI_CPU_ON host SMC calls
kvm: arm64: Intercept host's CPU_SUSPEND PSCI SMCs
kvm: arm64: Keep nVHE EL2 vector installed
kvm: arm64: Trap host SMCs
kvm: arm64: Fix EL2 mode availability checks

Will Deacon (1):
arm64: kvm: Add standalone ticket spinlock implementation for use at
hyp

 arch/arm64/include/asm/kvm_arm.h           |   3 +-
 arch/arm64/include/asm/kvm_asm.h           | 142 +++++++++
 arch/arm64/include/asm/kvm_hyp.h           |  10 +
 arch/arm64/include/asm/memory.h            |  13 +
 arch/arm64/include/asm/percpu.h            |   6 +
 arch/arm64/include/asm/sections.h          |   1 +
 arch/arm64/include/asm/virt.h              |  16 +
 arch/arm64/kernel/asm-offsets.c            |   5 +
 arch/arm64/kernel/head.S                   | 140 +--------
 arch/arm64/kernel/image-vars.h             |   3 +
 arch/arm64/kernel/vmlinux.lds.S            |  10 +
 arch/arm64/kvm/arm.c                       | 109 ++++++-
 arch/arm64/kvm/hyp/include/nvhe/spinlock.h |  96 ++++++
 arch/arm64/kvm/hyp/nvhe/Makefile           |   3 +-
 arch/arm64/kvm/hyp/nvhe/host.S             |   9 +
 arch/arm64/kvm/hyp/nvhe/hyp-init.S         |  82 ++++-
 arch/arm64/kvm/hyp/nvhe/hyp-main.c         |  57 +++-
 arch/arm64/kvm/hyp/nvhe/hyp.lds.S          |   3 +
 arch/arm64/kvm/hyp/nvhe/percpu.c           |  38 +++
 arch/arm64/kvm/hyp/nvhe/psci.c             | 333 +++++++++++++++++++++
 arch/arm64/mm/proc.S                       |  13 -
 drivers/firmware/psci/psci.c               |  27 +-
 include/linux/psci.h                       |  20 ++
 include/uapi/linux/psci.h                  |   8 +
 24 files changed, 948 insertions(+), 199 deletions(-)
 create mode 100644 arch/arm64/kvm/hyp/include/nvhe/spinlock.h
 create mode 100644 arch/arm64/kvm/hyp/nvhe/percpu.c
 create mode 100644 arch/arm64/kvm/hyp/nvhe/psci.c

--
2.29.1.341.ge80a0c044ae-goog