Skip to content

crypto: qat - rework firmware loader in preparation for qat_4xxx

Jack Xu linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest32 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32crypto: qat - support for mof format in fw loaderdrivers/crypto/qat/qat_common/adf_accel_engine.c drivers/crypto/qat/qat_common/adf_common_drv.h drivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h +2 more+331 -50 replies
2/32crypto: qat - loader: fix status check in qat_hal_put_rel_rd_xfer()drivers/crypto/qat/qat_common/qat_hal.c+1 -10 replies
3/32crypto: qat - loader: fix CSR accessdrivers/crypto/qat/qat_common/icp_qat_hal.h+2 -40 replies
4/32crypto: qat - loader: fix error messagedrivers/crypto/qat/qat_common/qat_uclo.c+1 -10 replies
5/32crypto: qat - loader: remove unnecessary parenthesisdrivers/crypto/qat/qat_common/qat_hal.c drivers/crypto/qat/qat_common/qat_uclo.c+11 -110 replies
6/32crypto: qat - loader: introduce additional parenthesisdrivers/crypto/qat/qat_common/icp_qat_hal.h drivers/crypto/qat/qat_common/qat_hal.c+10 -100 replies
7/32crypto: qat - loader: rename qat_uclo_del_uof_obj()drivers/crypto/qat/qat_common/adf_accel_engine.c drivers/crypto/qat/qat_common/adf_common_drv.h drivers/crypto/qat/qat_common/qat_uclo.c+3 -30 replies
8/32crypto: qat - loader: add support for relative FW ucode loadingdrivers/crypto/qat/qat_common/qat_uclo.c+7 -60 replies
9/32crypto: qat - loader: change type for ctx_maskdrivers/crypto/qat/qat_common/adf_common_drv.h drivers/crypto/qat/qat_common/qat_hal.c+12 -120 replies
10/32crypto: qat - loader: change micro word data maskdrivers/crypto/qat/qat_common/qat_uclo.c+1 -10 replies
11/32crypto: qat - loader: refactor AE startdrivers/crypto/qat/qat_common/adf_accel_engine.c drivers/crypto/qat/qat_common/adf_common_drv.h drivers/crypto/qat/qat_common/qat_hal.c+18 -180 replies
12/32crypto: qat - loader: remove global CSRs helpersdrivers/crypto/qat/qat_common/icp_qat_hal.h drivers/crypto/qat/qat_common/qat_hal.c+13 -160 replies
13/32crypto: qat - loader: move defines to header filesdrivers/crypto/qat/qat_common/icp_qat_hal.h drivers/crypto/qat/qat_common/qat_hal.c+4 -40 replies
14/32crypto: qat - loader: refactor qat_uclo_set_ae_mode()drivers/crypto/qat/qat_common/qat_uclo.c+43 -260 replies
15/32crypto: qat - loader: refactor long expressionsdrivers/crypto/qat/qat_common/qat_uclo.c+23 -180 replies
16/32crypto: qat - loader: introduce chip info structuredrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/qat_hal.c drivers/crypto/qat/qat_common/qat_uclo.c+88 -350 replies
17/32crypto: qat - loader: replace check based on DIDdrivers/crypto/qat/qat_common/qat_uclo.c+5 -30 replies
18/32crypto: qat - loader: add next neighbor to chip_infodrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/qat_hal.c drivers/crypto/qat/qat_common/qat_uclo.c+18 -60 replies
19/32crypto: qat - loader: add support for lm2 and lm3drivers/crypto/qat/qat_common/adf_common_drv.h drivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/icp_qat_hal.h +3 more+101 -20 replies
20/32crypto: qat - loader: add local memory size to chip infodrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/qat_hal.c drivers/crypto/qat/qat_common/qat_uclo.c+4 -10 replies
21/32crypto: qat - loader: add reset CSR and mask to chip infodrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/qat_hal.c+24 -170 replies
22/32crypto: qat - loader: add clock enable CSR to chip infodrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/qat_hal.c+7 -40 replies
23/32crypto: qat - loader: add wake up event to chip infodrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/icp_qat_hal.h drivers/crypto/qat/qat_common/qat_hal.c+6 -10 replies
24/32crypto: qat - loader: add misc control CSR to chip infodrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/qat_hal.c+8 -40 replies
25/32crypto: qat - loader: add check for null pointerdrivers/crypto/qat/qat_common/qat_uclo.c+17 -110 replies
26/32crypto: qat - loader: use ae_maskdrivers/crypto/qat/qat_common/qat_uclo.c+14 -120 replies
27/32crypto: qat - loader: add CSS3K supportdrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/icp_qat_uclo.h drivers/crypto/qat/qat_common/qat_hal.c +1 more+68 -400 replies
28/32crypto: qat - loader: add FCU CSRs to chip infodrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/qat_hal.c drivers/crypto/qat/qat_common/qat_uclo.c+53 -160 replies
29/32crypto: qat - loader: allow to target specific AEsdrivers/crypto/qat/qat_common/adf_common_drv.h drivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/icp_qat_hal.h +3 more+42 -80 replies
30/32crypto: qat - loader: add support for shared ustoredrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/qat_hal.c drivers/crypto/qat/qat_common/qat_uclo.c+19 -130 replies
31/32crypto: qat - loader: add support for broadcasting modedrivers/crypto/qat/qat_common/icp_qat_fw_loader_handle.h drivers/crypto/qat/qat_common/icp_qat_hal.h drivers/crypto/qat/qat_common/qat_hal.c +1 more+99 -30 replies
32/32crypto: qat - loader: add gen4 firmware loaderdrivers/crypto/qat/qat_common/adf_accel_devices.h drivers/crypto/qat/qat_common/icp_qat_hal.h drivers/crypto/qat/qat_common/icp_qat_uclo.h +2 more+78 -170 replies

Reviews trailers per patch

31 of 32 patches have a Reviewed-by or Acked-by.

PatchJack XuGiovanni CabidduFiona Trahe
1/32R-b
2/32R-b R-b
3/32R-b
4/32R-b
5/32R-b
6/32R-b
7/32R-b
8/32R-b
9/32R-b
10/32R-b
11/32R-b
12/32R-b
13/32R-b
14/32R-b
15/32R-b
16/32R-b
17/32R-b
18/32R-b
19/32R-b
20/32R-b
21/32R-b
22/32R-b
23/32R-b
24/32R-b
25/32
26/32R-b
27/32R-b
28/32R-b
29/32R-b
30/32R-b
31/32R-b
32/32R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/32] crypto: qat - rework firmware loader in preparation for qat_4xxx

Rework firmware loader in QAT driver in preparation for the support of the qat_4xxx driver.

Patch #1 add support for the mof format in the firmware loader
Patches from #2 to #7 introduce some general fixes
Patches from #8 to #30 rework and refactor the firmware loader to support the new features added by the next generation of QAT devices (QAT GEN4) Patch #31 introduces the firmware loader changes to support QAT GEN4 devices

Giovanni Cabiddu (1):
crypto: qat - support for mof format in fw loader

Jack Xu (31):
crypto: qat - loader: fix status check in qat_hal_put_rel_rd_xfer()
crypto: qat - loader: fix CSR access
crypto: qat - loader: fix error message
crypto: qat - loader: remove unnecessary parenthesis
crypto: qat - loader: introduce additional parenthesis
crypto: qat - loader: rename qat_uclo_del_uof_obj()
crypto: qat - loader: add support for relative FW ucode loading
crypto: qat - loader: change type for ctx_mask
crypto: qat - loader: change micro word data mask
crypto: qat - loader: refactor AE start
crypto: qat - loader: remove global CSRs helpers
crypto: qat - loader: move defines to header files
crypto: qat - loader: refactor qat_uclo_set_ae_mode()
crypto: qat - loader: refactor long expressions
crypto: qat - loader: introduce chip info structure
crypto: qat - loader: replace check based on DID
crypto: qat - loader: add next neighbor to chip_info
crypto: qat - loader: add support for lm2 and lm3
crypto: qat - loader: add local memory size to chip info
crypto: qat - loader: add reset CSR and mask to chip info
crypto: qat - loader: add clock enable CSR to chip info
crypto: qat - loader: add wake up event to chip info
crypto: qat - loader: add misc control CSR to chip info
crypto: qat - loader: add check for null pointer
crypto: qat - loader: use ae_mask
crypto: qat - loader: add CSS3K support
crypto: qat - loader: add FCU CSRs to chip info
crypto: qat - loader: allow to target specific AEs
crypto: qat - loader: add support for shared ustore
crypto: qat - loader: add support for broadcasting mode
crypto: qat - loader: add gen4 firmware loader

 .../crypto/qat/qat_common/adf_accel_devices.h |   2 +
 .../crypto/qat/qat_common/adf_accel_engine.c  |  13 +-
 .../crypto/qat/qat_common/adf_common_drv.h    |  19 +-
 .../qat/qat_common/icp_qat_fw_loader_handle.h |  26 +-
 drivers/crypto/qat/qat_common/icp_qat_hal.h   |  63 +-
 drivers/crypto/qat/qat_common/icp_qat_uclo.h  | 132 +++-
 drivers/crypto/qat/qat_common/qat_hal.c       | 400 +++++++---
 drivers/crypto/qat/qat_common/qat_uclo.c      | 737 ++++++++++++++----
 8 files changed, 1097 insertions(+), 295 deletions(-)
Signature · 1 line
2.25.4