Skip to content

lib8390: Remove custom padding solution

Armin Wolf netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v11 patch 2 repliesSuperseded

Changes in v2 from the cover letter

- split cleanup of variables in seperate patch
- revise commit description

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib8390: Use eth_skb_pad()drivers/net/ethernet/8390/lib8390.c+9 -90 replies
2/2lib8390: Cleanup variablesdrivers/net/ethernet/8390/lib8390.c+6 -91 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] lib8390: Remove custom padding solution

When padding undersized frames, lib8390.c utilizes a stack scratch area plus memset/memcpy. In doing so, it is overwriting content already zeroed with memset, which seems not optimal even when commented as being more efficient. Using eth_skb_pad() allows us to remove memset/memcpy and the stack scratch area altogether.

v2 changes:
- split cleanup of variables in seperate patch
- revise commit description

Armin Wolf (2):
lib8390: Use eth_skb_pad()
lib8390: Cleanup variables

 drivers/net/ethernet/8390/lib8390.c | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

--
2.20.1