Don't compute events that won't be used in a metric.
Status from this message: Thanks, applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest13 patches 6 repliesApplied
- v88 patches 6 repliesSuperseded
- v75 patches 3 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 5 patches | 0 replies | Superseded | |
| v5 | 5 patches | 2 replies | Superseded | |
| v4 | 5 patches | 2 replies | Superseded | |
| v3 | 5 patches | 1 reply | Superseded | |
| v2 | 5 patches | 3 replies | Superseded | |
| v1 | 5 patches | 1 reply | Superseded |
Patches in v9 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | perf metric: Restructure struct expr_parse_ctx.tools/ tools/ tools/ +3 more | +159 | 0 replies | |
| 2/13 | perf metric: Use NAN for missing event IDs.tools/ | +4 | 0 replies | |
| 3/13 | perf expr: Remove unused headers and inline d_ratiotools/ | +7 | 0 replies | |
| 4/13 | perf expr: Separate token declataion from typetools/ | +4 | 0 replies | |
| 5/13 | perf expr: Use macros for operatorstools/ | +14 | 0 replies | |
| 6/13 | perf expr: Move actions to the left.tools/ | +75 | 0 replies | |
| 7/13 | perf metric: Rename expr__find_other.tools/ tools/ tools/ +3 more | +25 | 0 replies | |
| 8/13 | perf metric: Add utilities to work on ids map.tools/ tools/ tools/ | +126 | 0 replies | |
| 9/13 | perf metric: Allow metrics with no eventstools/ | +59 | 0 replies | |
| 10/13 | perf expr: Merge find_ids and regular parsingtools/ tools/ tools/ +1 more | +136 | 2 replies | |
| 11/13 | perf expr: Propagate constants for binary operationstools/ | +45 | 0 replies | |
| 12/13 | perf metric: Don't compute unused eventstools/ tools/ | +34 | 0 replies | |
| 13/13 | perf metric: Avoid events for an 'if' constant resulttools/ tools/ | +17 | 0 replies |
Reviews trailers per patch
2 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Andi Kleen | Jiri Olsa | John Garry |
|---|---|---|---|
| Series | A-b | T-b | |
| 1/13 | R-b | ||
| 2/13 | R-b | ||
| 3/13 | |||
| 4/13 | |||
| 5/13 | |||
| 6/13 | |||
| 7/13 | |||
| 8/13 | |||
| 9/13 | |||
| 10/13 | |||
| 11/13 | |||
| 12/13 | |||
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v9 00/13] Don't compute events that won't be used in a metric.
For a metric like:
EVENT1 if #smt_on else EVENT2
currently EVENT1 and EVENT2 will be measured and then when the metric is reported EVENT1 or EVENT2 will be printed depending on the value from smt_on() during the expr parsing. Computing both events is unnecessary and can lead to multiplexing as discussed in this thread:
https://lore.kernel.org/lkml/[email protected]/
This change modifies expression parsing so that constants are considered when building the set of ids (events) and only events not contributing to a constant value are measured.
v9. adds a missing memory allocation failure check in the pmu-metrics
test. A memory allocation failure in union returns NULL. Some parser debug on IDs is removed. "Modify code layout" is broken apart into 3 changes. "Don't compute unused events" is broken apart into 4 changes with the tests merged into the change that adds the corresponding optimization. This is trying to address feedback from Jiri Olsa <[email protected]>. The unmodified patches have Reviewed-by: Andi Kleen <[email protected]> added, although the overall patch set is largely the same as v8 which was fully reviewed-by.
v8. rebases, adds an ability to compute metrics with no events and
further breaks apart the "Don't compute unused events" part of the change as requested by Jiri Olsa <[email protected]>.
v7. fixes the fix to be in the correct patch.
v6. rebases and fixes issues raised by Namhyung Kim <[email protected]>, a memory leak and a function comment.
v5. uses macros to reduce boiler plate in patch 5/5 as suggested by Andi Kleen <[email protected]>.
v4. reduces references to BOTTOM/NAN in patch 5/5 by using utility functions. It improves comments and fixes an unnecessary union in a peephole optimization.
v3. fixes an assignment in patch 2/5. In patch 5/5 additional comments are added and useless frees are replaced by asserts. A new peephole optimization is added for the case CONST IF expr ELSE CONST, where the the constants are identical, as we don't need to evaluate the IF condition.
v2. is a rebase.
Ian Rogers (13):
perf metric: Restructure struct expr_parse_ctx. perf metric: Use NAN for missing event IDs. perf expr: Remove unused headers and inline d_ratio perf expr: Separate token declataion from type perf expr: Use macros for operators
perf expr: Move actions to the left.
perf metric: Rename expr__find_other.
perf metric: Add utilities to work on ids map. perf metric: Allow metrics with no events perf expr: Merge find_ids and regular parsing perf expr: Propagate constants for binary operations perf metric: Don't compute unused events perf metric: Avoid events for an 'if' constant result
tools/perf/tests/expr.c | 160 ++++++++++++----- tools/perf/tests/pmu-events.c | 54 +++--- tools/perf/util/expr.c | 121 +++++++++++-- tools/perf/util/expr.h | 20 ++- tools/perf/util/expr.l | 9 - tools/perf/util/expr.y | 325 +++++++++++++++++++++++++--------- tools/perf/util/metricgroup.c | 145 ++++++++------- tools/perf/util/stat-shadow.c | 54 +++--- 8 files changed, 620 insertions(+), 268 deletions(-)
Signature · 1 line
2.33.0.464.g1972c5931b-goog