Don't compute events that won't be used in a metric.
Ian Rogers
reviewercover Don't compute events that won't be used in a metric.
For a metric like:
EVENT1 if #smt_on else EVENT2
currently EVENT1 and EVENT2 will be measured and then when the metric is reported EVENT1 or EVENT2 will be printed depending on the value from smt_on() during the expr parsing. Computing both events is unnecessary and can lead to multiplexing as discussed in this thread:
https://lore.kernel.org/lkml/[email protected]/
This change modifies expression parsing so that constants are considered when building the set of ids (events) and only events not contributing to a constant value are measured.
Ian Rogers (5):
perf metric: Restructure struct expr_parse_ctx.
perf metric: Use NAN for missing event IDs.
perf metric: Rename expr__find_other.
perf metric: Add utilities to work on ids map.
perf metric: Don't compute unused events.
tools/perf/tests/expr.c | 148 ++++++++++----- tools/perf/tests/pmu-events.c | 42 +++-- tools/perf/util/expr.c | 136 ++++++++++++-- tools/perf/util/expr.h | 17 +- tools/perf/util/expr.l | 9 - tools/perf/util/expr.y | 343 +++++++++++++++++++++++++++------- tools/perf/util/metricgroup.c | 44 +++-- tools/perf/util/stat-shadow.c | 54 ++++-- 8 files changed, 586 insertions(+), 207 deletions(-)
Signature · 1 line
2.29.2.299.gdc1121823c-goog
Ian Rogers
reviewerPATCH 1/5 perf metric: Restructure struct expr_parse_ctx.
A later change to parsing the ids out (in expr__find_other) will potentially drop hashmaps and so it is more convenient to move expr_parse_ctx to have a hashmap pointer rather than a struct value. As this pointer must be freed, rather than just going out of scope, add expr__ctx_new and expr__ctx_free to manage expr_parse_ctx memory. Adjust use of struct expr_parse_ctx accordingly.
--- tools/perf/tests/expr.c | 81 ++++++++++++++++++----------------- tools/perf/tests/pmu-events.c | 37 +++++++++------- tools/perf/util/expr.c | 38 ++++++++++++---- tools/perf/util/expr.h | 5 ++- tools/perf/util/metricgroup.c | 44 ++++++++++--------- tools/perf/util/stat-shadow.c | 50 +++++++++++++-------- 6 files changed, 151 insertions(+), 104 deletions(-)
tools/perf/tests/expr.c +42 -39
@@ -22,67 +22,70 @@ int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused)const char *p;double val;int ret; -struct expr_parse_ctx ctx; +struct expr_parse_ctx *ctx; -expr__ctx_init (&ctx); -expr__add_id_val (&ctx,strdup ("FOO" ),1 ); -expr__add_id_val (&ctx,strdup ("BAR" ),2 ); + ctx =expr__ctx_new (); +TEST_ASSERT_VAL ("expr__ctx_new" , ctx); +expr__add_id_val (ctx,strdup ("FOO" ),1 ); +expr__add_id_val (ctx,strdup ("BAR" ),2 ); - ret =test (&ctx,"1+1" ,2 ); - ret |=test (&ctx,"FOO+BAR" ,3 ); - ret |=test (&ctx,"(BAR/2)%2" ,1 ); - ret |=test (&ctx,"1 - -4" ,5 ); - ret |=test (&ctx,"(FOO-1)*2 + (BAR/2)%2 - -4" ,5 ); - ret |=test (&ctx,"1-1 | 1" ,1 ); - ret |=test (&ctx,"1-1 & 1" ,0 ); - ret |=test (&ctx,"min(1,2) + 1" ,2 ); - ret |=test (&ctx,"max(1,2) + 1" ,3 ); - ret |=test (&ctx,"1+1 if 3*4 else 0" ,2 ); - ret |=test (&ctx,"1.1 + 2.1" ,3.2 ); - ret |=test (&ctx,".1 + 2." ,2.1 ); - ret |=test (&ctx,"d_ratio(1, 2)" ,0.5 ); - ret |=test (&ctx,"d_ratio(2.5, 0)" ,0 ); - ret |=test (&ctx,"1.1 < 2.2" ,1 ); - ret |=test (&ctx,"2.2 > 1.1" ,1 ); - ret |=test (&ctx,"1.1 < 1.1" ,0 ); - ret |=test (&ctx,"2.2 > 2.2" ,0 ); - ret |=test (&ctx,"2.2 < 1.1" ,0 ); - ret |=test (&ctx,"1.1 > 2.2" ,0 ); + ret =test (ctx,"1+1" ,2 ); + ret |=test (ctx,"FOO+BAR" ,3 ); + ret |=test (ctx,"(BAR/2)%2" ,1 ); + ret |=test (ctx,"1 - -4" ,5 ); + ret |=test (ctx,"(FOO-1)*2 + (BAR/2)%2 - -4" ,5 ); + ret |=test (ctx,"1-1 | 1" ,1 ); + ret |=test (ctx,"1-1 & 1" ,0 ); + ret |=test (ctx,"min(1,2) + 1" ,2 ); + ret |=test (ctx,"max(1,2) + 1" ,3 ); + ret |=test (ctx,"1+1 if 3*4 else 0" ,2 ); + ret |=test (ctx,"1.1 + 2.1" ,3.2 ); + ret |=test (ctx,".1 + 2." ,2.1 ); + ret |=test (ctx,"d_ratio(1, 2)" ,0.5 ); + ret |=test (ctx,"d_ratio(2.5, 0)" ,0 ); + ret |=test (ctx,"1.1 < 2.2" ,1 ); + ret |=test (ctx,"2.2 > 1.1" ,1 ); + ret |=test (ctx,"1.1 < 1.1" ,0 ); + ret |=test (ctx,"2.2 > 2.2" ,0 ); + ret |=test (ctx,"2.2 < 1.1" ,0 ); + ret |=test (ctx,"1.1 > 2.2" ,0 ); -if (ret) +if (ret) { +expr__ctx_free (ctx);return ret; + } p ="FOO/0" ; - ret =expr__parse (&val, &ctx, p,1 ); + ret =expr__parse (&val, ctx, p,1 );TEST_ASSERT_VAL ("division by zero" , ret ==-1 ); p ="BAR/" ; - ret =expr__parse (&val, &ctx, p,1 ); + ret =expr__parse (&val, ctx, p,1 );TEST_ASSERT_VAL ("missing operand" , ret ==-1 ); -expr__ctx_clear (&ctx); +expr__ctx_clear (ctx);TEST_ASSERT_VAL ("find other" ,expr__find_other ("FOO + BAR + BAZ + BOZO" ,"FOO" , - &ctx,1 ) ==0 ); -TEST_ASSERT_VAL ("find other" ,hashmap__size (&ctx.ids) ==3 ); -TEST_ASSERT_VAL ("find other" ,hashmap__find (&ctx.ids,"BAR" , + ctx,1 ) ==0 ); +TEST_ASSERT_VAL ("find other" ,hashmap__size (ctx->ids) ==3 ); +TEST_ASSERT_VAL ("find other" ,hashmap__find (ctx->ids,"BAR" , (void **)&val_ptr)); -TEST_ASSERT_VAL ("find other" ,hashmap__find (&ctx.ids,"BAZ" , +TEST_ASSERT_VAL ("find other" ,hashmap__find (ctx->ids,"BAZ" , (void **)&val_ptr)); -TEST_ASSERT_VAL ("find other" ,hashmap__find (&ctx.ids,"BOZO" , +TEST_ASSERT_VAL ("find other" ,hashmap__find (ctx->ids,"BOZO" , (void **)&val_ptr)); -expr__ctx_clear (&ctx); +expr__ctx_clear (ctx);TEST_ASSERT_VAL ("find other" ,expr__find_other ("EVENT1\\,param\\=?@ + EVENT2\\,param\\=?@" , -NULL , &ctx,3 ) ==0 ); -TEST_ASSERT_VAL ("find other" ,hashmap__size (&ctx.ids) ==2 ); -TEST_ASSERT_VAL ("find other" ,hashmap__find (&ctx.ids,"EVENT1,param=3/" , +NULL , ctx,3 ) ==0 ); +TEST_ASSERT_VAL ("find other" ,hashmap__size (ctx->ids) ==2 ); +TEST_ASSERT_VAL ("find other" ,hashmap__find (ctx->ids,"EVENT1,param=3/" , (void **)&val_ptr)); -TEST_ASSERT_VAL ("find other" ,hashmap__find (&ctx.ids,"EVENT2,param=3/" , +TEST_ASSERT_VAL ("find other" ,hashmap__find (ctx->ids,"EVENT2,param=3/" , (void **)&val_ptr)); -expr__ctx_clear (&ctx); +expr__ctx_free (ctx);return 0 ; }
tools/perf/tests/pmu-events.c +21 -16
@@ -478,9 +478,14 @@ static int test_parsing(void)struct pmu_event *pe;int i, j, k;int ret =0 ; -struct expr_parse_ctx ctx; +struct expr_parse_ctx *ctx;double result; + ctx =expr__ctx_new (); +if (!ctx) { +pr_debug ("expr__ctx_new failed" ); +return TEST_FAIL ; + } i =0 ;for (;;) { map = &pmu_events_map[i++];
@@ -496,8 +501,8 @@ static int test_parsing(void)break ;if (!pe->metric_expr)continue ; -expr__ctx_init (&ctx); -if (expr__find_other (pe->metric_expr,NULL , &ctx,0 ) +expr__ctx_clear (ctx); +if (expr__find_other (pe->metric_expr,NULL , ctx,0 ) <0 ) {expr_failure ("Parse other failed" , map, pe); ret++;
@@ -510,22 +515,22 @@ static int test_parsing(void)* make them unique. */ k =1 ; -hashmap__for_each_entry ((&ctx.ids), cur, bkt) -expr__add_id_val (&ctx,strdup (cur->key), k++); +hashmap__for_each_entry (ctx->ids, cur, bkt) +expr__add_id_val (ctx,strdup (cur->key), k++); -hashmap__for_each_entry ((&ctx.ids), cur, bkt) { +hashmap__for_each_entry (ctx->ids, cur, bkt) {if (check_parse_cpu (cur->key, map == cpus_map, pe)) ret++; } -if (expr__parse (&result, &ctx, pe->metric_expr,0 )) { +if (expr__parse (&result, ctx, pe->metric_expr,0 )) {expr_failure ("Parse failed" , map, pe); ret++; } -expr__ctx_clear (&ctx); } } +expr__ctx_free (ctx);/* TODO: fail when not ok */ return ret ==0 ?TEST_OK :TEST_SKIP ; }
@@ -544,7 +549,7 @@ static struct test_metric metrics[] = {static int metric_parse_fake (const char *str) { -struct expr_parse_ctx ctx; +struct expr_parse_ctx *ctx;struct hashmap_entry *cur;double result;int ret =-1 ;
@@ -553,8 +558,8 @@ static int metric_parse_fake(const char *str)pr_debug ("parsing '%s'\n" , str); -expr__ctx_init (&ctx); -if (expr__find_other (str,NULL , &ctx,0 ) <0 ) { + ctx =expr__ctx_new (); +if (expr__find_other (str,NULL , ctx,0 ) <0 ) {pr_err ("expr__find_other failed\n" );return -1 ; }
@@ -565,23 +570,23 @@ static int metric_parse_fake(const char *str)* make them unique. */ i =1 ; -hashmap__for_each_entry ((&ctx.ids), cur, bkt) -expr__add_id_val (&ctx,strdup (cur->key), i++); +hashmap__for_each_entry (ctx->ids, cur, bkt) +expr__add_id_val (ctx,strdup (cur->key), i++); -hashmap__for_each_entry ((&ctx.ids), cur, bkt) { +hashmap__for_each_entry (ctx->ids, cur, bkt) {if (check_parse_fake (cur->key)) {pr_err ("check_parse_fake failed\n" ); goto out; } } -if (expr__parse (&result, &ctx, str,1 )) +if (expr__parse (&result, ctx, str,1 ))pr_err ("expr__parse failed\n" );else ret =0 ; out: -expr__ctx_clear (&ctx); +expr__ctx_free (ctx);return ret; }
tools/perf/util/expr.c +29 -9
@@ -49,7 +49,7 @@ int expr__add_id(struct expr_parse_ctx *ctx, const char *id) data_ptr->parent = ctx->parent; - ret =hashmap__set (&ctx->ids, id, data_ptr, + ret =hashmap__set (ctx->ids, id, data_ptr, (const void **)&old_key, (void **)&old_data);if (ret)free (data_ptr);
@@ -71,7 +71,7 @@ int expr__add_id_val(struct expr_parse_ctx *ctx, const char *id, double val) data_ptr->val = val; data_ptr->is_ref = false; - ret =hashmap__set (&ctx->ids, id, data_ptr, + ret =hashmap__set (ctx->ids, id, data_ptr, (const void **)&old_key, (void **)&old_data);if (ret)free (data_ptr);
@@ -117,7 +117,7 @@ int expr__add_ref(struct expr_parse_ctx *ctx, struct metric_ref *ref) data_ptr->ref.counted = false; data_ptr->is_ref = true; - ret =hashmap__set (&ctx->ids, name, data_ptr, + ret =hashmap__set (ctx->ids, name, data_ptr, (const void **)&old_key, (void **)&old_data);if (ret)free (data_ptr);
@@ -133,7 +133,7 @@ int expr__add_ref(struct expr_parse_ctx *ctx, struct metric_ref *ref)int expr__get_id (struct expr_parse_ctx *ctx,const char *id,struct expr_id_data **data) { -return hashmap__find (&ctx->ids, id, (void **)data) ?0 :-1 ; +return hashmap__find (ctx->ids, id, (void **)data) ?0 :-1 ; } int expr__resolve_id(struct expr_parse_ctx *ctx, const char *id,
@@ -169,15 +169,23 @@ void expr__del_id(struct expr_parse_ctx *ctx, const char *id)struct expr_id_data *old_val =NULL ;char *old_key =NULL ; -hashmap__delete (&ctx->ids, id, +hashmap__delete (ctx->ids, id, (const void **)&old_key, (void **)&old_val);free (old_key);free (old_val); } -void expr__ctx_init (struct expr_parse_ctx *ctx) +struct expr_parse_ctx *expr__ctx_new (void ) { -hashmap__init (&ctx->ids, key_hash, key_equal,NULL ); +struct expr_parse_ctx *ctx; + + ctx =malloc (sizeof (struct expr_parse_ctx )); +if (!ctx) +return NULL ; + + ctx->ids =hashmap__new (key_hash, key_equal,NULL ); + ctx->parent =NULL ; +return ctx; }void expr__ctx_clear (struct expr_parse_ctx *ctx)
@@ -185,11 +193,23 @@ void expr__ctx_clear(struct expr_parse_ctx *ctx)struct hashmap_entry *cur;size_t bkt; -hashmap__for_each_entry ((&ctx->ids), cur, bkt) { +hashmap__for_each_entry (ctx->ids, cur, bkt) { +free ((char *)cur->key); +free (cur->value); + } +hashmap__clear (ctx->ids); +} + +void expr__ctx_free (struct expr_parse_ctx *ctx) +{ +struct hashmap_entry *cur; +size_t bkt; + +hashmap__for_each_entry (ctx->ids, cur, bkt) {free ((char *)cur->key);free (cur->value); } -hashmap__clear (&ctx->ids); +hashmap__free (ctx->ids); } static int
tools/perf/util/expr.h +3 -2
@@ -19,7 +19,7 @@ struct expr_id { };struct expr_parse_ctx { -struct hashmap ids; +struct hashmap *ids;struct expr_id *parent; };
@@ -42,8 +42,9 @@ struct expr_scanner_ctx {int runtime; }; -void expr__ctx_init (struct expr_parse_ctx *ctx); +struct expr_parse_ctx *expr__ctx_new (void );void expr__ctx_clear (struct expr_parse_ctx *ctx); +void expr__ctx_free (struct expr_parse_ctx *ctx);void expr__del_id (struct expr_parse_ctx *ctx,const char *id);int expr__add_id (struct expr_parse_ctx *ctx,const char *id);int expr__add_id_val (struct expr_parse_ctx *ctx,const char *id,double val);
tools/perf/util/metricgroup.c +24 -20
146 lines not on this page · raw message
tools/perf/util/stat-shadow.c +32 -18
130 lines not on this page · raw message
Signature · 1 line
2.29.2.299.gdc1121823c-goog
Ian Rogers
reviewerPATCH 2/5 perf metric: Use NAN for missing event IDs.
In reply to Ian RogersIf during computing a metric an event (id) is missing the parsing aborts. A later patch will make it so that events that aren't used in the output are deliberately omitted, in which case we don't want the abort. Modify the missing ID case to report NAN for these cases.
--- tools/perf/util/expr.y | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/util/expr.y +2 -2
@@ -1,6 +1,7 @@ /* Simple expression parser */ %{ #define YYDEBUG 1 +#include <math.h> #include <stdio.h> #include "util.h" #include "util/debug.h"
@@ -89,8 +90,7 @@ expr: NUMBER struct expr_id_data *data; if (expr__resolve_id(ctx, $1, &data)) { - free($1); - YYABORT; + $$ = NAN; } $$ = data->val;
Signature · 1 line
2.29.2.299.gdc1121823c-goog
Ian Rogers
reviewerPATCH 3/5 perf metric: Rename expr__find_other.
In reply to Ian RogersA later change will remove the notion of other, rename the function to expr__find_ids as this is what it populated.
--- tools/perf/tests/expr.c | 8 ++++---- tools/perf/tests/pmu-events.c | 9 ++++----- tools/perf/util/expr.c | 4 ++-- tools/perf/util/expr.h | 2 +- tools/perf/util/metricgroup.c | 2 +- tools/perf/util/stat-shadow.c | 6 +++--- 6 files changed, 15 insertions(+), 16 deletions(-)
tools/perf/tests/expr.c +4 -4
@@ -65,8 +65,8 @@ int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused)expr__ctx_clear (ctx);TEST_ASSERT_VAL ("find other" , -expr__find_other ("FOO + BAR + BAZ + BOZO" ,"FOO" , - ctx,1 ) ==0 ); +expr__find_ids ("FOO + BAR + BAZ + BOZO" ,"FOO" , + ctx,1 ) ==0 );TEST_ASSERT_VAL ("find other" ,hashmap__size (ctx->ids) ==3 );TEST_ASSERT_VAL ("find other" ,hashmap__find (ctx->ids,"BAR" , (void **)&val_ptr));
@@ -77,8 +77,8 @@ int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused)expr__ctx_clear (ctx);TEST_ASSERT_VAL ("find other" , -expr__find_other ("EVENT1\\,param\\=?@ + EVENT2\\,param\\=?@" , -NULL , ctx,3 ) ==0 ); +expr__find_ids ("EVENT1\\,param\\=?@ + EVENT2\\,param\\=?@" , +NULL , ctx,3 ) ==0 );TEST_ASSERT_VAL ("find other" ,hashmap__size (ctx->ids) ==2 );TEST_ASSERT_VAL ("find other" ,hashmap__find (ctx->ids,"EVENT1,param=3/" , (void **)&val_ptr));
tools/perf/tests/pmu-events.c +4 -5
@@ -502,9 +502,8 @@ static int test_parsing(void)if (!pe->metric_expr)continue ;expr__ctx_clear (ctx); -if (expr__find_other (pe->metric_expr,NULL , ctx,0 ) - <0 ) { -expr_failure ("Parse other failed" , map, pe); +if (expr__find_ids (pe->metric_expr,NULL , ctx,0 ) <0 ) { +expr_failure ("Parse find ids failed" , map, pe); ret++;continue ; }
@@ -559,8 +558,8 @@ static int metric_parse_fake(const char *str)pr_debug ("parsing '%s'\n" , str); ctx =expr__ctx_new (); -if (expr__find_other (str,NULL , ctx,0 ) <0 ) { -pr_err ("expr__find_other failed\n" ); +if (expr__find_ids (str,NULL , ctx,0 ) <0 ) { +pr_err ("expr__find_ids failed\n" );return -1 ; }
tools/perf/util/expr.c +2 -2
@@ -251,8 +251,8 @@ int expr__parse(double *final_val, struct expr_parse_ctx *ctx,return __expr__parse (final_val, ctx, expr,EXPR_PARSE , runtime) ?-1 :0 ; } -int expr__find_other (const char *expr,const char *one, -struct expr_parse_ctx *ctx,int runtime) +int expr__find_ids (const char *expr,const char *one, +struct expr_parse_ctx *ctx,int runtime) {int ret =__expr__parse (NULL , ctx, expr,EXPR_OTHER , runtime);
tools/perf/util/expr.h +1 -1
@@ -55,7 +55,7 @@ int expr__resolve_id(struct expr_parse_ctx *ctx, const char *id, struct expr_id_data **datap);int expr__parse (double *final_val,struct expr_parse_ctx *ctx,const char *expr,int runtime); -int expr__find_other (const char *expr,const char *one, +int expr__find_ids (const char *expr,const char *one,struct expr_parse_ctx *ids,int runtime);#endif
tools/perf/util/metricgroup.c +1 -1
@@ -761,7 +761,7 @@ static int __add_metric(struct list_head *metric_list,* For both the parent and referenced metrics, we parse * all the metric's IDs and add it to the parent context. */ -if (expr__find_other (pe->metric_expr,NULL , m->pctx, runtime) <0 ) { +if (expr__find_ids (pe->metric_expr,NULL , m->pctx, runtime) <0 ) {if (m->metric_refs_cnt ==0 ) {expr__ctx_free (m->pctx);free (m);
tools/perf/util/stat-shadow.c +3 -3
@@ -357,9 +357,9 @@ void perf_stat__collect_metric_expr(struct evlist *evsel_list)expr__ctx_clear (ctx); metric_events = counter->metric_events;if (!metric_events) { -if (expr__find_other (counter->metric_expr, - counter->name, - ctx,1 ) <0 ) +if (expr__find_ids (counter->metric_expr, + counter->name, + ctx,1 ) <0 )continue ; metric_events = calloc(sizeof(struct evsel *),
Signature · 1 line
2.29.2.299.gdc1121823c-goog
Ian Rogers
reviewerPATCH 4/5 perf metric: Add utilities to work on ids map.
In reply to Ian RogersAdd utilities to new/free an ids hashmap, as well as to union. Add testing of the union. Unioning hashmaps will be used when parsing the metric, if a value is known then the hashmap is unnecessary, otherwise we need to union together all the event ids to compute their values for reporting.
--- tools/perf/tests/expr.c | 47 ++++++++++++++++++++++ tools/perf/util/expr.c | 87 +++++++++++++++++++++++++++++++++++++++-- tools/perf/util/expr.h | 9 +++++ 3 files changed, 139 insertions(+), 4 deletions(-)
tools/perf/tests/expr.c +47 -0
@@ -6,6 +6,51 @@#include <string.h> #include <linux/zalloc.h> +static int test_ids_union (void ) +{ +struct hashmap *ids1, *ids2; + +/* Empty union. */ + ids1 =ids__new (); +TEST_ASSERT_VAL ("ids__new" , ids1); + ids2 =ids__new (); +TEST_ASSERT_VAL ("ids__new" , ids2); + + ids1 =ids__union (ids1, ids2); +TEST_ASSERT_EQUAL ("union" , (int )hashmap__size (ids1),0 ); + +/* Union {foo, bar} against {}. */ + ids2 =ids__new (); +TEST_ASSERT_VAL ("ids__new" , ids2); + +TEST_ASSERT_EQUAL ("ids__insert" ,ids__insert (ids1,strdup ("foo" ),NULL ),0 ); +TEST_ASSERT_EQUAL ("ids__insert" ,ids__insert (ids1,strdup ("bar" ),NULL ),0 ); + + ids1 =ids__union (ids1, ids2); +TEST_ASSERT_EQUAL ("union" , (int )hashmap__size (ids1),2 ); + +/* Union {foo, bar} against {foo}. */ + ids2 =ids__new (); +TEST_ASSERT_VAL ("ids__new" , ids2); +TEST_ASSERT_EQUAL ("ids__insert" ,ids__insert (ids2,strdup ("foo" ),NULL ),0 ); + + ids1 =ids__union (ids1, ids2); +TEST_ASSERT_EQUAL ("union" , (int )hashmap__size (ids1),2 ); + +/* Union {foo, bar} against {bar,baz}. */ + ids2 =ids__new (); +TEST_ASSERT_VAL ("ids__new" , ids2); +TEST_ASSERT_EQUAL ("ids__insert" ,ids__insert (ids2,strdup ("bar" ),NULL ),0 ); +TEST_ASSERT_EQUAL ("ids__insert" ,ids__insert (ids2,strdup ("baz" ),NULL ),0 ); + + ids1 =ids__union (ids1, ids2); +TEST_ASSERT_EQUAL ("union" , (int )hashmap__size (ids1),3 ); + +ids__free (ids1); + +return 0 ; +} +static int test (struct expr_parse_ctx *ctx,const char *e,double val2) {double val;
@@ -24,6 +69,8 @@ int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused)int ret;struct expr_parse_ctx *ctx; +TEST_ASSERT_EQUAL ("ids_union" ,test_ids_union (),0 ); + ctx =expr__ctx_new ();TEST_ASSERT_VAL ("expr__ctx_new" , ctx);expr__add_id_val (ctx,strdup ("FOO" ),1 );
tools/perf/util/expr.c +83 -4
106 lines not on this page · raw message
tools/perf/util/expr.h +9 -0
@@ -42,9 +42,16 @@ struct expr_scanner_ctx {int runtime; }; +struct hashmap *ids__new (void ); +void ids__free (struct hashmap *ids); +void ids__print (struct hashmap *ids); +int ids__insert (struct hashmap *ids,const char *id,struct expr_id *parent); +struct hashmap *ids__union (struct hashmap *ids1,struct hashmap *ids2); +struct expr_parse_ctx *expr__ctx_new (void );void expr__ctx_clear (struct expr_parse_ctx *ctx);void expr__ctx_free (struct expr_parse_ctx *ctx); +void expr__del_id (struct expr_parse_ctx *ctx,const char *id);int expr__add_id (struct expr_parse_ctx *ctx,const char *id);int expr__add_id_val (struct expr_parse_ctx *ctx,const char *id,double val);
@@ -53,8 +60,10 @@ int expr__get_id(struct expr_parse_ctx *ctx, const char *id, struct expr_id_data **data);int expr__resolve_id (struct expr_parse_ctx *ctx,const char *id,struct expr_id_data **datap); +int expr__parse (double *final_val,struct expr_parse_ctx *ctx,const char *expr,int runtime); +int expr__find_ids (const char *expr,const char *one,struct expr_parse_ctx *ids,int runtime);
Signature · 1 line
2.29.2.299.gdc1121823c-goog
Ian Rogers
reviewerPATCH 5/5 perf metric: Don't compute unused events.
In reply to Ian RogersFor a metric like:
EVENT1 if #smt_on else EVENT2
currently EVENT1 and EVENT2 will be measured and then when the metric is reported EVENT1 or EVENT2 will be printed depending on the value from smt_on() during the expr parsing. Computing both events is unnecessary and can lead to multiplexing as discussed in this thread:
https://lore.kernel.org/lkml/[email protected]/
This change modifies the expression parsing code by:
- getting rid of the "other" parsing and introducing a boolean argument to say whether ids should be computed or not.
- expressions are changed so that a pair of value and ids are returned.
- when computing the metric value the ids are unused.
- when computing the ids, constant values and smt_on are assigned to the value.
- If the value is from an event ID then the event is added to the ids hashmap and the value set to NAN.
- Typically operators union IDs for their inputs and set the value to NAN, however, if the inputs are constant then these are computed and propagated as the value.
- If the input is constant to certain operators like:
IDS1 if CONST else IDS2
then the result will be either IDS1 or IDS2 depending on CONST which may be evaluated from an entire expression.
- The ids at the end of parsing are added to the context.
--- tools/perf/tests/expr.c | 10 ++ tools/perf/util/expr.c | 9 +- tools/perf/util/expr.h | 1 - tools/perf/util/expr.l | 9 -- tools/perf/util/expr.y | 341 +++++++++++++++++++++++++++++++--------- 5 files changed, 284 insertions(+), 86 deletions(-)
tools/perf/tests/expr.c +10 -0
@@ -1,6 +1,7 @@// SPDX-License-Identifier: GPL-2.0 #include "util/debug.h" #include "util/expr.h" +#include "util/smt.h" #include "tests.h" #include <stdlib.h> #include <string.h>
@@ -132,6 +133,15 @@ int test__expr(struct test *t __maybe_unused, int subtest __maybe_unused)TEST_ASSERT_VAL ("find other" ,hashmap__find (ctx->ids,"EVENT2,param=3/" , (void **)&val_ptr)); +expr__ctx_clear (ctx); +TEST_ASSERT_VAL ("find ids" , +expr__find_ids ("EVENT1 if #smt_on else EVENT2" , +NULL , ctx,0 ) ==0 ); +TEST_ASSERT_VAL ("find ids" ,hashmap__size (ctx->ids) ==1 ); +TEST_ASSERT_VAL ("find ids" ,hashmap__find (ctx->ids, +smt_on () ?"EVENT1" :"EVENT2" , + (void **)&val_ptr)); +expr__ctx_free (ctx);return 0 ;
tools/perf/util/expr.c +4 -5
@@ -293,10 +293,9 @@ void expr__ctx_free(struct expr_parse_ctx *ctx)static int __expr__parse (double *val,struct expr_parse_ctx *ctx,const char *expr, -int start,int runtime) +bool compute_ids,int runtime) {struct expr_scanner_ctx scanner_ctx = { - .start_token = start, .runtime = runtime, };YY_BUFFER_STATE buffer;
@@ -316,7 +315,7 @@ __expr__parse(double *val, struct expr_parse_ctx *ctx, const char *expr,expr_set_debug (1 , scanner);#endif - ret =expr_parse (val, ctx, scanner); + ret =expr_parse (val, ctx, compute_ids, scanner);expr__flush_buffer (buffer, scanner);expr__delete_buffer (buffer, scanner);
@@ -327,13 +326,13 @@ __expr__parse(double *val, struct expr_parse_ctx *ctx, const char *expr,int expr__parse (double *final_val,struct expr_parse_ctx *ctx,const char *expr,int runtime) { -return __expr__parse (final_val, ctx, expr,EXPR_PARSE , runtime) ?-1 :0 ; +return __expr__parse (final_val, ctx, expr,/*compute_ids=*/ false, runtime) ?-1 :0 ; }int expr__find_ids (const char *expr,const char *one,struct expr_parse_ctx *ctx,int runtime) { -int ret =__expr__parse (NULL , ctx, expr,EXPR_OTHER , runtime); +int ret =__expr__parse (NULL , ctx, expr,/*compute_ids=*/ true, runtime);if (one)expr__del_id (ctx, one);
tools/perf/util/expr.h +0 -1
@@ -38,7 +38,6 @@ struct expr_id_data { };struct expr_scanner_ctx { -int start_token;int runtime; };
tools/perf/util/expr.l +0 -9
@@ -91,15 +91,6 @@ symbol ({spec}|{sym})+ %% struct expr_scanner_ctx *sctx = expr_get_extra(yyscanner); - { - int start_token = sctx->start_token; - - if (sctx->start_token) { - sctx->start_token = 0; - return start_token; - } - } - d_ratio { return D_RATIO; } max { return MAX; } min { return MIN; }
tools/perf/util/expr.y +270 -71
383 lines not on this page · raw message
Signature · 1 line
2.29.2.299.gdc1121823c-goog
Re: [PATCH 5/5] perf metric: Don't compute unused events.
The patch does a lot of stuff and is hard to review.
The earlier patches all look good to me.
tools/perf/util/expr.c void expr__ctx_free(struct expr_parse_ctx *ctx) · line 299
Quoted 8 lines
static int
__expr__parse(double *val, structexpr_parse_ctx*ctx, const char *expr,tools/perf/util/expr.c +1
-2- int start, int runtime) + bool compute_ids, int runtime) { struct expr_scanner_ctx scanner_ctx = { - .start_token = start,
Okay so why do we not need that anymore?
This should probably be a separate change.
I'm not sure about the NaN handling. Why can't you use some other value (perhaps 0 with some special case for division)
After all the computed values of the dead branch shouldn't be used anyways, so I don't think we need the extra NaN ceremony everywhere.
The only thing that really matters is to track that the event is not added and not resolved.
I think it would be a lot simpler if we changed the IF syntax. The problem right now is that the condition is after the first expression, so you can't use global state with an early reduction to track if the if branch is dead or not.
If we used the C style cond ? a : b it could be
cond { set flag } '?' expr { reset flag } : expr { reset flag }
scanner checks flag and ignores the event if false
This would need changing the JSON files but that should be easy enough with a script.
Or maybe at some point need to bite the bullet and build an AST, but for now we probably can get away of not doing it.
-Andi