Skip to content

netdevsim: add ethtool coalesce and ring settings

Antonio Cardace netdev 5 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 1 replyApplied
  2. v56 patches 1 replySuperseded
  3. v46 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v34 patches11 repliesSuperseded
v24 patches1 replySuperseded

Changes in v6 from the cover letter

- moved some bits from patch 3, they
were part of a refactoring made in patch 2

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/6ethtool: add ETHTOOL_COALESCE_ALL_PARAMS defineinclude/linux/ethtool.h+1 -00 replies
2/6netdevsim: move ethtool pause params in separate structdrivers/net/netdevsim/ethtool.c drivers/net/netdevsim/netdevsim.h+13 -90 replies
3/6netdevsim: support ethtool ring and coalesce settingsdrivers/net/netdevsim/ethtool.c drivers/net/netdevsim/netdevsim.h+66 -30 replies
4/6selftests: extract common functions in ethtool-common.shtools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh tools/testing/selftests/drivers/net/netdevsim/ethtool-pause.sh+71 -610 replies
5/6selftests: refactor get_netdev_name functiontools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh+2 -180 replies
6/6selftests: add ring and coalesce selfteststools/testing/selftests/drivers/net/netdevsim/ethtool-coalesce.sh tools/testing/selftests/drivers/net/netdevsim/ethtool-ring.sh+217 -00 replies

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchMichal Kubecek
1/6R-b
2/6R-b
3/6R-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH net-next v6 0/6] netdevsim: add ethtool coalesce and ring settings

Output of ethtool-ring.sh and ethtool-coalesce.sh selftests:

# ./ethtool-ring.sh
PASSED all 4 checks
# ./ethtool-coalesce.sh
PASSED all 22 checks
# ./ethtool-pause.sh
PASSED all 7 checks

Changelog v5 -> v6
- moved some bits from patch 3, they
were part of a refactoring made in patch 2

Antonio Cardace (6):
ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define
netdevsim: move ethtool pause params in separate struct
netdevsim: support ethtool ring and coalesce settings
selftests: extract common functions in ethtool-common.sh
selftests: refactor get_netdev_name function
selftests: add ring and coalesce selftests

 drivers/net/netdevsim/ethtool.c               |  82 +++++++++--
 drivers/net/netdevsim/netdevsim.h             |   9 +-
 include/linux/ethtool.h                       |   1 +
 .../drivers/net/netdevsim/ethtool-coalesce.sh | 132 ++++++++++++++++++
 .../drivers/net/netdevsim/ethtool-common.sh   |  53 +++++++
 .../drivers/net/netdevsim/ethtool-pause.sh    |  63 +--------
 .../drivers/net/netdevsim/ethtool-ring.sh     |  85 +++++++++++
 7 files changed, 352 insertions(+), 73 deletions(-)
 create mode 100755 tools/testing/selftests/drivers/net/netdevsim/ethtool-coalesce.sh
 create mode 100644 tools/testing/selftests/drivers/net/netdevsim/ethtool-common.sh
 create mode 100755 tools/testing/selftests/drivers/net/netdevsim/ethtool-ring.sh

--
2.28.0