Skip to content

Remove one more platform_device_add_properties() call

Heikki Krogerus linux-acpi linux-usb lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesIn review
  2. v23 patches 12 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4software node: Introduce device_add_software_node()drivers/base/swnode.c include/linux/property.h+65 -90 replies
2/4usb: dwc3: pci: Register a software node for the dwc3 platform devicedrivers/usb/dwc3/dwc3-pci.c+37 -240 replies
3/4usb: dwc3: pci: ID for Tiger Lake CPUdrivers/usb/dwc3/dwc3-pci.c+4 -00 replies
4/4usb: dwc3: pci: add support for the Intel Alder Lake-Pdrivers/usb/dwc3/dwc3-pci.c+4 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchFelipe Balbi
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] Remove one more platform_device_add_properties() call

Hi,

I'm now clearing the dev_fwnode(dev)->secondary pointer in device_remove_software_node() as requested by Daniel and Andy. Thanks guys, it's much better now. I also took the liberty of including one more PCI ID patch where I add PCI ID for the Alder Lake-P variant. I hope that is OK.

Andy, I dropped your Tested-by tag because of the change I made to the first patch. If you have time to retest these, I would much appreciate.

v2 cover letter:

Hi Felipe, Rafael,

This is the second version of this series. There are no real changes, but I added the Tiger Lake ID patch to this series in hope that it will make your life a bit easier, assuming that Rafael will still pick these.

The original over letter:

I originally introduced these as part of my series where I was proposing PM ops for software nodes [1], but since that still needs work, I'm sending these two separately.

So basically I'm only modifying dwc3-pci.c so it registers a software node directly at this point. That will remove one more user of platform_device_add_properties().

[1] https://lore.kernel.org/lkml/[email protected]/

thanks,

Heikki Krogerus (4):
software node: Introduce device_add_software_node()
usb: dwc3: pci: Register a software node for the dwc3 platform device
usb: dwc3: pci: ID for Tiger Lake CPU
usb: dwc3: pci: add support for the Intel Alder Lake-P

 drivers/base/swnode.c       | 71 ++++++++++++++++++++++++++++++++-----
 drivers/usb/dwc3/dwc3-pci.c | 69 ++++++++++++++++++++++-------------
 include/linux/property.h    |  3 ++
 3 files changed, 110 insertions(+), 33 deletions(-)
Signature · 1 line
2.29.2