Skip to content

drivers/video: W=1 warning fixes

Sam Ravnborg dri-devel linux-arm-kernel linux-fbdev oe-kbuild-all 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 21 repliesIn review
  2. v228 patches 49 repliesApplied
  3. v128 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Applied patches that was acked - thanks Thomas!
- Updated patches after feedback from Randy and Thomas
- Added several new patches to cover warnings that triggers with other architectures than the one I used for v1 + v2
- Included one sh specific fix that handle a corner-case, let's see what the sh people say to that
- One fix to previous set of patches to fix an issue reported by Coverity (By Colin)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13video: fbdev: hgafb: Fix kernel-doc warningsdrivers/video/fbdev/hgafb.c+5 -51 reply
2/13video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notifydrivers/video/fbdev/core/fb_notify.c drivers/video/fbdev/core/fbmon.c+11 -16 replies
3/13video: fbdev: omapfb: Fix set but not used warnings in hdmi*_coredrivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c+4 -41 reply
4/13video: fbdev: uvesafb: Fix set but not used warningdrivers/video/fbdev/uvesafb.c+2 -01 reply
5/13sh: Fix set but not used warnings with !CONFIG_MMUarch/sh/include/asm/io.h+1 -13 replies
6/13video: fbdev: sparc drivers: fix kernel-doc warnings for blank_modedrivers/video/fbdev/bw2.c drivers/video/fbdev/cg3.c drivers/video/fbdev/cg6.c +4 more+7 -71 reply
7/13video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_writedrivers/video/fbdev/mmp/hw/mmp_spi.c+1 -11 reply
8/13video: fbdev: wmt_ge_rops: Fix function not declared warningsdrivers/video/fbdev/wmt_ge_rops.c+1 -01 reply
9/13video: fbdev: goldfishfb: Fix defined but not used warningdrivers/video/fbdev/goldfishfb.c+2 -01 reply
10/13video: fbdev: gbefb: Fix set but not used warningdrivers/video/fbdev/gbefb.c+1 -31 reply
11/13video: fbdev: efifb: Fix set but not used warning for screen_pitchdrivers/video/fbdev/efifb.c+1 -21 reply
12/13video: fbdev: controlfb: Fix set but not used warningsdrivers/video/fbdev/controlfb.c+2 -21 reply
13/13video: fbdev: sis: Drop useless call to SiS_GetResInfo()drivers/video/fbdev/sis/init.c+0 -11 reply

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchRandy DunlapThomas Zimmermann
1/13A-b
2/13A-b
3/13A-b
4/13A-b
5/13A-b
6/13A-b
7/13A-b
8/13A-b
9/13A-b
10/13A-b
11/13A-b
12/13A-b
13/13A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/13] drivers/video: W=1 warning fixes

Following the great work of Lee Jones in other subsystems here is a set of patches that address all remaining W=1 warnings in drivers/video/.
Lee Jones already fixed all warnings in video/backlight/ so this is mostly fbdev related fixes.

The general approach used were:
- Fix kernel-doc, this is often very trivial
- Drop unused local variables

Build tested on a set of architectures with various configs.

The patches do not depend on each other and fixes for one driver are kept in a single patch.

v2:
- Updated subject of the patches to tell what was fixed (Lee)
- Fixed build error in one patch (kernel test robot)
- A few editorials updates to the changelog messages

v3:
- Applied patches that was acked - thanks Thomas!
- Updated patches after feedback from Randy and Thomas
- Added several new patches to cover warnings that triggers with other architectures than the one I used for v1 + v2
- Included one sh specific fix that handle a corner-case, let's see what the sh people say to that
- One fix to previous set of patches to fix an issue reported by Coverity (By Colin)

Sam

Sam Ravnborg (13):
video: fbdev: hgafb: Fix kernel-doc warnings
video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify
video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core
video: fbdev: uvesafb: Fix set but not used warning
sh: Fix set but not used warnings with !CONFIG_MMU
video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode
video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write
video: fbdev: wmt_ge_rops: Fix function not declared warnings
video: fbdev: goldfishfb: Fix defined but not used warning
video: fbdev: gbefb: Fix set but not used warning
video: fbdev: efifb: Fix set but not used warning for screen_pitch
video: fbdev: controlfb: Fix set but not used warnings
video: fbdev: sis: Drop useless call to SiS_GetResInfo()

 arch/sh/include/asm/io.h                          |  2 +-
 drivers/video/fbdev/bw2.c                         |  2 +-
 drivers/video/fbdev/cg3.c                         |  2 +-
 drivers/video/fbdev/cg6.c                         |  2 +-
 drivers/video/fbdev/controlfb.c                   |  4 ++--
 drivers/video/fbdev/core/fb_notify.c              | 10 ++++++++++
 drivers/video/fbdev/core/fbmon.c                  |  2 +-
 drivers/video/fbdev/efifb.c                       |  3 +--
 drivers/video/fbdev/ffb.c                         |  2 +-
 drivers/video/fbdev/gbefb.c                       |  4 +---
 drivers/video/fbdev/goldfishfb.c                  |  2 ++
 drivers/video/fbdev/hgafb.c                       | 10 +++++-----
 drivers/video/fbdev/leo.c                         |  2 +-
 drivers/video/fbdev/mmp/hw/mmp_spi.c              |  2 +-
 drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c |  4 ++--
 drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c |  4 ++--
 drivers/video/fbdev/p9100.c                       |  2 +-
 drivers/video/fbdev/sis/init.c                    |  1 -
 drivers/video/fbdev/tcx.c                         |  2 +-
 drivers/video/fbdev/uvesafb.c                     |  2 ++
 drivers/video/fbdev/wmt_ge_rops.c                 |  1 +
 21 files changed, 38 insertions(+), 27 deletions(-)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel