Skip to contentSkip to conversation

drivers/video: W=1 warning fixes

PATCH In review Sam Ravnborg 4 participants 36 messages Dec 6, 2020 – Dec 8, 2020

Subsystems (8)
lore
Share & tools
lore
#0 lore raw

v3 cover drivers/video: W=1 warning fixes

Following the great work of Lee Jones in other subsystems here is a set of patches that address all remaining W=1 warnings in drivers/video/.
Lee Jones already fixed all warnings in video/backlight/ so this is mostly fbdev related fixes.

The general approach used were:
- Fix kernel-doc, this is often very trivial
- Drop unused local variables

Build tested on a set of architectures with various configs.

The patches do not depend on each other and fixes for one driver are kept in a single patch.

v2:
- Updated subject of the patches to tell what was fixed (Lee)
- Fixed build error in one patch (kernel test robot)
- A few editorials updates to the changelog messages

v3:
- Applied patches that was acked - thanks Thomas!
- Updated patches after feedback from Randy and Thomas
- Added several new patches to cover warnings that triggers with other architectures than the one I used for v1 + v2
- Included one sh specific fix that handle a corner-case, let's see what the sh people say to that
- One fix to previous set of patches to fix an issue reported by Coverity (By Colin)

Sam

Sam Ravnborg (13):
video: fbdev: hgafb: Fix kernel-doc warnings
video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify
video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core
video: fbdev: uvesafb: Fix set but not used warning
sh: Fix set but not used warnings with !CONFIG_MMU
video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode
video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write
video: fbdev: wmt_ge_rops: Fix function not declared warnings
video: fbdev: goldfishfb: Fix defined but not used warning
video: fbdev: gbefb: Fix set but not used warning
video: fbdev: efifb: Fix set but not used warning for screen_pitch
video: fbdev: controlfb: Fix set but not used warnings
video: fbdev: sis: Drop useless call to SiS_GetResInfo()

 arch/sh/include/asm/io.h                          |  2 +-
 drivers/video/fbdev/bw2.c                         |  2 +-
 drivers/video/fbdev/cg3.c                         |  2 +-
 drivers/video/fbdev/cg6.c                         |  2 +-
 drivers/video/fbdev/controlfb.c                   |  4 ++--
 drivers/video/fbdev/core/fb_notify.c              | 10 ++++++++++
 drivers/video/fbdev/core/fbmon.c                  |  2 +-
 drivers/video/fbdev/efifb.c                       |  3 +--
 drivers/video/fbdev/ffb.c                         |  2 +-
 drivers/video/fbdev/gbefb.c                       |  4 +---
 drivers/video/fbdev/goldfishfb.c                  |  2 ++
 drivers/video/fbdev/hgafb.c                       | 10 +++++-----
 drivers/video/fbdev/leo.c                         |  2 +-
 drivers/video/fbdev/mmp/hw/mmp_spi.c              |  2 +-
 drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c |  4 ++--
 drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c |  4 ++--
 drivers/video/fbdev/p9100.c                       |  2 +-
 drivers/video/fbdev/sis/init.c                    |  1 -
 drivers/video/fbdev/tcx.c                         |  2 +-
 drivers/video/fbdev/uvesafb.c                     |  2 ++
 drivers/video/fbdev/wmt_ge_rops.c                 |  1 +
 21 files changed, 38 insertions(+), 27 deletions(-)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#1 lore raw

PATCH v3 1/13 video: fbdev: hgafb: Fix kernel-doc warnings

Fix kernel-doc comments.

v2:
- Updated subject (Lee)

v3:
- Add space after ':' (Randy)
- Fix name of function in comment

---
 drivers/video/fbdev/hgafb.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/video/fbdev/hgafb.c +5 -5
index a45fcff1461f..8bbac7182ad3 100644
@@ -357,8 +357,8 @@ static int hga_card_detect(void)
 
 /**
  *	hgafb_open - open the framebuffer device
- *	@info:pointer to fb_info object containing info for current hga board
- *	@int:open by console system or userland.
+ *	@info: pointer to fb_info object containing info for current hga board
+ *	@init: open by console system or userland.
  */
 
 static int hgafb_open(struct fb_info *info, int init)
@@ -370,9 +370,9 @@ static int hgafb_open(struct fb_info *info, int init)
 }
 
 /**
- *	hgafb_open - open the framebuffer device
- *	@info:pointer to fb_info object containing info for current hga board
- *	@int:open by console system or userland.
+ *	hgafb_release - open the framebuffer device
+ *	@info: pointer to fb_info object containing info for current hga board
+ *	@init: open by console system or userland.
  */
 
 static int hgafb_release(struct fb_info *info, int init)
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 1/13
#2 lore raw

Re: [PATCH v3 01/13] video: fbdev: hgafb: Fix kernel-doc warnings

Quoted 36 lines · Sam Ravnborg

Fix kernel-doc comments.

v2:
- Updated subject (Lee)

v3:
- Add space after ':' (Randy)
- Fix name of function in comment

---
 drivers/video/fbdev/hgafb.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/video/fbdev/hgafb.c +2 -2
index a45fcff1461f..8bbac7182ad3 100644
@@ -357,8 +357,8 @@ static int hga_card_detect(void)
 
 /**
  *	hgafb_open - open the framebuffer device
- *	@info:pointer to fb_info object containing info for current hga board
- *	@int:open by console system or userland.
+ *	@info: pointer to fb_info object containing info for current hga board
+ *	@init: open by console system or userland.
  */
 
 static int hgafb_open(struct fb_info *info, int init)
@@ -370,9 +370,9 @@ static int hgafb_open(struct fb_info *info, int init)
 }
 

drivers/video/fbdev/hgafb.c static int hgafb_open(struct fb_info *info, int init) · line 378

Quoted 10 lines
drivers/video/fbdev/hgafb.c +3 -3
 /**
- *	hgafb_open - open the framebuffer device
- *	@info:pointer to fb_info object containing info for current hga board
- *	@int:open by console system or userland.
+ *	hgafb_release - open the framebuffer device
+ *	@info: pointer to fb_info object containing info for current hga board
+ *	@init: open by console system or userland.
  */
 
 static int hgafb_release(struct fb_info *info, int init)

LGTM. Thanks.

Signature · 6 lines
~Randy

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#3 lore raw

PATCH v3 2/13 video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

In reply to Sam Ravnborg

Fix kernel-doc warnings reported when using W=1

v2:
- Improve subject (Lee)

v3:
- Add RETURNS documentation (Thomas)

Cc Lee Jones <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc "Alexander A. Klimov" <[email protected]>
---
 drivers/video/fbdev/core/fb_notify.c | 10 ++++++++++
 drivers/video/fbdev/core/fbmon.c     |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)
drivers/video/fbdev/core/fb_notify.c +10 -0
index 74c2da528884..4e39c61fae1f 100644
@@ -19,6 +19,9 @@ static BLOCKING_NOTIFIER_HEAD(fb_notifier_list);
 /**
  *	fb_register_client - register a client notifier
  *	@nb: notifier block to callback on events
+ *
+ *	RETURNS:
+ *	0 on success, negative error code on failure.
  */
 int fb_register_client(struct notifier_block *nb)
 {
@@ -29,6 +32,9 @@ EXPORT_SYMBOL(fb_register_client);
 /**
  *	fb_unregister_client - unregister a client notifier
  *	@nb: notifier block to callback on events
+ *
+ *	RETURNS:
+ *	0 on success, negative error code on failure.
  */
 int fb_unregister_client(struct notifier_block *nb)
 {
@@ -38,7 +44,11 @@ EXPORT_SYMBOL(fb_unregister_client);
 
 /**
  * fb_notifier_call_chain - notify clients of fb_events
+ * @val: value passed to callback
+ * @v: pointer passed to callback
  *
+ * RETURNS:
+ * The return value of the last notifier function
  */
 int fb_notifier_call_chain(unsigned long val, void *v)
 {
drivers/video/fbdev/core/fbmon.c +1 -1
index 1bf82dbc9e3c..b0e690f41025 100644
@@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block,
  * fb_create_modedb - create video mode database
  * @edid: EDID data
  * @dbsize: database size
+ * @specs: monitor specifications, may be NULL
  *
  * RETURNS: struct fb_videomode, @dbsize contains length of database
  *
@@ -1100,7 +1101,6 @@ static u32 fb_get_hblank_by_hfreq(u32 hfreq, u32 xres)
  *                                    2 * M
  *        M = 300;
  *        C = 30;
-
  */
 static u32 fb_get_hblank_by_dclk(u32 dclk, u32 xres)
 {
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

Quoted 7 lines · Sam Ravnborg

Fix kernel-doc warnings reported when using W=1

v2:
- Improve subject (Lee)

v3:
- Add RETURNS documentation (Thomas)

Hi Sam,

Yes, RETURNS: will work. It just looks like any kernel-doc section name, such as Context: or Note:.
However, the documented format for return info is "Return:". (see Documentation/doc-guide/kernel-doc.rst)

Quoted 60 lines
Cc Lee Jones <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc "Alexander A. Klimov" <[email protected]>
---
 drivers/video/fbdev/core/fb_notify.c | 10 ++++++++++
 drivers/video/fbdev/core/fbmon.c     |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)
drivers/video/fbdev/core/fb_notify.c +10 -0
index 74c2da528884..4e39c61fae1f 100644
@@ -19,6 +19,9 @@ static BLOCKING_NOTIFIER_HEAD(fb_notifier_list);
 /**
  *	fb_register_client - register a client notifier
  *	@nb: notifier block to callback on events
+ *
+ *	RETURNS:
+ *	0 on success, negative error code on failure.
  */
 int fb_register_client(struct notifier_block *nb)
 {
@@ -29,6 +32,9 @@ EXPORT_SYMBOL(fb_register_client);
 /**
  *	fb_unregister_client - unregister a client notifier
  *	@nb: notifier block to callback on events
+ *
+ *	RETURNS:
+ *	0 on success, negative error code on failure.
  */
 int fb_unregister_client(struct notifier_block *nb)
 {
@@ -38,7 +44,11 @@ EXPORT_SYMBOL(fb_unregister_client);
 
 /**
  * fb_notifier_call_chain - notify clients of fb_events
+ * @val: value passed to callback
+ * @v: pointer passed to callback
  *
+ * RETURNS:
+ * The return value of the last notifier function
  */
 int fb_notifier_call_chain(unsigned long val, void *v)
 {
drivers/video/fbdev/core/fbmon.c +1 -0
index 1bf82dbc9e3c..b0e690f41025 100644
@@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block,
  * fb_create_modedb - create video mode database
  * @edid: EDID data
  * @dbsize: database size
+ * @specs: monitor specifications, may be NULL
  *
  * RETURNS: struct fb_videomode, @dbsize contains length of database
  *
Signature · 1 line
~Randy
#5 lore raw

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

Hi Randy.

Quoted 9 lines · Randy Dunlap
Quoted 7 lines · Sam Ravnborg

Fix kernel-doc warnings reported when using W=1

v2:
- Improve subject (Lee)

v3:
- Add RETURNS documentation (Thomas)

Quoted 6 lines

Hi Sam,

Yes, RETURNS: will work. It just looks like any kernel-doc section name, such as Context: or Note:.
However, the documented format for return info is "Return:". (see Documentation/doc-guide/kernel-doc.rst)

OK, like this?
I did not fix any existing uses of RETURNS, thats for another patch.

Sam

commit 03b7c3ecf7cb51b5429ca0ef58a32bb4dc486610

Author: Sam Ravnborg <[email protected]>
Date:   Sat Nov 28 23:40:49 2020 +0100

video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

Fix kernel-doc warnings reported when using W=1

v2:
- Improve subject (Lee)

v3:
- Add RETURNS documentation (Thomas)

v4:
- Use Return: not RETURNS (Randy)

Cc Lee Jones <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc "Alexander A. Klimov" <[email protected]>
drivers/video/fbdev/core/fb_notify.c +7 -0
index 74c2da528884..10e3b9a74adc 100644
@@ -19,6 +19,8 @@ static BLOCKING_NOTIFIER_HEAD(fb_notifier_list);
 /**
  *	fb_register_client - register a client notifier
  *	@nb: notifier block to callback on events
+ *
+ *	Return: 0 on success, negative error code on failure.
  */
 int fb_register_client(struct notifier_block *nb)
 {
@@ -29,6 +31,8 @@ EXPORT_SYMBOL(fb_register_client);
 /**
  *	fb_unregister_client - unregister a client notifier
  *	@nb: notifier block to callback on events
+ *
+ *	Return: 0 on success, negative error code on failure.
  */
 int fb_unregister_client(struct notifier_block *nb)
 {
@@ -38,7 +42,10 @@ EXPORT_SYMBOL(fb_unregister_client);
 
 /**
  * fb_notifier_call_chain - notify clients of fb_events
+ * @val: value passed to callback
+ * @v: pointer passed to callback
  *
+ * Return: The return value of the last notifier function
  */
 int fb_notifier_call_chain(unsigned long val, void *v)
 {
drivers/video/fbdev/core/fbmon.c +1 -1
index 1bf82dbc9e3c..b0e690f41025 100644
@@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block,
  * fb_create_modedb - create video mode database
  * @edid: EDID data
  * @dbsize: database size
+ * @specs: monitor specifications, may be NULL
  *
  * RETURNS: struct fb_videomode, @dbsize contains length of database
  *
@@ -1100,7 +1101,6 @@ static u32 fb_get_hblank_by_hfreq(u32 hfreq, u32 xres)
  *                                    2 * M
  *        M = 300;
  *        C = 30;
-
  */
 static u32 fb_get_hblank_by_dclk(u32 dclk, u32 xres)
 {

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Acked-by
#6 lore raw

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

Quoted 12 lines · Sam Ravnborg

Hi Randy.

Quoted 9 lines · Randy Dunlap
Quoted 7 lines · Sam Ravnborg

Fix kernel-doc warnings reported when using W=1

v2:
- Improve subject (Lee)

v3:
- Add RETURNS documentation (Thomas)

Quoted 7 lines
Quoted 6 lines

Hi Sam,

Yes, RETURNS: will work. It just looks like any kernel-doc section name, such as Context: or Note:.
However, the documented format for return info is "Return:". (see Documentation/doc-guide/kernel-doc.rst)

OK, like this?

Yes. LGTM.

Quoted 28 lines

I did not fix any existing uses of RETURNS, thats for another patch.

Sam

commit 03b7c3ecf7cb51b5429ca0ef58a32bb4dc486610

Author: Sam Ravnborg <[email protected]>
Date:   Sat Nov 28 23:40:49 2020 +0100

video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

Fix kernel-doc warnings reported when using W=1

v2:
- Improve subject (Lee)

v3:
- Add RETURNS documentation (Thomas)

v4:
- Use Return: not RETURNS (Randy)

Cc Lee Jones <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc "Alexander A. Klimov" <[email protected]>
Signature · 1 line
~Randy
#7 lore raw

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

In reply to Randy Dunlap

Hi

Am 06.12.20 um 20:37 schrieb Randy Dunlap:

Quoted 9 lines · Sam Ravnborg
Quoted 7 lines

Fix kernel-doc warnings reported when using W=1

v2:
- Improve subject (Lee)

v3:
- Add RETURNS documentation (Thomas)

Quoted 6 lines

Hi Sam,

Yes, RETURNS: will work. It just looks like any kernel-doc section name, such as Context: or Note:.
However, the documented format for return info is "Return:". (see Documentation/doc-guide/kernel-doc.rst)

Thanks for the note. I asked for RETURNS: because the rest of the file appears to be using it. Returns: is certainly the better alternative. I didn't know there was a difference.

Best regards
Thomas

Quoted 64 lines
Quoted 62 lines
Cc Lee Jones <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc "Alexander A. Klimov" <[email protected]>
---
  drivers/video/fbdev/core/fb_notify.c | 10 ++++++++++
  drivers/video/fbdev/core/fbmon.c     |  2 +-
  2 files changed, 11 insertions(+), 1 deletion(-)
drivers/video/fbdev/core/fb_notify.c +10 -0
index 74c2da528884..4e39c61fae1f 100644
@@ -19,6 +19,9 @@ static BLOCKING_NOTIFIER_HEAD(fb_notifier_list);
  /**
   *	fb_register_client - register a client notifier
   *	@nb: notifier block to callback on events
+ *
+ *	RETURNS:
+ *	0 on success, negative error code on failure.
   */
  int fb_register_client(struct notifier_block *nb)
  {
@@ -29,6 +32,9 @@ EXPORT_SYMBOL(fb_register_client);
  /**
   *	fb_unregister_client - unregister a client notifier
   *	@nb: notifier block to callback on events
+ *
+ *	RETURNS:
+ *	0 on success, negative error code on failure.
   */
  int fb_unregister_client(struct notifier_block *nb)
  {
@@ -38,7 +44,11 @@ EXPORT_SYMBOL(fb_unregister_client);
 
  /**
   * fb_notifier_call_chain - notify clients of fb_events
+ * @val: value passed to callback
+ * @v: pointer passed to callback
   *
+ * RETURNS:
+ * The return value of the last notifier function
   */
  int fb_notifier_call_chain(unsigned long val, void *v)
  {
drivers/video/fbdev/core/fbmon.c +1 -0
index 1bf82dbc9e3c..b0e690f41025 100644
@@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block,
   * fb_create_modedb - create video mode database
   * @edid: EDID data
   * @dbsize: database size
+ * @specs: monitor specifications, may be NULL
   *
   * RETURNS: struct fb_videomode, @dbsize contains length of database
   *
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#8 lore raw

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

Quoted 19 lines · Thomas Zimmermann

Hi

Am 06.12.20 um 20:37 schrieb Randy Dunlap:

Quoted 9 lines · Sam Ravnborg
Quoted 7 lines

Fix kernel-doc warnings reported when using W=1

v2:
   - Improve subject (Lee)

v3:
   - Add RETURNS documentation (Thomas)

Quoted 6 lines

Hi Sam,

Yes, RETURNS: will work. It just looks like any kernel-doc section name, such as Context: or Note:.
However, the documented format for return info is "Return:". (see Documentation/doc-guide/kernel-doc.rst)

Quoted 5 lines

Thanks for the note. I asked for RETURNS: because the rest of the file appears to be using it. Returns: is certainly the better alternative. I didn't know there was a difference.

Best regards
Thomas

I'm not insisting on using Return:
It can stay the same as the rest of the file IMO.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Cc Lee Jones <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc "Alexander A. Klimov" <[email protected]>

---
  drivers/video/fbdev/core/fb_notify.c | 10 ++++++++++ drivers/video/fbdev/core/fbmon.c     |  2 +-

  2 files changed, 11 insertions(+), 1 deletion(-)
Signature · 1 line
~Randy
#9 lore raw

Re: [PATCH v3 02/13] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

Hi Randy,

Quoted 6 lines
Quoted 6 lines
Quoted 5 lines

Yes, RETURNS: will work. It just looks like any kernel-doc section name, such as Context: or Note:.
However, the documented format for return info is "Return:". (see Documentation/doc-guide/kernel-doc.rst)

Quoted 8 lines
Quoted 5 lines

Thanks for the note. I asked for RETURNS: because the rest of the file appears to be using it. Returns: is certainly the better alternative. I didn't know there was a difference.

Best regards
Thomas

I'm not insisting on using Return:
It can stay the same as the rest of the file IMO.

fb_notify.c contains only the three functions modified in this patch.

So it is consistent within this file, but other fbdev/core/ files uses RETURNS. git grep shows 5 hits only.

So we will stick with the documented practice here.

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#10 lore raw

PATCH v3 3/13 video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core

In reply to Sam Ravnborg

Fix a few W=1 warnings about unused assignments. Drop the unused error code.

v2:
- Subject updated (Lee)

Cc Sam Ravnborg <[email protected]>
Cc Qilong Zhang <[email protected]>
Cc "Alexander A. Klimov" <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Lee Jones <[email protected]>
---
 drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++--
 drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c +2 -2
index 726c190862d4..e6363a420933 100644
@@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 	struct hdmi_audio_format audio_format;
 	struct hdmi_audio_dma audio_dma;
 	struct hdmi_core_audio_config acore;
-	int err, n, cts, channel_count;
+	int n, cts, channel_count;
 	unsigned int fs_nr;
 	bool word_length_16b = false;
 
@@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 		return -EINVAL;
 	}
 
-	err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
+	hdmi_compute_acr(pclk, fs_nr, &n, &cts);
 
 	/* Audio clock regeneration settings */
 	acore.n = n;
drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c +2 -2
index eda29d3032e1..cb63bc0e92ca 100644
@@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 	struct hdmi_audio_format audio_format;
 	struct hdmi_audio_dma audio_dma;
 	struct hdmi_core_audio_config core_cfg;
-	int err, n, cts, channel_count;
+	int n, cts, channel_count;
 	unsigned int fs_nr;
 	bool word_length_16b = false;
 
@@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
 		return -EINVAL;
 	}
 
-	err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
+	hdmi_compute_acr(pclk, fs_nr, &n, &cts);
 	core_cfg.n = n;
 	core_cfg.cts = cts;
 
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 3/13
#11 lore raw

Re: [PATCH v3 03/13] video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 6 lines

Fix a few W=1 warnings about unused assignments. Drop the unused error code.

v2:
- Subject updated (Lee)

Quoted 6 lines
Cc Sam Ravnborg <[email protected]>
Cc Qilong Zhang <[email protected]>
Cc "Alexander A. Klimov" <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Lee Jones <[email protected]>
Quoted 50 lines
---
  drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c | 4 ++--
  drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c | 4 ++--
  2 files changed, 4 insertions(+), 4 deletions(-)
drivers/video/fbdev/omap2/omapfb/dss/hdmi4_core.c +2 -2
index 726c190862d4..e6363a420933 100644
@@ -679,7 +679,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
  	struct hdmi_audio_format audio_format;
  	struct hdmi_audio_dma audio_dma;
  	struct hdmi_core_audio_config acore;
-	int err, n, cts, channel_count;
+	int n, cts, channel_count;
  	unsigned int fs_nr;
  	bool word_length_16b = false;
 
@@ -741,7 +741,7 @@ int hdmi4_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
  		return -EINVAL;
  	}
 
-	err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
+	hdmi_compute_acr(pclk, fs_nr, &n, &cts);
 
  	/* Audio clock regeneration settings */
  	acore.n = n;
drivers/video/fbdev/omap2/omapfb/dss/hdmi5_core.c +2 -2
index eda29d3032e1..cb63bc0e92ca 100644
@@ -790,7 +790,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
  	struct hdmi_audio_format audio_format;
  	struct hdmi_audio_dma audio_dma;
  	struct hdmi_core_audio_config core_cfg;
-	int err, n, cts, channel_count;
+	int n, cts, channel_count;
  	unsigned int fs_nr;
  	bool word_length_16b = false;
 
@@ -833,7 +833,7 @@ int hdmi5_audio_config(struct hdmi_core_data *core, struct hdmi_wp_data *wp,
  		return -EINVAL;
  	}
 
-	err = hdmi_compute_acr(pclk, fs_nr, &n, &cts);
+	hdmi_compute_acr(pclk, fs_nr, &n, &cts);
  	core_cfg.n = n;
  	core_cfg.cts = cts;
 
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#12 lore raw

PATCH v3 4/13 video: fbdev: uvesafb: Fix set but not used warning

In reply to Sam Ravnborg

Fix W=1 warning by deleting unused local variable.

v2:
- Updated subject (Lee)

v3:
- Return early in case of an error (Thomas)

---
 drivers/video/fbdev/uvesafb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/video/fbdev/uvesafb.c +2 -0
index 6c9cfab39313..4df6772802d7 100644
@@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
 	task->t.regs.eax = 0x4f0a;
 	task->t.regs.ebx = 0x0;
 	err = uvesafb_exec(task);
+	if (err)
+		return err;
 
 	if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
 		par->pmi_setpal = par->ypan = 0;
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 4/13
#13 lore raw

Re: [PATCH v3 04/13] video: fbdev: uvesafb: Fix set but not used warning

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 5 lines

Fix W=1 warning by deleting unused local variable.

v2:
- Updated subject (Lee)

Quoted 7 lines

v3:
- Return early in case of an error (Thomas)

Quoted 18 lines
---
  drivers/video/fbdev/uvesafb.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/video/fbdev/uvesafb.c +2 -0
index 6c9cfab39313..4df6772802d7 100644
@@ -560,6 +560,8 @@ static int uvesafb_vbe_getpmi(struct uvesafb_ktask *task,
  	task->t.regs.eax = 0x4f0a;
  	task->t.regs.ebx = 0x0;
  	err = uvesafb_exec(task);
+	if (err)
+		return err;
 
  	if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
  		par->pmi_setpal = par->ypan = 0;
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#14 lore raw

PATCH v3 5/13 sh: Fix set but not used warnings with !CONFIG_MMU

In reply to Sam Ravnborg

Building fbdev drivers for sh with W=1 produces the following warning:

tmiofb.c: In function ‘tmiofb_remove’:
tmiofb.c:805:21: warning: variable ‘par’ set but not used

This is with allmodconfig and ARCH=sh

This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used.

Cc Thomas Zimmermann <[email protected]>
Cc Lee Jones <[email protected]>
Cc Rich Felker <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Kuninori Morimoto <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Andrew Morton <[email protected]>
---
 arch/sh/include/asm/io.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sh/include/asm/io.h +1 -1
index 6d5c6463bc07..5ad56c6c1e1e 100644
@@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size,
 #endif /* CONFIG_HAVE_IOREMAP_PROT */
 
 #else /* CONFIG_MMU */
-#define iounmap(addr)		do { } while (0)
+#define iounmap(addr)		do { (void)addr; } while (0)
 #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
 #endif /* CONFIG_MMU */
 
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#15 lore raw

Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU

I love your patch! Yet something to improve:

Hi Sam,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20201204]
[also build test ERROR on v5.10-rc6]
[cannot apply to tegra-drm/drm/tegra/for-next soc/for-next linus/master drm/drm-next v5.10-rc6 v5.10-rc5 v5.10-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sam-Ravnborg/drivers-video-W-1-warning-fixes/20201207-030414
base:    2996bd3f6ca9ea529b40c369a94b247657abdb4d
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/9c4170037512dc3810cd88f57e3c3a442304b7cf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sam-Ravnborg/drivers-video-W-1-warning-fixes/20201207-030414 git checkout 9c4170037512dc3810cd88f57e3c3a442304b7cf
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

In file included from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:17,
from arch/sh/include/asm/hardirq.h:9,
from include/linux/hardirq.h:10,
from include/linux/interrupt.h:11,
from drivers/net/ethernet/xircom/xirc2ps_cs.c:74:
drivers/net/ethernet/xircom/xirc2ps_cs.c: In function 'xirc2ps_release':

>> arch/sh/include/asm/io.h:274:29: error: void value not ignored as it ought to be
     274 | #define iounmap(addr)  do { (void)addr; } while (0)
   drivers/net/ethernet/xircom/xirc2ps_cs.c:935:4: note: in expansion of macro 'iounmap'
     935 |    iounmap(local->dingo_ccr - 0x0800);
         |    ^~~~~~~

vim +274 arch/sh/include/asm/io.h

272
273 #else /* CONFIG_MMU */

 > 274	#define iounmap(addr)		do { (void)addr; } while (0)

275 #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset))
276 #endif /* CONFIG_MMU */
277

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#16 lore raw

Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU

commit aa1f4345b5480502a4e61addf5c59d606fdbce8f

Author: Sam Ravnborg <[email protected]>
Date:   Mon Nov 30 22:09:29 2020 +0100

sh: Fix set but not used warnings with !CONFIG_MMU

Building fbdev drivers for sh with W=1 produces the following warning:

tmiofb.c: In function ‘tmiofb_remove’:
tmiofb.c:805:21: warning: variable ‘par’ set but not used

This is with allmodconfig and ARCH=sh

This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used.

v4:
- Fix build error of ethernet driver (kernel test robot) Added missing () around macro parameter

Cc kernel test robot <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc Lee Jones <[email protected]>
Cc Rich Felker <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Kuninori Morimoto <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Andrew Morton <[email protected]>
arch/sh/include/asm/io.h +1 -1
index 6d5c6463bc07..45082bcbd9aa 100644
@@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size,
 #endif /* CONFIG_HAVE_IOREMAP_PROT */
 
 #else /* CONFIG_MMU */
-#define iounmap(addr)		do { } while (0)
+#define iounmap(addr)		do { (void)(addr); } while (0)
 #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
 #endif /* CONFIG_MMU */
 
#17 lore raw

Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU

Hi "kernel test robot"

Quoted 13 lines · Sam Ravnborg

commit aa1f4345b5480502a4e61addf5c59d606fdbce8f

Author: Sam Ravnborg <[email protected]>
Date:   Mon Nov 30 22:09:29 2020 +0100

sh: Fix set but not used warnings with !CONFIG_MMU

Building fbdev drivers for sh with W=1 produces the following warning:

tmiofb.c: In function ‘tmiofb_remove’:
tmiofb.c:805:21: warning: variable ‘par’ set but not used

This is with allmodconfig and ARCH=sh

Quoted 7 lines

This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used.

v4:
- Fix build error of ethernet driver (kernel test robot) Added missing () around macro parameter

Thanks for thee quick report - it was easy to reproduce. I hope this is enough for the robot to pick up the updated patch.

Sam

Acked-by on v3 5/13
#18 lore raw

Re: [PATCH v3 05/13] sh: Fix set but not used warnings with !CONFIG_MMU

In reply to Sam Ravnborg

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 11 lines

Building fbdev drivers for sh with W=1 produces the following warning:

tmiofb.c: In function ‘tmiofb_remove’:
tmiofb.c:805:21: warning: variable ‘par’ set but not used

This is with allmodconfig and ARCH=sh

This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used.

Quoted 11 lines
Cc Thomas Zimmermann <[email protected]>
Cc Lee Jones <[email protected]>
Cc Rich Felker <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc Mike Rapoport <[email protected]>
Cc Kuninori Morimoto <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Andrew Morton <[email protected]>
Quoted 18 lines
---
  arch/sh/include/asm/io.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/sh/include/asm/io.h +1 -1
index 6d5c6463bc07..5ad56c6c1e1e 100644
@@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size,
  #endif /* CONFIG_HAVE_IOREMAP_PROT */
 
  #else /* CONFIG_MMU */
-#define iounmap(addr)		do { } while (0)
+#define iounmap(addr)		do { (void)addr; } while (0)
  #define ioremap(offset, size)	((void __iomem *)(unsigned long)(offset))
  #endif /* CONFIG_MMU */
 
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#19 lore raw

PATCH v3 6/13 video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode

In reply to Sam Ravnborg

Fix kernel-doc warnings caused by a wrong parameter name blank_mode => blank

---
 drivers/video/fbdev/bw2.c   | 2 +-
 drivers/video/fbdev/cg3.c   | 2 +-
 drivers/video/fbdev/cg6.c   | 2 +-
 drivers/video/fbdev/ffb.c   | 2 +-
 drivers/video/fbdev/leo.c   | 2 +-
 drivers/video/fbdev/p9100.c | 2 +-
 drivers/video/fbdev/tcx.c   | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
drivers/video/fbdev/bw2.c +1 -1
index 0d9a6bb57a09..e7702fe1fe7d 100644
@@ -116,7 +116,7 @@ struct bw2_par {
 
 /**
  *      bw2_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
  *      @info: frame buffer structure that represents a single frame buffer
  */
 static int
drivers/video/fbdev/cg3.c +1 -1
index 77f6470ce665..bdcc3f6ab666 100644
@@ -179,7 +179,7 @@ static int cg3_setcolreg(unsigned regno,
 
 /**
  *      cg3_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
  *      @info: frame buffer structure that represents a single frame buffer
  */
 static int cg3_blank(int blank, struct fb_info *info)
drivers/video/fbdev/cg6.c +1 -1
index a1c68cd48d7e..97ef43c25974 100644
@@ -511,7 +511,7 @@ static int cg6_setcolreg(unsigned regno,
 /**
  *	cg6_blank - Blanks the display.
  *
- *	@blank_mode: the blank mode we want.
+ *	@blank: the blank mode we want.
  *	@info: frame buffer structure that represents a single frame buffer
  */
 static int cg6_blank(int blank, struct fb_info *info)
drivers/video/fbdev/ffb.c +1 -1
index 948b73184433..b3d580e57221 100644
@@ -667,7 +667,7 @@ static int ffb_setcolreg(unsigned regno,
 
 /**
  *	ffb_blank - Optional function.  Blanks the display.
- *	@blank_mode: the blank mode we want.
+ *	@blank: the blank mode we want.
  *	@info: frame buffer structure that represents a single frame buffer
  */
 static int ffb_blank(int blank, struct fb_info *info)
drivers/video/fbdev/leo.c +1 -1
index 40b11cce0ad6..3eb0f3583f4f 100644
@@ -308,7 +308,7 @@ static int leo_setcolreg(unsigned regno,
 
 /**
  *      leo_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
  *      @info: frame buffer structure that represents a single frame buffer
  */
 static int leo_blank(int blank, struct fb_info *info)
drivers/video/fbdev/p9100.c +1 -1
index 6da672e92643..4e88a0a195ad 100644
@@ -175,7 +175,7 @@ static int p9100_setcolreg(unsigned regno,
 
 /**
  *      p9100_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
  *      @info: frame buffer structure that represents a single frame buffer
  */
 static int
drivers/video/fbdev/tcx.c +1 -1
index 34b2e5b6e84a..1638a40fed22 100644
@@ -196,7 +196,7 @@ static int tcx_setcolreg(unsigned regno,
 
 /**
  *      tcx_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
  *      @info: frame buffer structure that represents a single frame buffer
  */
 static int
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 6/13
#20 lore raw

Re: [PATCH v3 06/13] video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 5 lines

Fix kernel-doc warnings caused by a wrong parameter name blank_mode => blank

Quoted 102 lines
---
  drivers/video/fbdev/bw2.c   | 2 +-
  drivers/video/fbdev/cg3.c   | 2 +-
  drivers/video/fbdev/cg6.c   | 2 +-
  drivers/video/fbdev/ffb.c   | 2 +-
  drivers/video/fbdev/leo.c   | 2 +-
  drivers/video/fbdev/p9100.c | 2 +-
  drivers/video/fbdev/tcx.c   | 2 +-
  7 files changed, 7 insertions(+), 7 deletions(-)
drivers/video/fbdev/bw2.c +1 -1
index 0d9a6bb57a09..e7702fe1fe7d 100644
@@ -116,7 +116,7 @@ struct bw2_par {
 
  /**
   *      bw2_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
   *      @info: frame buffer structure that represents a single frame buffer
   */
  static int
drivers/video/fbdev/cg3.c +1 -1
index 77f6470ce665..bdcc3f6ab666 100644
@@ -179,7 +179,7 @@ static int cg3_setcolreg(unsigned regno,
 
  /**
   *      cg3_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
   *      @info: frame buffer structure that represents a single frame buffer
   */
  static int cg3_blank(int blank, struct fb_info *info)
drivers/video/fbdev/cg6.c +1 -1
index a1c68cd48d7e..97ef43c25974 100644
@@ -511,7 +511,7 @@ static int cg6_setcolreg(unsigned regno,
  /**
   *	cg6_blank - Blanks the display.
   *
- *	@blank_mode: the blank mode we want.
+ *	@blank: the blank mode we want.
   *	@info: frame buffer structure that represents a single frame buffer
   */
  static int cg6_blank(int blank, struct fb_info *info)
drivers/video/fbdev/ffb.c +1 -1
index 948b73184433..b3d580e57221 100644
@@ -667,7 +667,7 @@ static int ffb_setcolreg(unsigned regno,
 
  /**
   *	ffb_blank - Optional function.  Blanks the display.
- *	@blank_mode: the blank mode we want.
+ *	@blank: the blank mode we want.
   *	@info: frame buffer structure that represents a single frame buffer
   */
  static int ffb_blank(int blank, struct fb_info *info)
drivers/video/fbdev/leo.c +1 -1
index 40b11cce0ad6..3eb0f3583f4f 100644
@@ -308,7 +308,7 @@ static int leo_setcolreg(unsigned regno,
 
  /**
   *      leo_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
   *      @info: frame buffer structure that represents a single frame buffer
   */
  static int leo_blank(int blank, struct fb_info *info)
drivers/video/fbdev/p9100.c +1 -1
index 6da672e92643..4e88a0a195ad 100644
@@ -175,7 +175,7 @@ static int p9100_setcolreg(unsigned regno,
 
  /**
   *      p9100_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
   *      @info: frame buffer structure that represents a single frame buffer
   */
  static int
drivers/video/fbdev/tcx.c +1 -1
index 34b2e5b6e84a..1638a40fed22 100644
@@ -196,7 +196,7 @@ static int tcx_setcolreg(unsigned regno,
 
  /**
   *      tcx_blank - Optional function.  Blanks the display.
- *      @blank_mode: the blank mode we want.
+ *      @blank: the blank mode we want.
   *      @info: frame buffer structure that represents a single frame buffer
   */
  static int
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#21 lore raw

PATCH v3 7/13 video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write

In reply to Sam Ravnborg

Add missing parameter and drop parameter that is not present

Cc Sam Ravnborg <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/mmp/hw/mmp_spi.c +1 -1
index 1911a47769b6..16401eb95c6c 100644
@@ -17,8 +17,8 @@
 
 /**
  * spi_write - write command to the SPI port
+ * @spi:  the SPI device.
  * @data: can be 8/16/32-bit, MSB justified data to write.
- * @len:  data length.
  *
  * Wait bus transfer complete IRQ.
  * The caller is expected to perform the necessary locking.
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 7/13
#22 lore raw

Re: [PATCH v3 07/13] video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 6 lines

Add missing parameter and drop parameter that is not present

Cc Sam Ravnborg <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Quoted 19 lines
---
  drivers/video/fbdev/mmp/hw/mmp_spi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/mmp/hw/mmp_spi.c +1 -1
index 1911a47769b6..16401eb95c6c 100644
@@ -17,8 +17,8 @@
 
  /**
   * spi_write - write command to the SPI port
+ * @spi:  the SPI device.
   * @data: can be 8/16/32-bit, MSB justified data to write.
- * @len:  data length.
   *
   * Wait bus transfer complete IRQ.
   * The caller is expected to perform the necessary locking.
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#23 lore raw

PATCH v3 8/13 video: fbdev: wmt_ge_rops: Fix function not declared warnings

In reply to Sam Ravnborg

Include own header to fix "function not declared" warnings.

---
 drivers/video/fbdev/wmt_ge_rops.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/fbdev/wmt_ge_rops.c +1 -0
index 2445cfe617a9..42255d27a1db 100644
@@ -11,6 +11,7 @@
 #include <linux/fb.h>
 #include <linux/platform_device.h>
 #include "core/fb_draw.h"
+#include "wmt_ge_rops.h"
 
 #define GE_COMMAND_OFF		0x00
 #define GE_DEPTH_OFF		0x04
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 8/13
#24 lore raw

Re: [PATCH v3 08/13] video: fbdev: wmt_ge_rops: Fix function not declared warnings

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 5 lines

Include own header to fix "function not declared" warnings.

Quoted 17 lines
---
  drivers/video/fbdev/wmt_ge_rops.c | 1 +
  1 file changed, 1 insertion(+)
drivers/video/fbdev/wmt_ge_rops.c +1 -0
index 2445cfe617a9..42255d27a1db 100644
@@ -11,6 +11,7 @@
  #include <linux/fb.h>
  #include <linux/platform_device.h>
  #include "core/fb_draw.h"
+#include "wmt_ge_rops.h"
 
  #define GE_COMMAND_OFF		0x00
  #define GE_DEPTH_OFF		0x04
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#25 lore raw

PATCH v3 9/13 video: fbdev: goldfishfb: Fix defined but not used warning

In reply to Sam Ravnborg

The goldfish_fb_acpi_match table is only used with ACPI enabled. Ifdef it out unless it is needed.
This is a similar fix to what other acpi drivers do.

---
 drivers/video/fbdev/goldfishfb.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/video/fbdev/goldfishfb.c +2 -0
index 9c83ec3f8e1f..2b885cd046fe 100644
@@ -305,11 +305,13 @@ static const struct of_device_id goldfish_fb_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, goldfish_fb_of_match);
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id goldfish_fb_acpi_match[] = {
 	{ "GFSH0004", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, goldfish_fb_acpi_match);
+#endif
 
 static struct platform_driver goldfish_fb_driver = {
 	.probe		= goldfish_fb_probe,
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 9/13
#26 lore raw

Re: [PATCH v3 09/13] video: fbdev: goldfishfb: Fix defined but not used warning

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 6 lines

The goldfish_fb_acpi_match table is only used with ACPI enabled. Ifdef it out unless it is needed.
This is a similar fix to what other acpi drivers do.

Quoted 23 lines
---
  drivers/video/fbdev/goldfishfb.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/video/fbdev/goldfishfb.c +2 -0
index 9c83ec3f8e1f..2b885cd046fe 100644
@@ -305,11 +305,13 @@ static const struct of_device_id goldfish_fb_of_match[] = {
  };
  MODULE_DEVICE_TABLE(of, goldfish_fb_of_match);
 
+#ifdef CONFIG_ACPI
  static const struct acpi_device_id goldfish_fb_acpi_match[] = {
  	{ "GFSH0004", 0 },
  	{ },
  };
  MODULE_DEVICE_TABLE(acpi, goldfish_fb_acpi_match);
+#endif
 
  static struct platform_driver goldfish_fb_driver = {
  	.probe		= goldfish_fb_probe,
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#27 lore raw

PATCH v3 10/13 video: fbdev: gbefb: Fix set but not used warning

In reply to Sam Ravnborg

The variable "x" was set but never used.
Drop the redundant assignments.

---
 drivers/video/fbdev/gbefb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/fbdev/gbefb.c +1 -3
index 31270a8986e8..c5b99a4861e8 100644
@@ -198,7 +198,7 @@ static void gbe_reset(void)
 static void gbe_turn_off(void)
 {
 	int i;
-	unsigned int val, x, y, vpixen_off;
+	unsigned int val, y, vpixen_off;
 
 	gbe_turned_on = 0;
 
@@ -249,7 +249,6 @@ static void gbe_turn_off(void)
 
 	for (i = 0; i < 100000; i++) {
 		val = gbe->vt_xy;
-		x = GET_GBE_FIELD(VT_XY, X, val);
 		y = GET_GBE_FIELD(VT_XY, Y, val);
 		if (y < vpixen_off)
 			break;
@@ -260,7 +259,6 @@ static void gbe_turn_off(void)
 		       "gbefb: wait for vpixen_off timed out\n");
 	for (i = 0; i < 10000; i++) {
 		val = gbe->vt_xy;
-		x = GET_GBE_FIELD(VT_XY, X, val);
 		y = GET_GBE_FIELD(VT_XY, Y, val);
 		if (y > vpixen_off)
 			break;
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 10/13
#28 lore raw

Re: [PATCH v3 10/13] video: fbdev: gbefb: Fix set but not used warning

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 5 lines

The variable "x" was set but never used.
Drop the redundant assignments.

Quoted 34 lines
---
  drivers/video/fbdev/gbefb.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/fbdev/gbefb.c +1 -3
index 31270a8986e8..c5b99a4861e8 100644
@@ -198,7 +198,7 @@ static void gbe_reset(void)
  static void gbe_turn_off(void)
  {
  	int i;
-	unsigned int val, x, y, vpixen_off;
+	unsigned int val, y, vpixen_off;
 
  	gbe_turned_on = 0;
 
@@ -249,7 +249,6 @@ static void gbe_turn_off(void)
 
  	for (i = 0; i < 100000; i++) {
  		val = gbe->vt_xy;
-		x = GET_GBE_FIELD(VT_XY, X, val);
  		y = GET_GBE_FIELD(VT_XY, Y, val);
  		if (y < vpixen_off)
  			break;
@@ -260,7 +259,6 @@ static void gbe_turn_off(void)
  		       "gbefb: wait for vpixen_off timed out\n");
  	for (i = 0; i < 10000; i++) {
  		val = gbe->vt_xy;
-		x = GET_GBE_FIELD(VT_XY, X, val);
  		y = GET_GBE_FIELD(VT_XY, Y, val);
  		if (y > vpixen_off)
  			break;
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#29 lore raw

PATCH v3 11/13 video: fbdev: efifb: Fix set but not used warning for screen_pitch

In reply to Sam Ravnborg

screen_pitch was asssigned a value which was never used. Drop it to fix the warning

---
 drivers/video/fbdev/efifb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/video/fbdev/efifb.c +1 -2
index e57c00824965..b80ba3d2a9b8 100644
@@ -139,7 +139,7 @@ static bool efifb_bgrt_sanity_check(struct screen_info *si, u32 bmp_width)
 
 static void efifb_show_boot_graphics(struct fb_info *info)
 {
-	u32 bmp_width, bmp_height, bmp_pitch, screen_pitch, dst_x, y, src_y;
+	u32 bmp_width, bmp_height, bmp_pitch, dst_x, y, src_y;
 	struct screen_info *si = &screen_info;
 	struct bmp_file_header *file_header;
 	struct bmp_dib_header *dib_header;
@@ -193,7 +193,6 @@ static void efifb_show_boot_graphics(struct fb_info *info)
 	bmp_width = dib_header->width;
 	bmp_height = abs(dib_header->height);
 	bmp_pitch = round_up(3 * bmp_width, 4);
-	screen_pitch = si->lfb_linelength;
 
 	if ((file_header->bitmap_offset + bmp_pitch * bmp_height) >
 				bgrt_image_size)
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 11/13
#30 lore raw

Re: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 6 lines

screen_pitch was asssigned a value which was never used. Drop it to fix the warning

Quoted 26 lines
---
  drivers/video/fbdev/efifb.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/video/fbdev/efifb.c +1 -2
index e57c00824965..b80ba3d2a9b8 100644
@@ -139,7 +139,7 @@ static bool efifb_bgrt_sanity_check(struct screen_info *si, u32 bmp_width)
 
  static void efifb_show_boot_graphics(struct fb_info *info)
  {
-	u32 bmp_width, bmp_height, bmp_pitch, screen_pitch, dst_x, y, src_y;
+	u32 bmp_width, bmp_height, bmp_pitch, dst_x, y, src_y;
  	struct screen_info *si = &screen_info;
  	struct bmp_file_header *file_header;
  	struct bmp_dib_header *dib_header;
@@ -193,7 +193,6 @@ static void efifb_show_boot_graphics(struct fb_info *info)
  	bmp_width = dib_header->width;
  	bmp_height = abs(dib_header->height);
  	bmp_pitch = round_up(3 * bmp_width, 4);
-	screen_pitch = si->lfb_linelength;
 
  	if ((file_header->bitmap_offset + bmp_pitch * bmp_height) >
  				bgrt_image_size)
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#31 lore raw

PATCH v3 12/13 video: fbdev: controlfb: Fix set but not used warnings

In reply to Sam Ravnborg

The controlfb driver has a number of dummy defines for IO operations. They were introduced in commit a07a63b0e24d
("video: fbdev: controlfb: add COMPILE_TEST support").

The write variants did not use their value parameter in the dummy versions, resulting in set but not used warnings. Fix this by adding "(void)val" to silence the compiler.

Cc Sam Ravnborg <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc "Gustavo A. R. Silva" <[email protected]>
Cc Michael Ellerman <[email protected]>
---
 drivers/video/fbdev/controlfb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/controlfb.c +2 -2
index 2df56bd303d2..509311471d51 100644
@@ -64,9 +64,9 @@
 #undef in_le32
 #undef out_le32
 #define in_8(addr)		0
-#define out_8(addr, val)
+#define out_8(addr, val)	(void)(val)
 #define in_le32(addr)		0
-#define out_le32(addr, val)
+#define out_le32(addr, val)	(void)(val)
 #define pgprot_cached_wthru(prot) (prot)
 #else
 static void invalid_vram_cache(void __force *addr)
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 12/13
#32 lore raw

Re: [PATCH v3 12/13] video: fbdev: controlfb: Fix set but not used warnings

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 8 lines

The controlfb driver has a number of dummy defines for IO operations. They were introduced in commit a07a63b0e24d
("video: fbdev: controlfb: add COMPILE_TEST support").

The write variants did not use their value parameter in the dummy versions, resulting in set but not used warnings. Fix this by adding "(void)val" to silence the compiler.

Quoted 5 lines
Cc Sam Ravnborg <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc "Gustavo A. R. Silva" <[email protected]>
Cc Michael Ellerman <[email protected]>
Quoted 21 lines
---
  drivers/video/fbdev/controlfb.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/controlfb.c +2 -2
index 2df56bd303d2..509311471d51 100644
@@ -64,9 +64,9 @@
  #undef in_le32
  #undef out_le32
  #define in_8(addr)		0
-#define out_8(addr, val)
+#define out_8(addr, val)	(void)(val)
  #define in_le32(addr)		0
-#define out_le32(addr, val)
+#define out_le32(addr, val)	(void)(val)
  #define pgprot_cached_wthru(prot) (prot)
  #else
  static void invalid_vram_cache(void __force *addr)
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#33 lore raw

PATCH v3 13/13 video: fbdev: sis: Drop useless call to SiS_GetResInfo()

In reply to Sam Ravnborg

Coverity reported:

Useless call (USELESS_CALL) side_effect_free: Calling
SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex) is only useful for its
return value, which is ignored.

And this is correct - so drop the call.

Addresses-Coverity: ("Useless call")
Cc: Colin Ian King <[email protected]>
Cc: Thomas Winischhofer <[email protected]>

---
 drivers/video/fbdev/sis/init.c | 1 -
 1 file changed, 1 deletion(-)
drivers/video/fbdev/sis/init.c +0 -1
index b77ea1a8825a..b568c646a76c 100644
@@ -2659,7 +2659,6 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
    if(SiS_Pr->UseCustomMode) {
       infoflag = SiS_Pr->CInfoFlag;
    } else {
-      SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
       if(ModeNo > 0x13) {
 	 infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag;
       }
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v3 13/13
#34 lore raw

Re: [PATCH v3 13/13] video: fbdev: sis: Drop useless call to SiS_GetResInfo()

Am 06.12.20 um 20:02 schrieb Sam Ravnborg:

Quoted 6 lines

Coverity reported:

Useless call (USELESS_CALL) side_effect_free: Calling
SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex) is only useful for its
return value, which is ignored.

Quoted 7 lines

And this is correct - so drop the call.

Addresses-Coverity: ("Useless call")
Cc: Colin Ian King <[email protected]>
Cc: Thomas Winischhofer <[email protected]>

Quoted 17 lines
---
  drivers/video/fbdev/sis/init.c | 1 -
  1 file changed, 1 deletion(-)
drivers/video/fbdev/sis/init.c +0 -1
index b77ea1a8825a..b568c646a76c 100644
@@ -2659,7 +2659,6 @@ SiS_SetCRT1ModeRegs(struct SiS_Private *SiS_Pr, unsigned short ModeNo,
     if(SiS_Pr->UseCustomMode) {
        infoflag = SiS_Pr->CInfoFlag;
     } else {
-      SiS_GetResInfo(SiS_Pr, ModeNo, ModeIdIndex);
        if(ModeNo > 0x13) {
  	 infoflag = SiS_Pr->SiS_RefIndex[RRTI].Ext_InfoFlag;
        }
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#35 lore raw
In reply to Sam Ravnborg
Quoted 32 lines · Sam Ravnborg

Following the great work of Lee Jones in other subsystems here is a set of patches that address all remaining W=1 warnings in drivers/video/.
Lee Jones already fixed all warnings in video/backlight/ so this is mostly fbdev related fixes.

The general approach used were:
- Fix kernel-doc, this is often very trivial
- Drop unused local variables

Build tested on a set of architectures with various configs.

The patches do not depend on each other and fixes for one driver are kept in a single patch.

v2:
- Updated subject of the patches to tell what was fixed (Lee)
- Fixed build error in one patch (kernel test robot)
- A few editorials updates to the changelog messages

v3:
- Applied patches that was acked - thanks Thomas!
- Updated patches after feedback from Randy and Thomas
- Added several new patches to cover warnings that triggers with other architectures than the one I used for v1 + v2
- Included one sh specific fix that handle a corner-case, let's see what the sh people say to that
- One fix to previous set of patches to fix an issue reported by Coverity (By Colin)

Sam

Quoted 14 lines

Sam Ravnborg (13):
video: fbdev: hgafb: Fix kernel-doc warnings
video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify
video: fbdev: omapfb: Fix set but not used warnings in hdmi*_core
video: fbdev: uvesafb: Fix set but not used warning
sh: Fix set but not used warnings with !CONFIG_MMU
video: fbdev: sparc drivers: fix kernel-doc warnings for blank_mode
video: fbdev: mmp: Fix kernel-doc warning for lcd_spi_write
video: fbdev: wmt_ge_rops: Fix function not declared warnings
video: fbdev: goldfishfb: Fix defined but not used warning
video: fbdev: gbefb: Fix set but not used warning
video: fbdev: efifb: Fix set but not used warning for screen_pitch
video: fbdev: controlfb: Fix set but not used warnings
video: fbdev: sis: Drop useless call to SiS_GetResInfo()

Thanks for the feedback!
All applied to drm-misc-next except the sh patch.

The sh patch will be resend to the sh people as it should go in via the sh tree.

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel