Skip to content

block/rbd: migrate to coroutines and add write zeroes support

Peter Lieven qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 6 repliesIn review
  2. v36 patches 15 repliesSuperseded
  3. v27 patches 16 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches16 repliesSuperseded

Changes in v4 from the cover letter

- this patch is now rebased on top of current master
- Patch 1: just mention librbd, tweak version numbers [Ilya]
- Patch 3: use rbd_get_size instead of rbd_stat [Ilya]
- Patch 4: retain comment about using a BH in the callback [Ilya]
- Patch 5: set BDRV_REQ_NO_FALLBACK and silently ignore BDRV_REQ_MAY_UNMAP [Ilya]

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6block/rbd: bump librbd requirement to luminous releaseblock/rbd.c meson.build+13 -1141 reply
2/6block/rbd: store object_size in BDRVRBDStateblock/rbd.c+7 -110 replies
3/6block/rbd: update s->image_size in qemu_rbd_getlengthblock/rbd.c+2 -31 reply
4/6block/rbd: migrate from aio to coroutinesblock/rbd.c+90 -1621 reply
5/6block/rbd: add write zeroes supportblock/rbd.c+31 -11 reply
6/6block/rbd: drop qemu_rbd_refresh_limitsblock/rbd.c+0 -90 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchIlya Dryomov
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/6] block/rbd: migrate to coroutines and add write zeroes support

this series migrates the qemu rbd driver from the old aio emulation to native coroutines and adds write zeroes support which is important for block operations.

To achive this we first bump the librbd requirement to the already outdated luminous release of ceph to get rid of some wrappers and ifdef'ry in the code.

V4->V4:
- this patch is now rebased on top of current master
- Patch 1: just mention librbd, tweak version numbers [Ilya]
- Patch 3: use rbd_get_size instead of rbd_stat [Ilya]
- Patch 4: retain comment about using a BH in the callback [Ilya]
- Patch 5: set BDRV_REQ_NO_FALLBACK and silently ignore BDRV_REQ_MAY_UNMAP [Ilya]

V2->V3:
- this patch is now rebased on top of current master
- Patch 1: only use cc.links and not cc.run to not break cross-compiling. [Kevin]
Since Qemu 6.1 its okay to rely on librbd >= 12.x since RHEL-7 support was dropped [Daniel]
- Patch 4: dropped
- Patch 5: store BDS in RBDTask and use bdrv_get_aio_context() [Kevin]

V1->V2:
- this patch is now rebased on top of current master with Paolos upcoming fixes for the meson.build script included:
- meson: accept either shared or static libraries if --disable-static
- meson: honor --enable-rbd if cc.links test fails
- Patch 1: adjusted to meson.build script
- Patch 2: unchanged
- Patch 3: new patch
- Patch 4: do not implement empty detach_aio_context callback [Jason]
- Patch 5: - fix aio completion cleanup in error case [Jason]
- return error codes from librbd
- Patch 6: - add support for thick provisioning [Jason]
- do not set write zeroes alignment
- Patch 7: new patch

Peter Lieven (6):
block/rbd: bump librbd requirement to luminous release block/rbd: store object_size in BDRVRBDState block/rbd: update s->image_size in qemu_rbd_getlength block/rbd: migrate from aio to coroutines block/rbd: add write zeroes support block/rbd: drop qemu_rbd_refresh_limits

 block/rbd.c | 406 ++++++++++++++++------------------------------------
 meson.build |   7 +-
 2 files changed, 128 insertions(+), 285 deletions(-)
Signature · 1 line
2.17.1