Skip to content

fstests: add idmapped mounts tests

Christian Brauner fstests 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v13 Latest5 of 6 patches 0 repliesNew
  2. v125 of 6 patches 12 repliesSuperseded
  3. v115 of 6 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v105 of 6 patches16 repliesSuperseded

5 of 6 patches are in this archive. The cover letter announces 6.

Patches in v13 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6generic/631: add test for detached mount propagation.gitignore src/Makefile src/detached_mounts_propagation.c +3 more+301 -10 replies
3/6common/rc: add _scratch_{u}mount_idmapped() helpers.gitignore common/rc src/idmapped-mounts/Makefile +3 more+478 -50 replies
4/6common/quota: move _qsetup() helper to common codecommon/quota tests/xfs/050 tests/xfs/299+20 -380 replies
5/6xfs/529: quotas and idmapped mountstests/xfs/529 tests/xfs/529.out tests/xfs/group+1035 -00 replies
6/6xfs/530: quotas on idmapped mountstests/xfs/530 tests/xfs/530.out tests/xfs/group+342 -00 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/6R-b
3/6
4/6
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v13 thread

Cover letter [PATCH v13 0/6] fstests: add idmapped mounts tests

From: Christian Brauner <[email protected]>

Hey everyone,

This series is available from:
https://git.kernel.org/brauner/xfstests-dev/h/idmapped_mounts
https://gitlab.com/brauner/xfstests/-/tree/idmapped_mounts
https://github.com/brauner/xfstests/tree/idmapped_mounts

#### Unsupported filesystem

ubuntu@f2-vm:~/src/git/xfstests$ sudo ./check -g idmapped
FSTYP         -- btrfs
PLATFORM      -- Linux/x86_64 f2-vm 5.12.0-rc6-ecryptfs-6d82e210b270 #373 SMP PREEMPT Fri Apr 9 13:58:37 UTC 2021
MKFS_OPTIONS  -- /dev/loop3
MOUNT_OPTIONS -- /dev/loop3 /mnt/scratch

generic/632 files ... [not run] idmapped-mounts not support by btrfs
Ran: generic/632
Not run: generic/632
Passed all 1 tests

#### xfs

ubuntu@f2-vm:~/src/git/xfstests$ sudo ./check -g idmapped
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 f2-vm 5.12.0-rc6-ecryptfs-6d82e210b270 #373 SMP PREEMPT Fri Apr 9 13:58:37 UTC 2021
MKFS_OPTIONS  -- -f -bsize=4096 /dev/loop1
MOUNT_OPTIONS -- /dev/loop1 /mnt/scratch

generic/632 files ... 27s
xfs/529 files ... 64s
xfs/530 files ... 41s
Ran: generic/632 xfs/529 xfs/530
Passed all 3 tests

#### ext4

ubuntu@f2-vm:~/src/git/xfstests$ sudo ./check -g idmapped
FSTYP         -- ext4
PLATFORM      -- Linux/x86_64 f2-vm 5.12.0-rc6-ecryptfs-6d82e210b270 #373 SMP PREEMPT Fri Apr 9 13:58:37 UTC 2021
MKFS_OPTIONS  -- /dev/loop5
MOUNT_OPTIONS -- -o acl,user_xattr /dev/loop5 /mnt/scratch

generic/632 files ... 22s
Ran: generic/632
Passed all 1 tests

/* v13 */
- Make sure that idmapped-mount tests are skipped on unsupported filesystems.

/* v12 */
- Main change is a fix to the io_uring tests. io_uring_wait_cqe() doesn't set errno, it returns a negative errno.
- Make sure we also run without error when libcap isn't available (That was always the goal but the logic missed a few new tests.)

/* v11 */
Reworked according to Amir's comments.

/* v10 */
Reworked according to Eryu's comments.

/* v9 */
Rebased onto current master.

Thanks!
Christian

Christian Brauner (6):
generic/631: add test for detached mount propagation generic/632: add fstests for idmapped mounts common/rc: add _scratch_{u}mount_idmapped() helpers common/quota: move _qsetup() helper to common code xfs/529: quotas and idmapped mounts xfs/530: quotas on idmapped mounts

 .gitignore                            |    3 +
 README                                |    5 +-
 common/quota                          |   20 +
 common/rc                             |   69 +
 configure.ac                          |    2 +
 include/builddefs.in                  |    1 +
 m4/Makefile                           |    1 +
 m4/package_libcap.m4                  |    4 +
 src/Makefile                          |    8 +-
 src/detached_mounts_propagation.c     |  189 +
 src/feature.c                         |   40 +-
 src/idmapped-mounts/Makefile          |   40 +
 src/idmapped-mounts/idmapped-mounts.c | 8916 +++++++++++++++++++++++++
 src/idmapped-mounts/missing.h         |  151 +
 src/idmapped-mounts/mount-idmapped.c  |  431 ++
 src/idmapped-mounts/utils.c           |  134 +
 src/idmapped-mounts/utils.h           |   30 +
 tests/generic/631                     |   43 +
 tests/generic/631.out                 |    2 +
 tests/generic/632                     |   42 +
 tests/generic/632.out                 |    2 +
 tests/generic/group                   |    2 +
 tests/xfs/050                         |   19 -
 tests/xfs/299                         |   19 -
 tests/xfs/529                         |  377 ++
 tests/xfs/529.out                     |  657 ++
 tests/xfs/530                         |  212 +
 tests/xfs/530.out                     |  129 +
 tests/xfs/group                       |    2 +
 29 files changed, 11505 insertions(+), 45 deletions(-)
 create mode 100644 m4/package_libcap.m4
 create mode 100644 src/detached_mounts_propagation.c
 create mode 100644 src/idmapped-mounts/Makefile
 create mode 100644 src/idmapped-mounts/idmapped-mounts.c
 create mode 100644 src/idmapped-mounts/missing.h
 create mode 100644 src/idmapped-mounts/mount-idmapped.c
 create mode 100644 src/idmapped-mounts/utils.c
 create mode 100644 src/idmapped-mounts/utils.h
 create mode 100755 tests/generic/631
 create mode 100644 tests/generic/631.out
 create mode 100755 tests/generic/632
 create mode 100644 tests/generic/632.out
 create mode 100755 tests/xfs/529
 create mode 100644 tests/xfs/529.out
 create mode 100755 tests/xfs/530
 create mode 100644 tests/xfs/530.out

base-commit: f6ddaf130d5b0817278afe441fdde52f464f321b

Signature · 1 line
2.27.0